Renames disabled to enabled in plugin config. Closes #212 (#220)

Author: waldekmastykarz

.vscode/launch.json

@@ -10,7 +10,7 @@
       "request": "launch",
       "preLaunchTask": "build",
       // If you have changed target frameworks, make sure to update the program path.
-      "program": "${workspaceFolder}/msgraph-developer-proxy/bin/Debug/net6.0/mgdp.dll",
+      "program": "${workspaceFolder}/msgraph-developer-proxy/bin/Debug/net7.0/mgdp.dll",
       "args": [],
       "cwd": "${workspaceFolder}/msgraph-developer-proxy",
       // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console

msgraph-developer-proxy/PluginLoader.cs

@@ -30,8 +30,8 @@ public PluginLoaderResult LoadPlugins(IPluginEvents pluginEvents, IProxyContext
         string? rootDirectory = Path.GetDirectoryName(AppContext.BaseDirectory);
         if (!string.IsNullOrEmpty(rootDirectory)) {
             foreach (PluginReference h in config.Plugins) {
-                if (h.Disabled) continue;
-                // Load Handler Assembly if not disabled
+                if (!h.Enabled) continue;
+                // Load Handler Assembly if enabled
                 string pluginLocation = Path.GetFullPath(Path.Combine(rootDirectory, h.PluginPath.Replace('\\', Path.DirectorySeparatorChar)));
                 PluginLoadContext pluginLoadContext = new PluginLoadContext(pluginLocation);
                 _logger.LogDebug($"Loading from: {pluginLocation}");
@@ -103,7 +103,7 @@ internal class PluginConfig {
 }
 
 internal class PluginReference {
-    public bool Disabled { get; set; }
+    public bool Enabled { get; set; } = true;
     public string? ConfigSection { get; set; }
     public string PluginPath { get; set; } = string.Empty;
     public string Name { get; set; } = string.Empty;

msgraph-developer-proxy/appsettings.json

@@ -2,7 +2,7 @@
   "plugins": [
     {
       "name": "GraphSelectGuidancePlugin",
-      "disabled": false,
+      "enabled": true,
       "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
       "urlsToWatch": [
         "https://graph.microsoft.com/v1.0/*",
@@ -17,7 +17,7 @@
     },
     {
       "name": "GraphBetaSupportGuidancePlugin",
-      "disabled": false,
+      "enabled": true,
       "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
       "urlsToWatch": [
         "https://graph.microsoft.com/beta/*",
@@ -28,7 +28,7 @@
     },
     {
       "name": "GraphSdkGuidancePlugin",
-      "disabled": false,
+      "enabled": true,
       "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
       "urlsToWatch": [
         "https://graph.microsoft.com/v1.0/*",
@@ -43,19 +43,19 @@
     },
     {
       "name": "MockResponsePlugin",
-      "disabled": false,
+      "enabled": true,
       "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
       "configSection": "mocksPlugin"
     },
     {
       "name": "GraphRandomErrorPlugin",
-      "disabled": false,
+      "enabled": true,
       "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
       "configSection": "graphRandomErrorsPlugin"
     },
     {
       "name": "ExecutionSummaryPlugin",
-      "disabled": false,
+      "enabled": true,
       "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
       "configSection": "executionSummaryPlugin"
     }

specs/plugins.md

@@ -25,7 +25,7 @@ The existing `appsettings.json` file will be used to provide configuration. Both
 - `name` - required, a string identifier for the plugin class, allows developer to ship multiple plugins in a single assembly. This should correspond to the value returned by the `Name` property defined on the plugin class. Plugin names must be unique per-assembly.
 - `configSection` - optional, a string for which there must be a matching object property at the root of the configuration file. If a plugin supplies a `configSection` and no corresponding property exists in the configuration file an error will be thrown during start up of the proxy.
 - `urlsToWatch` - optional, an array of strings defining the urls for which this plugin will watch instead of the `urlsToWatch` at the root of the config file, this behavior is defined in the [Multi URL support spec](./multi-url-support.md).
-- `disabled` - optional boolean when true the proxy will not attempt to load this plugin.
+- `enabled` - optional boolean when `false` the proxy will not attempt to load this plugin. `true` by default.
 
 ```json
   "plugins": [
@@ -37,7 +37,7 @@ The existing `appsettings.json` file will be used to provide configuration. Both
             "https://graph.microsoft.com/v1.0/*",
             "https://graph.microsoft.com/beta/*"
         ],
-        "disabled": false
+        "enabled": true
     }
   ],
   "randomErrors": {