Evaluate excessivePermissions and properly initiate flag UsesMinimalPermissions

Author: bartizan

DevProxy.Plugins/Reporting/MinimalPermissionsGuidancePlugin.cs

@@ -103,6 +103,11 @@ public override async Task AfterRecordingStopAsync(RecordingArgs e, Cancellation
         {
             var minimalPermissions = apiSpec.CheckMinimalPermissions(requests, Logger);
 
+            IEnumerable<string> excessivePermissions = [.. minimalPermissions.TokenPermissions
+                .Except(Configuration.PermissionsToExclude ?? [])
+                .Except(minimalPermissions.MinimalScopes)
+            ];
+
             var result = new MinimalPermissionsGuidancePluginReportApiResult
             {
                 ApiName = GetApiName(minimalPermissions.OperationsFromRequests.Any() ?
@@ -112,11 +117,8 @@ public override async Task AfterRecordingStopAsync(RecordingArgs e, Cancellation
                     .Distinct()],
                 TokenPermissions = [.. minimalPermissions.TokenPermissions.Distinct()],
                 MinimalPermissions = minimalPermissions.MinimalScopes,
-                ExcessivePermissions = [.. minimalPermissions.TokenPermissions
-                    .Except(Configuration.PermissionsToExclude ?? [])
-                    .Except(minimalPermissions.MinimalScopes)
-                ],
-                UsesMinimalPermissions = !minimalPermissions.TokenPermissions.Except(minimalPermissions.MinimalScopes).Any()
+                ExcessivePermissions = excessivePermissions,
+                UsesMinimalPermissions = !excessivePermissions.Any()
             };
             results.Add(result);