Skip to content

Commit bac11b4

Browse files
Updates GitHub Actions versions for improved compatibility (#548)
* When plugin defines an empty array of URLs to watch, use the global one #527 * Refactor plugin registration on line 55 to check for both null and non-empty 'pluginUrls'. This ensures proper handling of empty plugin URL arrays and aligns with the requirement outlined in the issue. Updated the 'Register' method call to conditionally use 'pluginUrls' or default to 'defaultUrlsToWatch' based on the not null and not empty check. #528 * Fix handling of empty 'urlsToWatch' in plugins This commit addresses the issue where plugins defining an empty array for 'urlsToWatch' would result in the plugin being disabled. The code has been modified to check for both null and empty arrays, and in both cases, it now defaults to using the global list of URLs. This ensures that plugins remain active even when no specific URLs are provided. * Update dev-proxy/PluginLoader.cs * GitHub actions * Workflow Update fix: update actions --------- Co-authored-by: Waldek Mastykarz <[email protected]>
1 parent b84bdfd commit bac11b4

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

.github/workflows/codeql-analysis.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,16 @@ jobs:
3737

3838
steps:
3939
- name: Checkout repository
40-
uses: actions/checkout@v3
40+
uses: actions/checkout@v4
4141

4242
- name: Setup .NET
43-
uses: actions/setup-dotnet@v3
43+
uses: actions/setup-dotnet@v4
4444
with:
4545
dotnet-version: 8.0.x
4646

4747
# Initializes the CodeQL tools for scanning.
4848
- name: Initialize CodeQL
49-
uses: github/codeql-action/init@v2
49+
uses: github/codeql-action/init@v3
5050
with:
5151
languages: ${{ matrix.language }}
5252
# If you wish to specify custom queries, you can do so here or in a config file.
@@ -74,4 +74,4 @@ jobs:
7474
run: dotnet build --no-restore -c Release
7575

7676
- name: Perform CodeQL Analysis
77-
uses: github/codeql-action/analyze@v2
77+
uses: github/codeql-action/analyze@v3

.github/workflows/create-release.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ jobs:
1818
env:
1919
release: 'dev-proxy-${{ matrix.architecture }}-${{ github.ref_name }}'
2020
steps:
21-
- uses: actions/checkout@v3
21+
- uses: actions/checkout@v4
2222
- name: Setup .NET
23-
uses: actions/setup-dotnet@v3
23+
uses: actions/setup-dotnet@v4
2424
with:
2525
dotnet-version: 8.0.x
2626
- name: Publish ${{ matrix.architecture }}
@@ -42,7 +42,7 @@ jobs:
4242
with:
4343
filename: '../${{ env.release }}.zip'
4444
directory: './${{ env.release }}'
45-
- uses: actions/upload-artifact@v3
45+
- uses: actions/upload-artifact@v4
4646
with:
4747
name: binaries-${{ env.release }}
4848
path: ./${{ env.release }}.zip
@@ -55,8 +55,8 @@ jobs:
5555
permissions:
5656
contents: write
5757
steps:
58-
- uses: actions/checkout@v3
59-
- uses: actions/download-artifact@v3
58+
- uses: actions/checkout@v4
59+
- uses: actions/download-artifact@v4
6060
with:
6161
path: output
6262
- name: Release

.github/workflows/dotnet.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ jobs:
1515
runs-on: ubuntu-latest
1616

1717
steps:
18-
- uses: actions/checkout@v3
18+
- uses: actions/checkout@v4
1919
- name: Setup .NET
20-
uses: actions/setup-dotnet@v3
20+
uses: actions/setup-dotnet@v4
2121
with:
2222
dotnet-version: 8.0.x
2323
- name: Restore workloads

0 commit comments

Comments
 (0)