Adds printing indicator in terminal when controlling recording using web API. Closes #871 (#872)

Author: waldekmastykarz

dev-proxy/ProxyEngine.cs

@@ -33,7 +33,6 @@ public class ProxyEngine(IProxyConfiguration config, ISet<UrlToWatch> urlsToWatc
     // lists of hosts to watch extracted from urlsToWatch,
     // used for deciding which URLs to decrypt for further inspection
     private readonly ISet<UrlToWatch> _hostsToWatch = new HashSet<UrlToWatch>();
-    private static readonly object consoleLock = new();
     private readonly IProxyState _proxyState = proxyState ?? throw new ArgumentNullException(nameof(proxyState));
     // Dictionary for plugins to store data between requests
     // the key is HashObject of the SessionEventArgs object
@@ -257,7 +256,6 @@ private void StartRecording()
         }
 
         _proxyState.StartRecording();
-        PrintRecordingIndicator(_proxyState.IsRecording);
     }
 
     private async Task StopRecordingAsync()
@@ -267,28 +265,9 @@ private async Task StopRecordingAsync()
             return;
         }
 
-        PrintRecordingIndicator(false);
         await _proxyState.StopRecordingAsync();
     }
 
-    private static void PrintRecordingIndicator(bool isRecording)
-    {
-        lock (consoleLock)
-        {
-            if (isRecording)
-            {
-                Console.ForegroundColor = ConsoleColor.Red;
-                Console.Error.Write("◉");
-                Console.ResetColor();
-                Console.Error.WriteLine(" Recording... ");
-            }
-            else
-            {
-                Console.Error.WriteLine("○ Stopped recording");
-            }
-        }
-    }
-
     // Convert strings from config to regexes.
     // From the list of URLs, extract host names and convert them to regexes.
     // We need this because before we decrypt a request, we only have access

dev-proxy/ProxyState.cs

@@ -8,6 +8,8 @@ namespace Microsoft.DevProxy;
 
 public class ProxyState : IProxyState
 {
+    private static readonly object consoleLock = new object();
+
     public bool IsRecording { get; private set; } = false;
     public List<RequestLog> RequestLogs { get; } = [];
     public Dictionary<string, object> GlobalData { get; } = new() {
@@ -36,6 +38,7 @@ public void StartRecording()
         }
 
         IsRecording = true;
+        PrintRecordingIndicator(IsRecording);
     }
 
     public async Task StopRecordingAsync()
@@ -46,6 +49,7 @@ public async Task StopRecordingAsync()
         }
 
         IsRecording = false;
+        PrintRecordingIndicator(IsRecording);
 
         // clone the list so that we can clear the original
         // list in case a new recording is started, and
@@ -68,4 +72,22 @@ public void StopProxy()
     {
         _hostApplicationLifetime.StopApplication();
     }
+
+    private void PrintRecordingIndicator(bool isRecording)
+    {
+        lock (consoleLock)
+        {
+            if (isRecording)
+            {
+                Console.ForegroundColor = ConsoleColor.Red;
+                Console.Error.Write("◉");
+                Console.ResetColor();
+                Console.Error.WriteLine(" Recording... ");
+            }
+            else
+            {
+                Console.Error.WriteLine("○ Stopped recording");
+            }
+        }
+    }
 }