Skip to content

Commit f20d656

Browse files
committed
Use short-lived HTTP client controlled by DI
1 parent 751755e commit f20d656

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

DevProxy.Plugins/Reporting/GraphMinimalPermissionsGuidancePlugin.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,11 +244,10 @@ private async Task EvaluateMinimalScopesAsync(
244244
try
245245
{
246246
var url = $"https://devxapi-func-prod-eastus.azurewebsites.net/permissions?scopeType={GraphUtils.GetScopeTypeString(scopeType)}";
247-
using var client = new HttpClient();
248247
var stringPayload = JsonSerializer.Serialize(payload, ProxyUtils.JsonSerializerOptions);
249248
Logger.LogDebug("Calling {Url} with payload{NewLine}{Payload}", url, Environment.NewLine, stringPayload);
250249

251-
var response = await client.PostAsJsonAsync(url, payload, cancellationToken);
250+
var response = await PluginHttpClient.PostAsJsonAsync(url, payload, cancellationToken);
252251
var content = await response.Content.ReadAsStringAsync(cancellationToken);
253252

254253
Logger.LogDebug("Response:{NewLine}{Content}", Environment.NewLine, content);

DevProxy.Plugins/Reporting/GraphMinimalPermissionsPlugin.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,10 @@ public override async Task AfterRecordingStopAsync(RecordingArgs e, Cancellation
137137
try
138138
{
139139
var url = $"https://devxapi-func-prod-eastus.azurewebsites.net/permissions?scopeType={GraphUtils.GetScopeTypeString(Configuration.Type)}";
140-
using var client = new HttpClient();
141140
var stringPayload = JsonSerializer.Serialize(payload, ProxyUtils.JsonSerializerOptions);
142141
Logger.LogDebug("Calling {Url} with payload\r\n{StringPayload}", url, stringPayload);
143142

144-
var response = await client.PostAsJsonAsync(url, payload, cancellationToken);
143+
var response = await PluginHttpClient.PostAsJsonAsync(url, payload, cancellationToken);
145144
var content = await response.Content.ReadAsStringAsync(cancellationToken);
146145

147146
Logger.LogDebug("Response:\r\n{Content}", content);

0 commit comments

Comments
 (0)