fix: Add optional param to CheckMinimalPermissions and remove unnecessary method

bartizan · bartizan · commit fe41dd6dde15 · 2025-10-02T12:14:56.000+03:00
diff --git a/DevProxy.Plugins/Extensions/OpenApiDocumentExtensions.cs b/DevProxy.Plugins/Extensions/OpenApiDocumentExtensions.cs
@@ -15,12 +15,8 @@ namespace Microsoft.OpenApi.Models;
 
 static class OpenApiDocumentExtensions
 {
-    public static ApiPermissionsInfo CheckMinimalPermissions(this OpenApiDocument openApiDocument, IEnumerable<RequestLog> requests, ILogger logger)
-    {
-        return CheckMinimalPermissions(openApiDocument, requests, logger, null);
-    }
-
-    public static ApiPermissionsInfo CheckMinimalPermissions(this OpenApiDocument openApiDocument, IEnumerable<RequestLog> requests, ILogger logger, string? schemeName)
+    public static ApiPermissionsInfo CheckMinimalPermissions(this OpenApiDocument openApiDocument, IEnumerable<RequestLog> requests,
+        ILogger logger, string? schemeName = default)
     {
         logger.LogInformation("Checking minimal permissions for API {ApiName}...", openApiDocument.Servers.First().Url);
 

Original file line number	Diff line number	Diff line change
`@@ -15,12 +15,8 @@ namespace Microsoft.OpenApi.Models;`
`15`	`15`
`16`	`16`	`static class OpenApiDocumentExtensions`
`17`	`17`	`{`
`18`		`- public static ApiPermissionsInfo CheckMinimalPermissions(this OpenApiDocument openApiDocument, IEnumerable<RequestLog> requests, ILogger logger)`
`19`		`- {`
`20`		`- return CheckMinimalPermissions(openApiDocument, requests, logger, null);`
`21`		`- }`
`22`		`-`
`23`		`- public static ApiPermissionsInfo CheckMinimalPermissions(this OpenApiDocument openApiDocument, IEnumerable<RequestLog> requests, ILogger logger, string? schemeName)`
	`18`	`+ public static ApiPermissionsInfo CheckMinimalPermissions(this OpenApiDocument openApiDocument, IEnumerable<RequestLog> requests,`
	`19`	`+ ILogger logger, string? schemeName = default)`
`24`	`20`	`{`
`25`	`21`	`logger.LogInformation("Checking minimal permissions for API {ApiName}...", openApiDocument.Servers.First().Url);`
`26`	`22`