Skip to content

Commit 553a5f3

Browse files
rcj1Copilotjkotas
authored
Remove enum members and printout of transient flags (#5715)
Context: dotnet/runtime#124309 (comment) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com>
1 parent 5f79de2 commit 553a5f3

File tree

1 file changed

+3
-41
lines changed

1 file changed

+3
-41
lines changed

src/SOS/Strike/strike.cpp

Lines changed: 3 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -3950,43 +3950,8 @@ DECLARE_API(RCWCleanupList)
39503950
#endif // FEATURE_COMINTEROP
39513951

39523952
enum {
3953-
// These are the values set in m_dwTransientFlags.
3954-
// Note that none of these flags survive a prejit save/restore.
3955-
3956-
MODULE_IS_TENURED = 0x00000001, // Set once we know for sure the Module will not be freed until the appdomain itself exits
3957-
// unused = 0x00000002,
3958-
CLASSES_FREED = 0x00000004,
3953+
// This value is set in m_dwTransientFlags.
39593954
IS_EDIT_AND_CONTINUE = 0x00000008, // is EnC Enabled for this module
3960-
3961-
IS_PROFILER_NOTIFIED = 0x00000010,
3962-
IS_ETW_NOTIFIED = 0x00000020,
3963-
3964-
//
3965-
// Note: the order of these must match the order defined in
3966-
// cordbpriv.h for DebuggerAssemblyControlFlags. The three
3967-
// values below should match the values defined in
3968-
// DebuggerAssemblyControlFlags when shifted right
3969-
// DEBUGGER_INFO_SHIFT bits.
3970-
//
3971-
DEBUGGER_USER_OVERRIDE_PRIV = 0x00000400,
3972-
DEBUGGER_ALLOW_JIT_OPTS_PRIV= 0x00000800,
3973-
DEBUGGER_TRACK_JIT_INFO_PRIV= 0x00001000,
3974-
DEBUGGER_ENC_ENABLED_PRIV = 0x00002000, // this is what was attempted to be set. IS_EDIT_AND_CONTINUE is actual result.
3975-
DEBUGGER_PDBS_COPIED = 0x00004000,
3976-
DEBUGGER_IGNORE_PDBS = 0x00008000,
3977-
DEBUGGER_INFO_MASK_PRIV = 0x0000Fc00,
3978-
DEBUGGER_INFO_SHIFT_PRIV = 10,
3979-
3980-
// Used to indicate that this module has had it's IJW fixups properly installed.
3981-
IS_IJW_FIXED_UP = 0x00080000,
3982-
IS_BEING_UNLOADED = 0x00100000,
3983-
3984-
// Used to indicate that the module is loaded sufficiently for generic candidate instantiations to work
3985-
MODULE_READY_FOR_TYPELOAD = 0x00200000,
3986-
3987-
// Used during NGen only
3988-
TYPESPECS_TRIAGED = 0x40000000,
3989-
MODULE_SAVED = 0x80000000,
39903955
};
39913956

39923957
void ModuleMapTraverse(UINT index, CLRDATA_ADDRESS methodTable, LPVOID token)
@@ -4056,6 +4021,8 @@ DECLARE_API(DumpModule)
40564021
ExtOut("PEFile ");
40574022
if (module.bIsReflection)
40584023
ExtOut("Reflection ");
4024+
if (module.dwTransientFlags & IS_EDIT_AND_CONTINUE)
4025+
ExtOut("EditAndContinue ");
40594026

40604027
ToRelease<IXCLRDataModule> dataModule;
40614028
if (SUCCEEDED(g_sos->GetModule(TO_CDADDR(p_ModuleAddr), &dataModule)))
@@ -4073,11 +4040,6 @@ DECLARE_API(DumpModule)
40734040
}
40744041
ExtOut("\n");
40754042

4076-
ExtOut("TransientFlags: %08x ", module.dwTransientFlags);
4077-
if (module.dwTransientFlags & IS_EDIT_AND_CONTINUE)
4078-
ExtOut("IS_EDIT_AND_CONTINUE");
4079-
ExtOut("\n");
4080-
40814043
DMLOut("Assembly: %s\n", DMLAssembly(module.Assembly));
40824044

40834045
ExtOut("BaseAddress: %p\n", SOS_PTR(module.ilBase));

0 commit comments

Comments
 (0)