Skip to content

Commit 8d3bda1

Browse files
mdh1418hoyosjs
andauthored
[dotnet-trace] Include librecordtrace.so for local and CI Build (#5631)
#5619 didn't work. This time I tested these changes on the official build pipeline, and the BundledTools + .nupkg both worked on my linux-x64 WSL instance. --------- Co-authored-by: Juan Sebastian Hoyos Ayala <[email protected]>
1 parent ff0c8b1 commit 8d3bda1

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

eng/Versions.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
<MicrosoftExtensionsConfigurationVersion>8.0.0</MicrosoftExtensionsConfigurationVersion>
3737
<MicrosoftExtensionsConfigurationJsonVersion>8.0.1</MicrosoftExtensionsConfigurationJsonVersion>
3838
<MicrosoftExtensionsLoggingConfigurationVersion>8.0.1</MicrosoftExtensionsLoggingConfigurationVersion>
39+
<MicrosoftOneCollectRecordTraceVersions>0.1.32221</MicrosoftOneCollectRecordTraceVersions>
3940
<!-- Need version that understands UseAppFilters sentinel. -->
4041
<MicrosoftExtensionsLoggingEventSourceVersion>5.0.1</MicrosoftExtensionsLoggingEventSourceVersion>
4142
<SystemComponentModelAnnotationsVersion>5.0.0</SystemComponentModelAnnotationsVersion>

src/Tools/dotnet-trace/dotnet-trace.csproj

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
<ItemGroup>
1515
<PackageReference Include="System.CommandLine" Version="$(SystemCommandLineVersion)" />
1616
<PackageReference Include="Microsoft.Diagnostics.Tracing.TraceEvent" Version="$(MicrosoftDiagnosticsTracingTraceEventVersion)" GeneratePathProperty="true" />
17-
<PackageReference Include="Microsoft.OneCollect.RecordTrace" Version="0.1.32221" PrivateAssets="All" GeneratePathProperty="true"
18-
Condition="'$(TargetRid)' != '' and $([System.String]::Copy('$(TargetRid)').StartsWith('linux'))" />
17+
<PackageReference Include="Microsoft.OneCollect.RecordTrace" Version="$(MicrosoftOneCollectRecordTraceVersions)" PrivateAssets="All" GeneratePathProperty="true" />
1918
</ItemGroup>
2019

2120
<ItemGroup>
@@ -31,12 +30,18 @@
3130
<InternalsVisibleTo Include="DotnetTrace.UnitTests" />
3231
</ItemGroup>
3332

34-
<ItemGroup Condition="'$(TargetRid)' != '' and $([System.String]::Copy('$(TargetRid)').StartsWith('linux'))">
35-
<None Include="$(PkgMicrosoft_OneCollect_RecordTrace)/runtimes/$(TargetRid)/native/librecordtrace.so"
36-
Pack="true"
37-
Visible="false"
38-
CopyToOutputDirectory="PreserveNewest"
39-
CopyToPublishDirectory="PreserveNewest"
40-
Condition="Exists('$(PkgMicrosoft_OneCollect_RecordTrace)/runtimes/$(TargetRid)/native/librecordtrace.so')" />
33+
<ItemGroup>
34+
<None Include="$(PkgMicrosoft_OneCollect_RecordTrace)/runtimes/linux-x64/native/librecordtrace.so">
35+
<Visible>false</Visible>
36+
<Link Condition="'$(PublishSingleFile)' != 'true'">runtimes/linux-x64/native/librecordtrace.so</Link>
37+
<CopyToOutputDirectory Condition="'$(PublishSingleFile)' != 'true'">PreserveNewest</CopyToOutputDirectory>
38+
<CopyToPublishDirectory Condition="'$(PublishSingleFile)' == 'true' and 'linux-x64' == '$(RuntimeIdentifier)'">PreserveNewest</CopyToPublishDirectory>
39+
</None>
40+
<None Include="$(PkgMicrosoft_OneCollect_RecordTrace)/runtimes/linux-arm64/native/librecordtrace.so">
41+
<Visible>false</Visible>
42+
<Link Condition="'$(PublishSingleFile)' != 'true'">runtimes/linux-arm64/native/librecordtrace.so</Link>
43+
<CopyToOutputDirectory Condition="'$(PublishSingleFile)' != 'true'">PreserveNewest</CopyToOutputDirectory>
44+
<CopyToPublishDirectory Condition="'$(PublishSingleFile)' == 'true' and 'linux-arm64' == '$(RuntimeIdentifier)'">PreserveNewest</CopyToPublishDirectory>
45+
</None>
4146
</ItemGroup>
4247
</Project>

0 commit comments

Comments
 (0)