[dsrouter] detect Android SDK with dotnet/android-tools (#5502)

Fixes: #5474

Context: https://developer.android.com/tools/variables

`$ANDROID_SDK_ROOT` is deprecated, but it is currently the
only way to select an Android SDK path.

To fix this, track a new dependency from Maestro via:

    <Dependency Name="Xamarin.Android.Tools.AndroidSdk" Version="1.0.105-preview.225">
      <Uri>https://github.com/dotnet/android</Uri>
      <Sha>bf304cf475308547a2a1a342bb9f2e6825cc33cd</Sha>
    </Dependency>

This is the same library we use for locating the Android SDK in various
locations by Visual Studio and other tooling.

We can use this instead of only checking `$ANDROID_SDK_ROOT`.

Also, updated various messages to say `$ANDROID_HOME` instead,
which the new dependency probes for among other locations.

Co-authored-by: Jonathan Peppers <[email protected]>

Author: StephaneDelcroix

eng/Version.Details.xml

@@ -9,6 +9,10 @@
       <Uri>https://github.com/microsoft/clrmd</Uri>
       <Sha>d724947392626b66e39b525998a8817447d50380</Sha>
     </Dependency>
+    <Dependency Name="Xamarin.Android.Tools.AndroidSdk" Version="1.0.105-preview.225">
+      <Uri>https://github.com/dotnet/android</Uri>
+      <Sha>bf304cf475308547a2a1a342bb9f2e6825cc33cd</Sha>
+    </Dependency>
   </ProductDependencies>
   <ToolsetDependencies>
     <Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="10.0.0-beta.25351.106">

eng/Versions.props

@@ -72,6 +72,7 @@
     <cdbsosversion>10.0.26100.1</cdbsosversion>
     <NewtonSoftJsonVersion>13.0.1</NewtonSoftJsonVersion>
     <MicrosoftSourceBuildIntermediatesourcebuildreferencepackagesPackageVersion>10.0.622304</MicrosoftSourceBuildIntermediatesourcebuildreferencepackagesPackageVersion>
+    <XamarinAndroidToolsAndroidSdkVersion>1.0.105-preview.225</XamarinAndroidToolsAndroidSdkVersion>
     <!-- Roslyn and analyzers -->
     <!-- dotnet/roslyn dependencies -->
     <!--

src/Tools/dotnet-dsrouter/ADBTcpRouterFactory.cs

@@ -8,6 +8,7 @@
 using System.Threading.Tasks;
 using Microsoft.Diagnostics.NETCore.Client;
 using Microsoft.Extensions.Logging;
+using Xamarin.Android.Tools;
 
 namespace Microsoft.Diagnostics.Tools.DiagnosticsServerRouter
 {
@@ -65,7 +66,27 @@ public static void AdbRemovePortReverse(int localPort, int remotePort, bool owns
 
         public static bool RunAdbCommandInternal(string command, string expectedOutput, int expectedExitCode, bool rethrow, ILogger logger)
         {
-            string sdkRoot = Environment.GetEnvironmentVariable("ANDROID_SDK_ROOT");
+            void sdklogger(TraceLevel level, string message)
+            {
+                switch (level)
+                {
+                    case TraceLevel.Error:
+                        logger?.LogError(message);
+                        break;
+                    case TraceLevel.Warning:
+                        logger?.LogWarning(message);
+                        break;
+                    case TraceLevel.Info:
+                        logger?.LogInformation(message);
+                        break;
+                    case TraceLevel.Verbose:
+                        logger?.LogDebug(message);
+                        break;
+                }
+            };
+
+            // AndroidSdkInfo checks $ANDROID_SDK_ROOT, $ANDROID_HOME, and default locations.
+            string sdkRoot = new AndroidSdkInfo(logger: sdklogger).AndroidSdkPath;
             string adbTool = "adb";
 
             if (!string.IsNullOrEmpty(sdkRoot))
@@ -166,7 +187,7 @@ public override void Start()
                 _ownsPortReverse = false;
                 Logger.LogError("Failed setting up adb port reverse." +
                     " This might lead to problems communicating with Android application." +
-                    " Make sure env variable ANDROID_SDK_ROOT is set and points to an Android SDK." +
+                    " Make sure env variable $ANDROID_HOME is set and points to an Android SDK." +
                     $" Executing with unknown adb status for port {_localPort}.");
                 base.Start();
                 return;
@@ -245,7 +266,7 @@ public override void Start()
                 _ownsPortForward = false;
                 Logger.LogError("Failed setting up adb port forward." +
                     " This might lead to problems communicating with Android application." +
-                    " Make sure env variable ANDROID_SDK_ROOT is set and points to an Android SDK." +
+                    " Make sure env variable $ANDROID_HOME is set and points to an Android SDK." +
                     $" Executing with unknown adb status for port {_localPort}.");
                 return;
             }

src/Tools/dotnet-dsrouter/Program.cs

@@ -289,7 +289,7 @@ private static Command AndroidRouterCommand()
         private static readonly Option<string> ForwardPortOption =
             new("--forward-port", "-fp")
             {
-                Description = "Enable port forwarding, values Android|iOS for TcpClient and only Android for TcpServer. Make sure to set ANDROID_SDK_ROOT before using this option on Android."
+                Description = "Enable port forwarding, values Android|iOS for TcpClient and only Android for TcpServer. For Android, optionally set $ANDROID_HOME to a valid Android SDK path."
             };
 
         private static readonly Option<string> BlockedSignalsOption =

src/Tools/dotnet-dsrouter/dotnet-dsrouter.csproj

@@ -27,6 +27,7 @@
     <PackageReference Include="System.CommandLine" Version="$(SystemCommandLineVersion)" />
     <PackageReference Include="Microsoft.Extensions.Logging" Version="$(MicrosoftExtensionsLoggingVersion)" />
     <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="$(MicrosoftExtensionsLoggingConsoleVersion)" />
+    <PackageReference Include="Xamarin.Android.Tools.AndroidSdk" Version="$(XamarinAndroidToolsAndroidSdkVersion)" />
   </ItemGroup>
 
 </Project>