Change hljs theme

[pepone]

Is there a way to change the hljs theme?

[KalleOlaviNiemitalo]

Perhaps #8682 will help with that. This change is not yet in v2.66.2.

[pepone]

I saw that earlier but I cannot figure out how to do it

[pepone]

Seems the hljs style is hardcoded in

docfx/templates/default/src/docfx.vendor.js

Line 5 in fcf3d67

require('@default/highlight.js/styles/github.css')

I don't really see how we can switch, am I missing something?

[yufeih]

I agree that it looks more familiar to C# devs. It appears we could use vs for the light theme and vs2015 for the dark theme? If so a PR is welcome. The relevant code are: https://github.com/dotnet/docfx/blob/main/templates/modern/src/highlight.scss and https://github.com/dotnet/docfx/blob/main/templates/modern/src/docfx.scss#L14-L18

[wilkinson-steve]

Very happy to do a PR @yufeih and agree that vs and vs2015 are an improvement for C# users. I am just slightly worried that this may cause unexpected changes for non-C# users of docfx. What do you think? Is some sort of poll in order?

(On the basis that any change we make now is effectively hard-coded.)

[ghost]

See PR #8761.

[yufeih]

@pepone What hljs styles would you like to use?

[pepone]

The proposed themes (vs/vs2015) seem good to me.