-
Notifications
You must be signed in to change notification settings - Fork 61
Closed
microsoft/dotnet-framework-docker
#1171Description
Related: https://github.com/dotnet/dotnet-docker-internal/issues/4475
With the addition of 1ES pipeline templates, we have a few places where our default pool definitions are overridden or ignored. We should consolidate these into one set of variables for our pools and image names so we don't have any hardcoded values anywhere.
docker-tools/eng/common/templates/stages/dotnet/build-test-publish-repo.yml
Lines 64 to 73 in 5a55648
# Linux AMD64 | |
linuxAmd64Pool: | |
${{ if ne(parameters.linuxAmd64Pool, '') }}: | |
${{ parameters.linuxAmd64Pool }} | |
${{ elseif eq(variables['System.TeamProject'], parameters.publicProjectName) }}: | |
vmImage: $(defaultLinuxAmd64PoolImage) | |
${{ elseif eq(variables['System.TeamProject'], parameters.internalProjectName) }}: | |
name: NetCore1ESPool-Internal | |
image: 1es-ubuntu-2204 | |
os: linux |
docker-tools/eng/common/templates/variables/common.yml
Lines 46 to 57 in 5a55648
- name: defaultLinuxAmd64PoolImage | |
value: ubuntu-latest | |
- name: defaultLinuxArm32PoolImage | |
value: null | |
- name: defaultLinuxArm64PoolImage | |
value: null | |
- name: defaultWindows2016PoolImage | |
value: vs2017-win2016 | |
- name: defaultWindows1809PoolImage | |
value: windows-2019 | |
- name: defaultWindows2022PoolImage | |
value: windows-2022 |
extends: | |
template: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplates | |
parameters: | |
pool: | |
name: NetCore1ESPool-Internal | |
image: 1es-windows-2022 | |
os: windows |
Metadata
Metadata
Assignees
Type
Projects
Status
Done