convert priorities for AzureDevOps (#378)

* convert priorities for AzureDevOps

Somewhere in history, we stopped importing priorities. Put that back.

* Respond to feedback.

Simplify and use case insensitive comparison.

Author: BillWagner

DotNet.DocsTools/GitHubObjects/StoryPointSize.cs

@@ -24,6 +24,16 @@ public record StoryPointSize
         ["Dec"] = 12  // 2
     };
 
+    private static int? PriorityValue(string? projectPriority)
+    {
+        // Start by 1, because our DevOps instance uses 1 - 4
+        if (projectPriority?.Contains("0") == true) return 1;
+        if (projectPriority?.Contains("1") == true) return 2;
+        if (projectPriority?.Contains("2") == true) return 3;
+        if (projectPriority?.Contains("3") == true) return 4;
+        return default;
+    }
+
     public static int MonthOrdinal(string month) => s_months[month];
 
     public static bool TryGetMonthOrdinal(string month, out int ordinal)
@@ -42,13 +52,15 @@ public static bool TryGetMonthOrdinal(string month, out int ordinal)
             // size may or may not have been set yet:
             string size = "🐂 Medium";
             string? sprintMonth = default;
+            int? priority = default;
             foreach (JsonElement field in projectItem.Descendent("fieldValues", "nodes").EnumerateArray())
             {
                 if (field.TryGetProperty("name", out JsonElement fieldValue))
                 {
                     string? fieldName = field.Descendent("field", "name").GetString();
                     if (fieldName == "Sprint") sprintMonth = fieldValue.GetString();
                     if (fieldName == "Size") size = fieldValue.GetString() ?? "🐂 Medium";
+                    if (fieldName == "Priority") priority = PriorityValue(fieldValue.GetString()) ?? 2;
                 }
             }
             if ((projectTitle is not null) &&
@@ -60,7 +72,7 @@ public static bool TryGetMonthOrdinal(string month, out int ordinal)
                 string month = sprintMonth ?? components[1];
                 if (int.TryParse(components[yearIndex], out int year))
                 {
-                    sz = new StoryPointSize(year, month.Substring(0, 3), size);
+                    sz = new StoryPointSize(year, month.Substring(0, 3), size, priority);
                 }
             }
         } else
@@ -70,16 +82,18 @@ public static bool TryGetMonthOrdinal(string month, out int ordinal)
         return sz;
     }
 
-    private StoryPointSize(int CalendarYear, string Month, string Size)
+    private StoryPointSize(int CalendarYear, string Month, string Size, int? Priority)
     {
         this.CalendarYear = CalendarYear;
         this.Month = Month;
         this.Size = Size;
+        this.Priority = Priority;
     }
 
     public int CalendarYear { get; }
     public string Month { get; }
     public string Size { get; }
+    public int? Priority { get; }
 
     public bool IsPastIteration
     {

actions/sequester/Quest2GitHub.Tests/QuestWorkItemTests.cs

@@ -21,6 +21,7 @@ public void QuestItemConstructorEnsuresTitleIsTruncated(string title)
             IterationPath = "Test/Path",
             AssignedToId = Guid.NewGuid(),
             StoryPoints = 1,
+            Priority = 1,
             Tags = []
         };
 

actions/sequester/Quest2GitHub/Models/IssueExtensions.cs

@@ -40,6 +40,25 @@ month descending
         return null;
     }
 
+    public static int? GetPriority(this QuestIssueOrPullRequest issue, StoryPointSize? storySize)
+    {
+        if (storySize?.Priority is not null) return storySize.Priority;
+
+        // Well, check for priority on the issue itself:
+        foreach(var label in issue.Labels)
+        {
+            //Start at 1, because DevOps uses 1 - 4.
+            if (label.Name.StartsWith("P", true, null))
+            {
+                if (label.Name.Contains("0")) return 1;
+                if (label.Name.Contains("1")) return 2;
+                if (label.Name.Contains("2")) return 3;
+                if (label.Name.Contains("3")) return 4;
+            }
+        }
+        return default;
+    }
+
     public static QuestIteration? ProjectIteration(this StoryPointSize storyPoints, IEnumerable<QuestIteration> iterations)
     {
         // New form: Content\Gallium\FY24Q1\07

actions/sequester/Quest2GitHub/Models/QuestWorkItem.cs

@@ -76,6 +76,14 @@ public required string Title
     /// </remarks>
     public required int? StoryPoints { get; init; }
 
+    /// <summary>
+    /// The priority
+    /// </summary>
+    /// <remarks>
+    /// This is retrieved from Microsoft.VSTS.Common.Priority
+    /// </remarks>
+    public required int Priority { get; init; }
+
     /// <summary>
     /// The ID of the parent work item.
     /// </summary>
@@ -230,6 +238,13 @@ public static async Task<QuestWorkItem> CreateWorkItemAsync(QuestIssueOrPullRequ
                 Value = iterationSize.QuestStoryPoint(),
             });
         }
+        patchDocument.Add(new JsonPatchDocument
+        {
+            Operation = Op.Add,
+            From = default,
+            Path = "/fields/Microsoft.VSTS.Common.Priority",
+            Value = issue.GetPriority(iterationSize)
+        });
 
         var tags = issue.WorkItemTagsForIssue(tagMap);
         if (tags.Any())
@@ -401,7 +416,9 @@ public static QuestWorkItem WorkItemFromJson(JsonElement root)
         JsonElement assignedNode = fields.Descendent("System.AssignedTo", "id");
         int? storyPoints = fields.TryGetProperty("Microsoft.VSTS.Scheduling.StoryPoints", out JsonElement storyPointNode) ?
             (int)double.Truncate(storyPointNode.GetDouble()) : null;
-        string? assignedID = (assignedNode.ValueKind is JsonValueKind.String) ?
+        int priority = fields.TryGetProperty("Microsoft.VSTS.Common.Priority", out JsonElement priorityNode) ?
+            (int)priorityNode.GetInt32() : 2;
+        string ? assignedID = (assignedNode.ValueKind is JsonValueKind.String) ?
             assignedNode.GetString() : null;
         string tagElement = fields.TryGetProperty("System.Tags", out JsonElement tagsNode) ?
             tagsNode.GetString()! : string.Empty;
@@ -418,6 +435,7 @@ public static QuestWorkItem WorkItemFromJson(JsonElement root)
             IterationPath = iterationPath,
             AssignedToId = (assignedID is not null) ? new Guid(assignedID) : null,
             StoryPoints = storyPoints,
+            Priority = priority,
             Tags = tags
         };
     }

actions/sequester/Quest2GitHub/QuestGitHubService.cs

@@ -78,10 +78,18 @@ public async Task ProcessIssues(string organization, string repository, int dura
         Console.WriteLine("-----   Finished processing issues.          --------");
         Console.WriteLine("     ----- Regenerating bearer token   ------");
         await ghClient.RegenerateBearerToken();
-        Console.WriteLine("-----   Starting processing pull requests.   --------");
-        var prQueryEnumerable = QueryIssuesOrPullRequests<QuestPullRequest>();
-        await ProcessItems(prQueryEnumerable);
-        Console.WriteLine("-----   Finished processing pull requests.   --------");
+        try
+        {
+            Console.WriteLine("-----   Starting processing pull requests.   --------");
+            var prQueryEnumerable = QueryIssuesOrPullRequests<QuestPullRequest>();
+            await ProcessItems(prQueryEnumerable);
+            Console.WriteLine("-----   Finished processing pull requests.   --------");
+        } catch (InvalidOperationException e)
+        {
+            Console.WriteLine("Warning: GitHub query for Pull Requests failed.");
+            Console.WriteLine(e);
+        }
+        Console.WriteLine($"Imported {totalImport} issues. Skipped {totalSkipped}");
 
         async Task ProcessItems(IAsyncEnumerable<QuestIssueOrPullRequest> items)
         {
@@ -112,7 +120,6 @@ async Task ProcessItems(IAsyncEnumerable<QuestIssueOrPullRequest> items)
                 }
             }
         }
-        Console.WriteLine($"Imported {totalImport} issues. Skipped {totalSkipped}");
 
         async IAsyncEnumerable<QuestIssueOrPullRequest> QueryIssuesOrPullRequests<T>() where T : QuestIssueOrPullRequest, IGitHubQueryResult<T, QuestIssueOrPullRequestVariables>
         {
@@ -431,6 +438,16 @@ private async Task RetrieveLabelIdsAsync(string org, string repo)
                 Value = iterationSize.QuestStoryPoint(),
             });
         }
+        int? priority = ghIssue.GetPriority(iterationSize);
+        if (priority.HasValue && priority != questItem.Priority)
+        {
+            patchDocument.Add(new JsonPatchDocument
+            {
+                Operation = Op.Add,
+                Path = "/fields/Microsoft.VSTS.Common.Priority",
+                Value = priority.Value
+            });
+        }
         var tags = from t in ghIssue.WorkItemTagsForIssue(tagMap)
                    where !questItem.Tags.Contains(t)
                    select t;