Merge pull request #43154 from dotnet/main

Merge main into live

Author: dotnet-policy-service[bot]

.github/policies/request-review.yml

@@ -0,0 +1,42 @@
+id:
+name: GitOps.PullRequestIssueManagement
+description: GitOps.PullRequestIssueManagement primitive
+owner:
+resource: repository
+disabled: false
+where:
+configuration:
+  resourceManagementConfiguration:
+    eventResponderTasks:
+      - description: Request review from diberry (non-write perms) for code analysis files.
+        if:
+          - payloadType: Pull_Request
+          - isAction:
+              action: Opened
+          - filesMatchPattern:
+              pattern: docs/fundamentals/code-analysis/*
+              matchAny: true
+        then:
+          - requestReview:
+              reviewer: diberry
+          - mentionUsers:
+              mentionees:
+                - diberry
+              replyTemplate: "Mentioning as a test: ${mentionees}"
+              
+      - description: Request review from gewarren and dotnet/docs for ML files.
+        if:
+          - payloadType: Pull_Request
+          - isAction:
+              action: Opened
+          - filesMatchPattern:
+              pattern: docs/machine-learning/*
+              matchAny: true
+        then:
+          - requestReview:
+              reviewer: gewarren
+              teamReviewer: dotnet/docs
+          - mentionUsers:
+              mentionees:
+                - gewarren
+              replyTemplate: "Mentioning as a test: ${mentionees}"

docs/core/whats-new/dotnet-9/runtime.md

@@ -175,7 +175,7 @@ In .NET 9, the JIT compiler *automatically* transforms the first indexing patter
 
 #### Loop counter variable direction
 
-The 64-bit compiler now recognizes when the direction of a loop's counter variable can be flipped without affecting the program's behavior, and then performs the transformation.
+The 64-bit compiler now recognizes when a loop's counter variable is used only to control the number of iterations, and transforms the loop to count down instead of up.
 
 In the idiomatic `for (int i = ...)` pattern, the counter variable typically increases. Consider the following example:
 

docs/csharp/language-reference/attributes/general.md

@@ -83,7 +83,7 @@ The `AttributeUsage` attribute determines how a custom attribute class can be us
   - Field
   - Event
   - Method
-  - Param
+  - Parameter
   - Property
   - Return
   - Type

docs/csharp/language-reference/compiler-options/advanced.md

@@ -86,7 +86,8 @@ When you specify [**DebugType**](code-generation.md#debugtype), the compiler cre
 ## PathMap
 
 > [!NOTE]
-Specifying **PathMap** will prevent breakpoints from working in local debug builds. Only set **PathMap** for production or [continuous integration builds](../../../core/project-sdk/msbuild-props.md#continuousintegrationbuild).
+>
+> Specifying **PathMap** prevents breakpoints from working in local debug builds. Only set **PathMap** for production or [continuous integration builds](../../../core/project-sdk/msbuild-props.md#continuousintegrationbuild).
 
 The **PathMap** compiler option specifies how to map physical paths to source path names output by the compiler. This option maps each physical path on the machine where the compiler runs to a corresponding path that should be written in the output files. In the following example, `path1` is the full path to the source files in the current environment, and `sourcePath1` is the source path substituted for `path1` in any output files. To specify multiple mapped source paths, separate each with a comma.
 

docs/csharp/language-reference/keywords/access-modifiers.md

@@ -27,7 +27,7 @@ Access modifiers are keywords used to specify the declared accessibility of a me
 
  This section also introduces the following concepts:
 
-- [Accessibility Levels](./accessibility-levels.md): Using the four access modifiers to declare six levels of accessibility.
+- [Accessibility Levels](./accessibility-levels.md): Using the access modifiers to declare levels of accessibility.
 - [Accessibility Domain](./accessibility-domain.md): Specifies where, in the program sections, a member can be referenced.
 - [Restrictions on Using Accessibility Levels](./restrictions-on-using-accessibility-levels.md): A summary of the restrictions on using declared accessibility levels.
 

docs/framework/wcf/diagnostics/tracing/propagation.md

@@ -49,7 +49,7 @@ This topic describes activity propagation in the Windows Communication Foundatio
       </a:Action>  
       <a:MessageID>urn:uuid:f0091eae-d339-4c7e-9408-ece34602f1ce  
       </a:MessageID>  
-      <ActivityId CorrelationId="f94c6af1-7d5d-4295-b693-4670a8a0ce34"
+      <ActivityId CorrelationId="aaaa0000-bb11-2222-33cc-444444dddddd"
                xmlns="http://schemas.microsoft.com/2004/09/ServiceModel/Diagnostics">  
         17f59a29-b435-4a15-bf7b-642ffc40eac8  
       </ActivityId>  

docs/framework/wcf/diagnostics/tracing/using-service-trace-viewer-for-viewing-correlated-traces-and-troubleshooting.md

@@ -66,7 +66,7 @@ If you examine the "Sent a message over a channel" trace, you may see the follow
       <Level>8</Level>
       <TimeCreated SystemTime="2006-08-04T18:45:30.8491051Z" />
       <Source Name="System.ServiceModel" />
-       <Correlation ActivityID="{27c6331d-8998-43aa-a382-03239013a6bd}"/>
+       <Correlation ActivityID="{bbbb1111-cc22-3333-44dd-555555eeeeee}"/>
        <Execution ProcessName="client" ProcessID="1808" ThreadID="1" />
        <Channel />
        <Computer>TEST1</Computer>
@@ -87,7 +87,7 @@ If you examine the "Sent a message over a channel" trace, you may see the follow
                   <MessageHeaders>
                      <Action d4p1:mustUnderstand="1" xmlns:d4p1="http://www.w3.org/2003/05/soap-envelope" xmlns="http://www.w3.org/2005/08/addressing">http://Microsoft.ServiceModel.Samples/ICalculator/Multiply</Action>
                      <MessageID xmlns="http://www.w3.org/2005/08/addressing">urn:uuid:7c6670d8-4c9c-496e-b6a0-2ceb6db35338</MessageID>
-                     <ActivityId CorrelationId="b02e2189-0816-4387-980c-dd8e306440f5" xmlns="http://schemas.microsoft.com/2004/09/ServiceModel/Diagnostics">27c6331d-8998-43aa-a382-03239013a6bd</ActivityId>
+                     <ActivityId CorrelationId="aaaa0000-bb11-2222-33cc-444444dddddd" xmlns="http://schemas.microsoft.com/2004/09/ServiceModel/Diagnostics">bbbb1111-cc22-3333-44dd-555555eeeeee</ActivityId>
                      <ReplyTo xmlns="http://www.w3.org/2005/08/addressing">
                         <Address>http://www.w3.org/2005/08/addressing/anonymous</Address>
                     </ReplyTo>

docs/framework/wcf/feature-details/how-to-configure-a-port-with-an-ssl-certificate.md

@@ -63,7 +63,7 @@ When creating a self-hosted Windows Communication Foundation (WCF) service with
 2. In Windows Vista, use the Netsh.exe tool, as shown in the following example.  
   
     ```console  
-    netsh http add sslcert ipport=0.0.0.0:8000 certhash=0000000000003ed9cd0c315bbb6dc1c08da5e6 appid={00112233-4455-6677-8899-AABBCCDDEEFF}
+    netsh http add sslcert ipport=0.0.0.0:8000 certhash=0000000000003ed9cd0c315bbb6dc1c08da5e6 appid={00001111-aaaa-2222-bbbb-3333cccc4444}
     ```  
   
     - The **certhash** parameter specifies the thumbprint of the certificate.  
@@ -85,7 +85,7 @@ When creating a self-hosted Windows Communication Foundation (WCF) service with
 2. In Windows Vista, to support clients that authenticate with X.509 certificates at the transport layer, follow the preceding procedure, but with an additional parameter, as shown in the following example.  
   
     ```console  
-    netsh http add sslcert ipport=0.0.0.0:8000 certhash=0000000000003ed9cd0c315bbb6dc1c08da5e6 appid={00112233-4455-6677-8899-AABBCCDDEEFF} clientcertnegotiation=enable  
+    netsh http add sslcert ipport=0.0.0.0:8000 certhash=0000000000003ed9cd0c315bbb6dc1c08da5e6 appid={00001111-aaaa-2222-bbbb-3333cccc4444} clientcertnegotiation=enable  
     ```  
   
 ## Delete an SSL certificate from a port number  

docs/fundamentals/code-analysis/quality-rules/ca5374.md

@@ -30,7 +30,7 @@ Instantiating an <xref:System.Xml.Xsl.XslTransform?displayProperty=nameWithType>
 
 ## How to fix violations
 
-Replace <xref:System.Xml.Xsl.XslTransform> with <xref:System.Xml.Xsl.XslCompiledTransform?displayProperty=nameWithType>. For more guidance, see [/dotnet/standard/data/xml/migrating-from-the-xsltransform-class].
+Replace <xref:System.Xml.Xsl.XslTransform> with <xref:System.Xml.Xsl.XslCompiledTransform?displayProperty=nameWithType>. For more guidance, see [Migrating from the XslTransform class](../../../standard/data/xml/migrating-from-the-xsltransform-class.md).
 
 ## When to suppress warnings
 

docs/fundamentals/syslib-diagnostics/syslib0014.md

@@ -14,13 +14,19 @@ The following APIs are marked as obsolete, starting in .NET 6. Using them in cod
 - <xref:System.Net.WebRequest.CreateHttp%2A?displayProperty=fullName>
 - <xref:System.Net.WebRequest.CreateDefault(System.Uri)?displayProperty=fullName>
 - <xref:System.Net.HttpWebRequest.%23ctor(System.Runtime.Serialization.SerializationInfo,System.Runtime.Serialization.StreamingContext)>
-- <xref:System.Net.ServicePointManager.FindServicePoint%2A?displayProperty=fullName>
+- <xref:System.Net.ServicePointManager>
 - <xref:System.Net.WebClient.%23ctor>
 
+To reduce the number of analyzer warnings, the <xref:System.Net.ServicePoint> class is not marked as obsolete, but all ways of obtaining its instances are.
+
+Settings on <xref:System.Net.ServicePointManager> and <xref:System.Net.ServicePoint> no longer affect <xref:System.Net.Security.SslStream> or <xref:System.Net.Http.HttpClient>.
+
 ## Workarounds
 
 Use <xref:System.Net.Http.HttpClient> instead.
 
+See the [HttpWebRequest to HttpClient migration guide](https://learn.microsoft.com/dotnet/fundamentals/networking/http/httpclient-migrate-from-httpwebrequest) for more info.
+
 ## Suppress a warning
 
 If you must use the obsolete APIs, you can suppress the warning in code or in your project file.