Skip to content

Fix System.Text.Json converter documentation: Converters is a readonly property #43179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Fix System.Text.Json converter documentation: Converters is a readonly property #43179

wants to merge 0 commits into from

Conversation

@SeppPenner
Copy link
Contributor

@SeppPenner SeppPenner commented Oct 23, 2024

Summary

Changed the code samples with System.Text.Json Converters (Now readonly property).

Fixes #43178.

--> No idea why the renaming of the localizer is in there (Is already merged)...

@SeppPenner SeppPenner requested review from a team, IEvangelist and gewarren as code owners October 23, 2024 13:38
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Oct 23, 2024
@gewarren
Copy link
Contributor

gewarren commented Oct 23, 2024 •
edited
Loading

--> No idea why the renaming of the localizer is in there (Is already merged)...

@SeppPenner That's because you're submitting PRs from your main branch. I'd recommend following this guidance (but replace master with main): https://gist.github.com/billbonney/76de0f1a2e79f3a8a1a5. After you reset your main branch, create a working branch off of main and cherry pick the two commits that you actually want from this PR. And then create a new PR.

@SeppPenner SeppPenner closed this Nov 5, 2024
SeppPenner added a commit to SeppPenner/docs that referenced this pull request Nov 5, 2024
@SeppPenner
## Summary
ef29b75 
Changed the code samples with System.Text.Json Converters (Now readonly property).

Fixes dotnet#43178, makes dotnet#43179 obsolete.
@SeppPenner SeppPenner mentioned this pull request Nov 5, 2024
Merged
@SeppPenner
Copy link
Contributor Author

SeppPenner commented Nov 5, 2024

Superseeded by #43349.

gewarren pushed a commit that referenced this pull request Nov 15, 2024
@SeppPenner
## Summary (#43349)
4e51802 
Changed the code samples with System.Text.Json Converters (Now readonly property).

Fixes #43178, makes #43179 obsolete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarren gewarren Awaiting requested review from gewarren

@IEvangelist IEvangelist Awaiting requested review from IEvangelist

Assignees

No one assigned

Labels

community-contribution Indicates PR is created by someone from the .NET community.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

System.Text.Json converter documentation: Converters is a readonly property

2 participants

@SeppPenner @gewarren