Update the Tip section in CA2208 page #44490
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
dotnet-fundamentals/svc
community-contribution
Contributor
|
Please see comments I put in the issue and let me know your thoughts. |
Contributor
|
Closing per #44030 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #44030
It updates the tip in the CA2208 page by:
It was already outdated and was showing an incorrect order of parameters as a potential fix of the rule
The second part was showing the tooltip that was for the single argument being the type name. This is outdated, as there is already the possibility to pass a single argument to one of
ArgumentNullExceptionoverloads.Please see the issue comments for more details.
Internal previews