Skip to content

Conversation

@scottaddie
Copy link
Member

@scottaddie scottaddie commented Nov 15, 2024

Update the proxy doc to be less hand wavy, using both https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/samples/Configuration.md#configuring-a-proxy and https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/src/Pipeline/Internal/HttpEnvironmentProxy.cs as resources.

Summary of changes

  • Document proxy configuration via code.
  • Document the ALL_PROXY, NO_PROXY, and GATEWAY_INTERFACE env vars.
  • Simplify the URL and add a redirect. The "azure-sdk-" prefix on the file name provided no value.
  • Update ToC entry text, along with the doc title and description metadata.

Internal previews

📄 File 🔗 Preview link
docs/azure/sdk/configure-proxy.md docs/azure/sdk/configure-proxy
docs/azure/TOC.yml docs/azure/TOC

@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 15, 2024
@scottaddie scottaddie changed the title Explain how to configure a proxy server via code Update Azure SDK proxy server configuration doc Nov 15, 2024
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks consistent to me with the docs we have in https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/samples/Configuration.md#configuring-a-proxy, and modulo the one "consider" comment I added, I think this is a good update to the MS Learn docs. Thanks, @scottaddie!

@scottaddie scottaddie closed this Nov 18, 2024
@scottaddie scottaddie reopened this Nov 18, 2024
@scottaddie scottaddie merged commit 11abe70 into main Nov 18, 2024
14 of 15 checks passed
@scottaddie scottaddie deleted the scottaddie/proxy-server branch November 18, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants