Clarify postfix notation usage for seq in F# style guide #44226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shethaadit
requested review from
a team,
BillWagner and
KathleenDollard
as code owners
dotnet-policy-service
bot
added
dotnet-fsharp/svc
community-contribution
Member
|
#44229 should fix the build issues. I'll merge once that's clean |
BillWagner
approved these changes
Jan 13, 2025
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Thanks @shethaadit
I'll merge this shortly.
Member
|
closing and reopening for a fresh build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR Description
The current F# style guide lacks explicit mention of the
seqtype in the exceptions list for postfix notation usage. This creates ambiguity sinceseqis consistently used in postfix notation across FSharp.Core functions and theseq { }computation expression.This PR:
seqas an exception, using the postfix form (int seq).listandoption.Fixes #40681
Internal previews