-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Fix wrong order for default configuration #46538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is inaccurate. The order is correct as documented. See the source code, the order a provider is added is the order: |
|
@IEvangelist hmm... I still think my suggested change is accurate. Let me please explain why. The documentation states the following right above the list. So based on the current version of the docs, appsettings.json would take precedence over appsettings. Furthermore, in the docs there is the following example right after the list which would match the suggested change as well as the expected behavior. |
|
@IEvangelist I completely agree with @rufer7. According to the source code you shared, appsettings.json is added BEFORE appsettings. |
|
@IEvangelist can you please revisit this PR? |
|
ping @IEvangelist |
Pull request was closed
Summary
This pull request includes a minor reordering of the configuration providers list in the
docs/core/extensions/configuration.mdfile. The change ensures that theappsettings.jsonconfiguration provider is listed after theappsettings.*Environment*.jsonprovider for better clarity and alignment with the intended configuration precedence.Key change:
docs/core/extensions/configuration.md: Reordered theappsettings.jsonentry to follow theappsettings.*Environment*.jsonentry in the list of configuration providers. This change ensures the order reflects the configuration precedence more accurately.Internal previews