-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Fix incorrect .NET version numbers in built-in-metrics-diagnostics.md #47584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: gewarren <[email protected]>
gewarren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @evgenyfedorov2 can you confirm that these were the versions you intended?
Hmm, actually, .NET Extensions is released monthly and the version numbers in documentation reflect the versions numbers when the code was released with .NET Extensions. I don't know what the policy is, though? If a metric was released with .NET Extensions 9.8.0, can we say it is available with .NET 9.0? |
Yes, I think so, if these metrics are released as part of the servicing releases. Perhaps we can say |
Yes, they are part of the https://www.nuget.org/packages/Microsoft.Extensions.Diagnostics.ResourceMonitoring Nuget package. So instead of |
PoliCheck Scan ReportThe following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
The documentation contained incorrect .NET version numbers that didn't follow the standard versioning format used throughout the docs. Several metrics were incorrectly labeled with versions like ".NET 8.8.0" and ".NET 9.8.0" instead of the proper ".NET 8.0" and ".NET 9.0" format.
This PR fixes 5 instances of incorrect version numbers:
The affected metrics were:
container.cpu.limit.utilizationcontainer.cpu.request.utilizationcontainer.cpu.timecontainer.memory.limit.utilizationcontainer.memory.usageThe corrected versions now align with the standard .NET version format used consistently throughout the documentation (e.g., ".NET 8.0", ".NET 9.0").
Fixes #45089.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
Internal previews