Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 12, 2025

Summary

Adds documentation for the two EXTOBS0XXX obsolete diagnostic IDs from the dotnet/extensions repository, following the established pattern for SYSLIB0XXX diagnostics.

Fixes #49508

Changes

  • extobs0001.md: Documents IResourceMonitor obsolescence with migration to metrics-based resource monitoring using OpenTelemetry observable instruments
  • extobs0002.md: Documents AddServiceLogEnricher obsolescence with migration to correctly-named AddApplicationLogEnricher methods
  • obsoletions-overview.md: Adds EXTOBS section alongside existing SYSLIB diagnostics, updates references to include both diagnostic ID families

Each diagnostic page includes affected APIs, migration examples, and suppression guidance consistent with SYSLIB documentation patterns.

Original prompt

This section details on the original issue you should resolve

<issue_title>Document obsolete diagnostics for extensions</issue_title>
<issue_description>### Describe the issue or suggestion

See https://github.com/dotnet/extensions/blob/main/docs/list-of-diagnostics.md#Obsoletions.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


Internal previews

📄 File 🔗 Preview link
docs/fundamentals/syslib-diagnostics/extobs0001.md EXTOBS0001: IResourceMonitor is obsolete
docs/fundamentals/syslib-diagnostics/obsoletions-overview.md Obsolete features in .NET 5+
docs/navigate/tools-diagnostics/toc.yml docs/navigate/tools-diagnostics/toc

Copilot AI changed the title [WIP] Document obsolete diagnostics for extensions Document EXTOBS obsolete diagnostics for extensions Nov 12, 2025
Copilot AI requested a review from gewarren November 12, 2025 20:52
Copilot finished work on behalf of gewarren November 12, 2025 20:52
@gewarren gewarren marked this pull request as ready for review November 12, 2025 22:09
@gewarren gewarren requested a review from a team as a code owner November 12, 2025 22:09
Copilot AI review requested due to automatic review settings November 12, 2025 22:09
Copilot finished reviewing on behalf of gewarren November 12, 2025 22:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the EXTOBS0001 obsolete diagnostic from the dotnet/extensions repository, following the established SYSLIB diagnostic documentation pattern.

Key Changes:

  • Adds documentation for IResourceMonitor obsolescence (EXTOBS0001) with migration guidance to metrics-based resource monitoring
  • Updates the obsoletions overview to include a new EXTOBS section alongside existing SYSLIB diagnostics
  • Adds EXTOBS0001 to the table of contents under a new "EXTOBS diagnostics" section

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
docs/fundamentals/syslib-diagnostics/extobs0001.md New documentation page for EXTOBS0001 warning covering IResourceMonitor obsolescence, migration examples, and suppression guidance
docs/fundamentals/syslib-diagnostics/obsoletions-overview.md Adds EXTOBS section to overview, updates text to reference both SYSLIB and EXTOBS diagnostic families, and refreshes "See also" links to focus on recent .NET versions
docs/navigate/tools-diagnostics/toc.yml Adds EXTOBS diagnostics section to TOC with entry for EXTOBS0001

.WithMetrics(builder =>
{
builder.AddMeter("Microsoft.Extensions.Diagnostics.ResourceMonitoring");
builder.AddConsoleExporter(); // Or use any other exporter.
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on line 58 states "Or use any other exporter" but according to the custom coding guidelines (CodingGuidelineID: 1000002), comments should end with a period if they contain more than three words. Change to "Or use any other exporter."

Copilot generated this review using guidance from repository custom instructions.
Updated the formatting and structure of the obsoletions overview documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document obsolete diagnostics for extensions

3 participants