-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Document EXTOBS obsolete diagnostics for extensions #49870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: gewarren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for the EXTOBS0001 obsolete diagnostic from the dotnet/extensions repository, following the established SYSLIB diagnostic documentation pattern.
Key Changes:
- Adds documentation for
IResourceMonitorobsolescence (EXTOBS0001) with migration guidance to metrics-based resource monitoring - Updates the obsoletions overview to include a new EXTOBS section alongside existing SYSLIB diagnostics
- Adds EXTOBS0001 to the table of contents under a new "EXTOBS diagnostics" section
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| docs/fundamentals/syslib-diagnostics/extobs0001.md | New documentation page for EXTOBS0001 warning covering IResourceMonitor obsolescence, migration examples, and suppression guidance |
| docs/fundamentals/syslib-diagnostics/obsoletions-overview.md | Adds EXTOBS section to overview, updates text to reference both SYSLIB and EXTOBS diagnostic families, and refreshes "See also" links to focus on recent .NET versions |
| docs/navigate/tools-diagnostics/toc.yml | Adds EXTOBS diagnostics section to TOC with entry for EXTOBS0001 |
| .WithMetrics(builder => | ||
| { | ||
| builder.AddMeter("Microsoft.Extensions.Diagnostics.ResourceMonitoring"); | ||
| builder.AddConsoleExporter(); // Or use any other exporter. |
Copilot
AI
Nov 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on line 58 states "Or use any other exporter" but according to the custom coding guidelines (CodingGuidelineID: 1000002), comments should end with a period if they contain more than three words. Change to "Or use any other exporter."
Updated the formatting and structure of the obsoletions overview documentation.
Summary
Adds documentation for the two
EXTOBS0XXXobsolete diagnostic IDs from the dotnet/extensions repository, following the established pattern forSYSLIB0XXXdiagnostics.Fixes #49508
Changes
IResourceMonitorobsolescence with migration to metrics-based resource monitoring using OpenTelemetry observable instrumentsAddServiceLogEnricherobsolescence with migration to correctly-namedAddApplicationLogEnrichermethodsEach diagnostic page includes affected APIs, migration examples, and suppression guidance consistent with SYSLIB documentation patterns.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Internal previews