-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add final error codes added in C# 14 #49884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Consolidate all related errors for type arguments and type parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates C# compiler errors and warnings related to generic type parameters and type arguments into a single comprehensive document. It removes individual error pages for 20 error codes, creates a new consolidated guide, and adds the final C# 14 error codes to the documentation.
Key changes:
- Creates
generic-type-parameters-errors.mdconsolidating 20 error codes (CS0080, CS0081, CS0224, CS0304-CS0315, CS0403, CS0412-CS0413, CS0417, CS0694-CS0695, CS0698, CS9338) into thematic sections. - Removes 20 individual error code files from
misc/andcompiler-messages/directories. - Updates TOC to replace individual entries with the new consolidated document entry.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 47 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md | New consolidated document organizing generic type parameter and type argument errors into thematic sections with resolution guidance. |
| docs/csharp/language-reference/toc.yml | Adds entry for the new consolidated document and removes entries for individual error files being consolidated. |
| .openpublishing.redirection.csharp.json | Adds 20 redirect entries for deleted error code files to point to the new consolidated document. |
| docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md | Removes CS0224 from f1_keywords section at the top, adds large block of error codes to helpviewer_keywords for C# 14. |
| .github/prompts/error-consolidation.md | Updates prompt template references from explicit-interface-errors to generic-type-parameters-errors for next consolidation tasks. |
| docs/csharp/misc/*.md (14 files) | Deletes individual error documentation files for CS0080, CS0081, CS0305-CS0308, CS0312-CS0315, CS0403, CS0412, CS0694-CS0695, CS0698. |
| docs/csharp/language-reference/compiler-messages/*.md (6 files) | Deletes individual error documentation files for CS0304, CS0310-CS0311, CS0413, CS0417. |
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md
Show resolved
Hide resolved
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
|
I've addressed all the Copilot feedback. (Much of it was inaccurate) |
|
And, this is the last PR like this for a while. That's all the C# 14 diagnostics |
Fixes #49292
The final error code is a better diagnostic for generic type argument visibility. Consolidate any remaining errors and warnings related to type arguments and type parameters.
Internal previews