Skip to content

Conversation

@BillWagner
Copy link
Member

@BillWagner BillWagner commented Nov 13, 2025

@BillWagner BillWagner marked this pull request as ready for review November 13, 2025 19:59
@BillWagner BillWagner requested a review from a team as a code owner November 13, 2025 19:59
Copilot AI review requested due to automatic review settings November 13, 2025 19:59
Copilot finished reviewing on behalf of BillWagner November 13, 2025 20:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates C# compiler errors and warnings related to generic type parameters and type arguments into a single comprehensive document. It removes individual error pages for 20 error codes, creates a new consolidated guide, and adds the final C# 14 error codes to the documentation.

Key changes:

  • Creates generic-type-parameters-errors.md consolidating 20 error codes (CS0080, CS0081, CS0224, CS0304-CS0315, CS0403, CS0412-CS0413, CS0417, CS0694-CS0695, CS0698, CS9338) into thematic sections.
  • Removes 20 individual error code files from misc/ and compiler-messages/ directories.
  • Updates TOC to replace individual entries with the new consolidated document entry.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 47 comments.

Show a summary per file
File Description
docs/csharp/language-reference/compiler-messages/generic-type-parameters-errors.md New consolidated document organizing generic type parameter and type argument errors into thematic sections with resolution guidance.
docs/csharp/language-reference/toc.yml Adds entry for the new consolidated document and removes entries for individual error files being consolidated.
.openpublishing.redirection.csharp.json Adds 20 redirect entries for deleted error code files to point to the new consolidated document.
docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md Removes CS0224 from f1_keywords section at the top, adds large block of error codes to helpviewer_keywords for C# 14.
.github/prompts/error-consolidation.md Updates prompt template references from explicit-interface-errors to generic-type-parameters-errors for next consolidation tasks.
docs/csharp/misc/*.md (14 files) Deletes individual error documentation files for CS0080, CS0081, CS0305-CS0308, CS0312-CS0315, CS0403, CS0412, CS0694-CS0695, CS0698.
docs/csharp/language-reference/compiler-messages/*.md (6 files) Deletes individual error documentation files for CS0304, CS0310-CS0311, CS0413, CS0417.

@BillWagner
Copy link
Member Author

I've addressed all the Copilot feedback. (Much of it was inaccurate)

@BillWagner
Copy link
Member Author

And, this is the last PR like this for a while. That's all the C# 14 diagnostics

@BillWagner BillWagner merged commit 2fc1496 into dotnet:main Nov 13, 2025
9 checks passed
@BillWagner BillWagner deleted the type-argument-errors branch November 13, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C# 14-Errors and warnings]: Final cleanup for GA

2 participants