Removed monitor-based lock

Author: sakno

src/DotNext.Tests/Threading/AsyncResetEventTests.cs

@@ -141,9 +141,9 @@ public static void AlreadySignaledEvents(IAsyncResetEvent resetEvent)
     [Fact]
     public static async Task AutoResetOnSyncWait()
     {
-        using var are = new AsyncAutoResetEvent(false);
+        using IAsyncEvent are = new AsyncAutoResetEvent(false);
         var t = Task.Factory.StartNew(() => are.Wait(DefaultTimeout), TaskCreationOptions.LongRunning);
-        True(are.Set());
+        True(are.Signal());
 
         True(await t);
         False(are.IsSet);
@@ -152,15 +152,15 @@ public static async Task AutoResetOnSyncWait()
     [Fact]
     public static async Task ResumeSuspendedCallersSequentially()
     {
-        using var are = new AsyncAutoResetEvent(false);
+        using IAsyncEvent are = new AsyncAutoResetEvent(false);
         var t1 = Task.Factory.StartNew(Wait, TaskCreationOptions.LongRunning);
         var t2 = Task.Factory.StartNew(Wait, TaskCreationOptions.LongRunning);
 
-        True(are.Set());
+        True(are.Signal());
 
         True(await Task.WhenAny(t1, t2).Unwrap());
 
-        True(are.Set());
+        True(are.Signal());
         Equal(new[] { true, true }, await Task.WhenAll(t1, t2));
 
         bool Wait() => are.Wait(DefaultTimeout);

src/DotNext.Threading/Threading/AsyncAutoResetEvent.cs

@@ -1,6 +1,5 @@
 using System.Diagnostics;
 using System.Runtime.InteropServices;
-using System.Runtime.Versioning;
 
 namespace DotNext.Threading;
 
@@ -118,8 +117,6 @@ public bool Set()
                         break;
                     }
                 }
-                
-                Monitor.Pulse(SyncRoot);
             }
         }
 
@@ -154,48 +151,4 @@ public ValueTask<bool> WaitAsync(TimeSpan timeout, CancellationToken token = def
     /// <exception cref="OperationCanceledException">The operation has been canceled.</exception>
     public ValueTask WaitAsync(CancellationToken token = default)
         => AcquireAsync(ref pool, ref manager, new CancellationTokenOnly(token));
-
-    /// <summary>
-    /// Blocks the current thread until this event is set.
-    /// </summary>
-    /// <param name="timeout">The time to wait for the event.</param>
-    /// <returns><see langword="true"/>, if this event was set; otherwise, <see langword="false"/>.</returns>
-    /// <exception cref="ObjectDisposedException">The current instance has already been disposed.</exception>
-    /// <exception cref="ArgumentOutOfRangeException"><paramref name="timeout"/> is negative.</exception>
-    [UnsupportedOSPlatform("browser")]
-    public bool Wait(TimeSpan timeout)
-    {
-        ObjectDisposedException.ThrowIf(IsDisposingOrDisposed, this);
-        return Wait(new Timeout(timeout));
-    }
-
-    [UnsupportedOSPlatform("browser")]
-    private bool Wait(Timeout timeout)
-    {
-        bool result;
-        if (result = timeout.TryGetRemainingTime(out var remainingTime) && Monitor.TryEnter(SyncRoot, remainingTime))
-        {
-            try
-            {
-                if (TryAcquire(ref manager, synchronously: true))
-                {
-                    // nothing to do
-                }
-                else if (timeout.TryGetRemainingTime(out remainingTime) && Monitor.Wait(SyncRoot, remainingTime))
-                {
-                    manager.Value = false;
-                }
-                else
-                {
-                    result = false;
-                }
-            }
-            finally
-            {
-                Monitor.Exit(SyncRoot);
-            }
-        }
-
-        return result;
-    }
 }

src/DotNext.Threading/Threading/AsyncManualResetEvent.cs

@@ -1,5 +1,4 @@
 using System.Diagnostics;
-using System.Runtime.Versioning;
 
 namespace DotNext.Threading;
 
@@ -108,7 +107,6 @@ public bool Set(bool autoReset)
             result = !manager.Value;
             manager.Value = !autoReset;
             suspendedCallers = DetachWaitQueue()?.SetResult(true, out _);
-            Monitor.PulseAll(SyncRoot);
         }
 
         suspendedCallers?.Unwind();
@@ -155,43 +153,4 @@ public ValueTask<bool> WaitAsync(TimeSpan timeout, CancellationToken token = def
     /// <exception cref="OperationCanceledException">The operation has been canceled.</exception>
     public ValueTask WaitAsync(CancellationToken token = default)
         => AcquireAsync(ref pool, ref manager, new CancellationTokenOnly(token));
-
-    /// <summary>
-    /// Blocks the current thread until this event is set.
-    /// </summary>
-    /// <param name="timeout">The time to wait for the event.</param>
-    /// <returns><see langword="true"/>, if this event was set; otherwise, <see langword="false"/>.</returns>
-    /// <exception cref="ObjectDisposedException">The current instance has already been disposed.</exception>
-    /// <exception cref="ArgumentOutOfRangeException"><paramref name="timeout"/> is negative.</exception>
-    [UnsupportedOSPlatform("browser")]
-    public bool Wait(TimeSpan timeout)
-    {
-        ObjectDisposedException.ThrowIf(IsDisposingOrDisposed, this);
-        return Wait(new Timeout(timeout));
-    }
-
-    [UnsupportedOSPlatform("browser")]
-    private bool Wait(Timeout timeout)
-    {
-        bool result;
-        if (timeout.TryGetRemainingTime(out var remainingTime) && Monitor.TryEnter(SyncRoot, remainingTime))
-        {
-            try
-            {
-                result = TryAcquire(ref manager, synchronously: true) ||
-                         timeout.TryGetRemainingTime(out remainingTime)
-                         && Monitor.Wait(SyncRoot, remainingTime);
-            }
-            finally
-            {
-                Monitor.Exit(SyncRoot);
-            }
-        }
-        else
-        {
-            result = false;
-        }
-
-        return result;
-    }
 }