Reuse the exception message

Author: sakno

src/cluster/DotNext.AspNetCore.Cluster/ExceptionMessages.cs

@@ -16,10 +16,6 @@ internal static string MissingHeader(string headerName)
 
     internal static string IncorrectResponse => (string)Resources.Get();
 
-    internal static string UnavailableMember => (string)Resources.Get();
-
-    internal static string LeaderIsUnavailable => (string)Resources.Get();
-
     internal static string InvalidRpcTimeout => (string)Resources.Get();
 
     internal static string UnsupportedRedirection => (string)Resources.Get();

src/cluster/DotNext.AspNetCore.Cluster/ExceptionMessages.restext

@@ -1,7 +1,5 @@
 MissingHeader=Raft protocol header {0} is missing
 IncorrectResponse=Incorrect response according to Raft protocol
-UnavailableMember=Member is not reachable through the network
-LeaderIsUnavailable=Leader node is not yet elected
 InvalidRpcTimeout=Raft RPC timeout cannot be larger than HTTP request timeout
 UnsupportedRedirection=Redirection is not supported because the underlying network transport for Raft cannot provide correct resolution of the leader address compatible with HTTP protocol
 ReadLogEntryTwice=Attempt to read the log entry twice while it's not reusable

src/cluster/DotNext.AspNetCore.Cluster/Net/Cluster/Consensus/Raft/Http/RaftClusterMember.cs

@@ -137,7 +137,7 @@ MemberUnavailableException MemberUnavailable(Exception e)
         {
             context.Logger.MemberUnavailable(EndPoint, e);
             Status = ClusterMemberStatus.Unavailable;
-            return new MemberUnavailableException(this, ExceptionMessages.UnavailableMember, e);
+            return new MemberUnavailableException(this, innerException: e);
         }
     }
 

src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/LeaderState.Replication.cs

@@ -231,7 +231,7 @@ internal ValueTask ForceReplicationAsync(CancellationToken token)
         }
         catch (ObjectDisposedException e)
         {
-            replicationTask = ValueTask.FromException(new InvalidOperationException(ExceptionMessages.LocalNodeNotLeader, e));
+            replicationTask = ValueTask.FromException(new NotLeaderException(e));
         }
 
         return replicationTask;
@@ -246,7 +246,7 @@ internal void ForceReplication()
         }
         catch (ObjectDisposedException e)
         {
-            throw new InvalidOperationException(ExceptionMessages.LocalNodeNotLeader, e);
+            throw new NotLeaderException(e);
         }
     }
 

src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/LeaderState.cs

@@ -1,6 +1,7 @@
 using System.Diagnostics;
 using System.Diagnostics.Metrics;
 using System.Runtime.CompilerServices;
+using DotNext.Net.Cluster.Replication;
 using Microsoft.Extensions.Logging;
 
 namespace DotNext.Net.Cluster.Consensus.Raft;
@@ -282,7 +283,7 @@ protected override void Dispose(bool disposing)
             DestroyLease();
 
             // cancel replication queue
-            replicationQueue.Dispose(new InvalidOperationException(ExceptionMessages.LocalNodeNotLeader));
+            replicationQueue.Dispose(new NotLeaderException());
             replicationEvent.Dispose();
 
             context.Dispose();

src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/TransportServices/ConnectionOriented/Client.cs

@@ -105,7 +105,7 @@ private async Task<TResponse> RequestAsync<TResponse, TExchange>(TExchange excha
 
             // detect broken socket
             ClearContext();
-            throw new MemberUnavailableException(this, ExceptionMessages.UnavailableMember, e);
+            throw new MemberUnavailableException(this, innerException: e);
         }
         finally
         {

src/cluster/DotNext.Net.Cluster/Net/Cluster/MemberUnavailableException.cs

@@ -6,7 +6,8 @@
 /// <param name="member">The unavailable member.</param>
 /// <param name="message">Human-readable text describing the issue.</param>
 /// <param name="innerException">The underlying network-related exception.</param>
-public class MemberUnavailableException(IClusterMember member, string message, Exception? innerException = null) : IOException(message, innerException)
+public class MemberUnavailableException(IClusterMember member, string? message = null, Exception? innerException = null)
+    : IOException(message ?? ExceptionMessages.UnavailableMember, innerException)
 {
     /// <summary>
     /// Gets unavailable member.