Rename the method for public use

Author: sakno

src/DotNext.Tests/Threading/Tasks/ValueTaskCompletionSourceTests.cs

@@ -167,4 +167,29 @@ public static async Task CanceledToken()
         var task = source.CreateTask(InfiniteTimeSpan, new(true)).AsTask();
         await ThrowsAsync<OperationCanceledException>(Func.Constant(task));
     }
+
+    [Fact]
+    public static async Task LazyCompletion()
+    {
+        var source = new TestCompletionSource();
+        var task = source.CreateTask(InfiniteTimeSpan, CancellationToken.None).AsTask();
+        
+        True(source.TrySetResult(string.Empty, completionToken: null, e: null, out var resumable));
+        True(resumable);
+        Same(string.Empty, source.CompletionData);
+        False(task.IsCompleted);
+        
+        source.NotifyConsumer();
+        await task;
+    }
+    
+    private sealed class TestCompletionSource : ValueTaskCompletionSource
+    {
+        public new bool TrySetResult(object completionData, short? completionToken, Exception e, out bool resumable)
+            => base.TrySetResult(completionData, completionToken, e, out resumable);
+
+        public new object CompletionData => base.CompletionData;
+
+        public new void NotifyConsumer() => base.NotifyConsumer();
+    }
 }

src/DotNext.Threading/Threading/AsyncAutoResetEvent.cs

@@ -93,7 +93,7 @@ public bool Set()
                 }
             }
 
-            suspendedCaller?.Resume();
+            suspendedCaller?.NotifyConsumer();
         }
 
         return result;

src/DotNext.Threading/Threading/AsyncCorrelationSource.cs

@@ -77,7 +77,7 @@ public bool Pulse(TKey eventId, in Result<TValue> value, out object? userData)
             userData = node.UserData;
             result = node.TrySetResult(Sentinel.Instance, completionToken, in value, out var resumable);
             if (resumable)
-                node.Resume();
+                node.NotifyConsumer();
         }
         else
         {

src/DotNext.Threading/Threading/AsyncExchanger.cs

@@ -172,7 +172,7 @@ public ValueTask<T> ExchangeAsync(T value, TimeSpan timeout, CancellationToken t
                 break;
 
             resume_callers:
-                suspendedCaller?.Resume();
+                suspendedCaller?.NotifyConsumer();
                 break;
 
             create_task:
@@ -236,7 +236,7 @@ public bool TryExchange(ref T value)
             }
         }
 
-        suspendedCaller?.Resume();
+        suspendedCaller?.NotifyConsumer();
         return result;
     }
 

src/DotNext.Threading/Threading/AsyncExclusiveLock.cs

@@ -226,7 +226,7 @@ public void Release()
             }
         }
 
-        suspendedCaller?.Resume();
+        suspendedCaller?.NotifyConsumer();
     }
 
     private protected sealed override bool IsReadyToDispose => manager is { Value: false } && IsEmptyQueue;

src/DotNext.Threading/Threading/Tasks/LinkedValueTaskCompletionSource.cs

@@ -45,7 +45,7 @@ internal void Unwind()
         for (LinkedValueTaskCompletionSource<T>? current = this, next; current is not null; current = next)
         {
             next = current.CleanupAndGotoNext();
-            current.Resume();
+            current.NotifyConsumer();
         }
     }
 

src/DotNext.Threading/Threading/Tasks/ManualResetCompletionSource.cs

@@ -58,7 +58,7 @@ private void CancellationRequested(object? expectedVersion, CancellationToken to
             Debug.Assert(versionAndStatus.Status is ManualResetCompletionSourceStatus.WaitForConsumption);
         }
 
-        Resume();
+        NotifyConsumer();
 
         exit:
         return;
@@ -150,7 +150,7 @@ protected object? CompletionData
     /// <summary>
     /// Invokes continuation callback and cleanup state of this source.
     /// </summary>
-    protected internal void Resume()
+    protected internal void NotifyConsumer()
     {
         state.Detach().Dispose();
 
@@ -166,8 +166,8 @@ protected internal void Resume()
     /// </summary>
     /// <param name="completionData">Custom data to be record to <see cref="CompletionData"/> property.</param>
     /// <returns>
-    /// <see langword="true"/> if the immediate caller must call <see cref="Resume"/> to execute the callback;
-    /// <see langword="false"/> to ignore invocation of <see cref="Resume"/> method because the callback
+    /// <see langword="true"/> if the immediate caller must call <see cref="NotifyConsumer"/> to execute the callback;
+    /// <see langword="false"/> to ignore invocation of <see cref="NotifyConsumer"/> method because the callback
     /// is not provided.
     /// </returns>
     private protected bool SetResult(object? completionData)

src/DotNext.Threading/Threading/Tasks/TaskCompletionPipe.Queue.cs

@@ -122,7 +122,7 @@ private void EnqueueCompletedTask(LinkedTaskNode node, uint expectedVersion)
                 : null;
         }
 
-        suspendedCaller?.Resume();
+        suspendedCaller?.NotifyConsumer();
     }
 
     private bool TryDequeueCompletedTask([NotNullWhen(true)] out T? task, out object? userData)

src/DotNext.Threading/Threading/Tasks/TaskCompletionPipe.cs

@@ -119,7 +119,7 @@ private bool TryAdd(T task, out uint currentVersion, object? userData)
         }
 
         // decouple producer thread from consumer thread
-        suspendedCaller?.Resume();
+        suspendedCaller?.NotifyConsumer();
         return result;
     }
 

src/DotNext.Threading/Threading/Tasks/ValueTaskCompletionSource.T.cs

@@ -96,7 +96,7 @@ private bool TrySetResult(object? completionData, short? completionToken, in Res
         var completed = TrySetResult(completionData, completionToken, in result, out var resumable);
         if (resumable)
         {
-            Resume();
+            NotifyConsumer();
         }
 
         return completed;
@@ -117,7 +117,7 @@ private bool SetResult(in Result<T> result, object? completionData = null)
     /// <param name="completionToken">The optional completion token.</param>
     /// <param name="result">The result to be stored as the result of <see cref="ValueTask{TResult}"/>.</param>
     /// <param name="resumable">
-    /// <see langword="true"/> if <see cref="ManualResetCompletionSource.Resume()"/> needs to be called to resume
+    /// <see langword="true"/> if <see cref="ManualResetCompletionSource.NotifyConsumer"/> needs to be called to resume
     /// the consumer of <see cref="ValueTask{TResult}"/>.
     /// </param>
     /// <returns>