Ensure memory order

sakno · sakno · commit f2a6f0ccbe18 · 2025-05-28T19:00:03.000+03:00
diff --git a/src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/StateMachine/WriteAheadLog.Applier.cs b/src/cluster/DotNext.Net.Cluster/Net/Cluster/Consensus/Raft/StateMachine/WriteAheadLog.Applier.cs
@@ -54,11 +54,12 @@ private async Task ApplyAsync(CancellationToken token)
     public long LastAppliedIndex
     {
         get => Volatile.Read(in appliedIndex);
-        [MethodImpl(MethodImplOptions.NoInlining)]
+        
         private set
         {
-            appliedIndex = value;
-            Interlocked.MemoryBarrier();
+            // Full memory barrier to ensure that the index cannot be changed later, somewhere
+            // within Signal due to inlining
+            Interlocked.Exchange(ref appliedIndex, value);
             appliedEvent.Signal(resumeAll: true);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -54,11 +54,12 @@ private async Task ApplyAsync(CancellationToken token)`
`54`	`54`	`public long LastAppliedIndex`
`55`	`55`	`{`
`56`	`56`	`get => Volatile.Read(in appliedIndex);`
`57`		`- [MethodImpl(MethodImplOptions.NoInlining)]`
	`57`	`+`
`58`	`58`	`private set`
`59`	`59`	`{`
`60`		`- appliedIndex = value;`
`61`		`- Interlocked.MemoryBarrier();`
	`60`	`+ // Full memory barrier to ensure that the index cannot be changed later, somewhere`
	`61`	`+ // within Signal due to inlining`
	`62`	`+ Interlocked.Exchange(ref appliedIndex, value);`
`62`	`63`	`appliedEvent.Signal(resumeAll: true);`
`63`	`64`	`}`
`64`	`65`	`}`