Merge pull request #10522 from dotnet/main

dotnet-policy-service[bot] · web-flow · commit 06b09055f653 · 2024-10-09T11:41:53.000Z
Merge main into live
diff --git a/.github/policies/disallow-edits.yml b/.github/policies/disallow-edits.yml
@@ -11,6 +11,8 @@ configuration:
           - isAction:
               action: Opened
           - or:
+              - filesMatchPattern:
+                  pattern: xml/NewFolder/*
               - includesModifiedFiles:
                   files:
                     - xml/Microsoft.Extensions*/*
diff --git a/.repoman.yml b/.repoman.yml
@@ -1,5 +1,5 @@
-revision: 2
-schema-version: 1
+revision: 3
+schema-version: 5
 owner-ms-alias: adegeo
 
 config:
@@ -9,6 +9,8 @@ config:
 
     ParserRegex: "^\\* (.*): (.*)$"
 
+    ContentUrlRegex:
+      - "### Page URL\n\n(.*)"
 
 issues:
 
@@ -17,7 +19,7 @@ issues:
     # Temporary label to mark issues as updated for Quest. The label is instantly removed
     - check:
         - type: query
-          value: "length(Issue.labels[?name == ':world_map: mapQUEST']) != `0`"
+          value: "length(Issue.Labels[?Name == ':world_map: mapQUEST']) != `0`"
       pass:
         - labels-remove: [":world_map: mapQUEST"]
 
diff --git a/xml/System.Data.Common/DbConnection.xml b/xml/System.Data.Common/DbConnection.xml
@@ -1954,8 +1954,8 @@ This property returns `false` by default; providers that implement <xref:System.
         <ReturnType>System.Data.ConnectionState</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>Gets a string that describes the state of the connection.</summary>
-        <value>The state of the connection. The format of the string returned depends on the specific type of connection you are using.</value>
+        <summary>Gets a value that describes the state of the connection.</summary>
+        <value>The state of the connection, for example, open or closed.</value>
         <remarks>To be added.</remarks>
         <related type="Article" href="/dotnet/framework/data/adonet/ado-net-overview">ADO.NET Overview</related>
       </Docs>
diff --git a/xml/System.Data.Common/DbConnectionStringBuilder.xml b/xml/System.Data.Common/DbConnectionStringBuilder.xml
@@ -1123,7 +1123,7 @@ builder2.EquivalentTo(builder3) = False
       <Docs>
         <param name="keyword">The key of the item to get or set.</param>
         <summary>Gets or sets the value associated with the specified key.</summary>
-        <value>The value associated with the specified key. If the specified key is not found, trying to get it returns a null reference (<see langword="Nothing" /> in Visual Basic), and trying to set it creates a new element using the specified key.
+        <value>The value associated with the specified key. If the specified key is not found, trying to get it throws an <see cref="T:System.ArgumentException" />, and trying to set it creates a new element using the specified key.
 
  Passing a null (<see langword="Nothing" /> in Visual Basic) key throws an <see cref="T:System.ArgumentNullException" />. Assigning a null value removes the key/value pair.</value>
         <remarks>
@@ -1142,6 +1142,8 @@ builder2.EquivalentTo(builder3) = False
 
  ]]></format>
         </remarks>
+        <exception cref="T:System.ArgumentException">
+          The value for <paramref name="keyword" /> has not been set in the collection.</exception>
         <exception cref="T:System.ArgumentNullException">
           <paramref name="keyword" /> is a null reference (<see langword="Nothing" /> in Visual Basic).</exception>
         <exception cref="T:System.NotSupportedException">The property is set, and the <see cref="T:System.Data.Common.DbConnectionStringBuilder" /> is read-only.
diff --git a/xml/System.Drawing.Imaging.Effects/Effect.xml b/xml/System.Drawing.Imaging.Effects/Effect.xml
@@ -65,8 +65,9 @@
         <Parameter Name="disposing" Type="System.Boolean" />
       </Parameters>
       <Docs>
-        <param name="disposing">To be added.</param>
-        <summary>To be added.</summary>
+        <param name="disposing">
+          <see langword="true" /> to release both managed and unmanaged resources; <see langword="false" /> to release only unmanaged resources.</param>
+        <summary>Releases the unmanaged resources used by the <see cref="T:System.Drawing.Imaging.Effects.Effect" /> and optionally releases the managed resources.</summary>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
diff --git a/xml/System.Drawing/SystemColors.xml b/xml/System.Drawing/SystemColors.xml
@@ -1344,9 +1344,12 @@
         <ReturnType>System.Boolean</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>To be added.</summary>
-        <value>To be added.</value>
-        <remarks>To be added.</remarks>
+        <summary>Gets or sets a value that indicates whether the alternative color set is used.</summary>
+        <value>When <see langword="true"/>, system <see cref="T:System.Drawing.KnownColor"/> values will return the alternative color set (as returned by <see cref="T:System.Drawing.SystemColors"/> statics or <see cref="M:System.Drawing.Color.FromKnownColor(System.Drawing.KnownColor)"/>). This is currently "dark mode" variants of the system colors.</value>
+        <remarks>
+          <para><see cref="T:System.Drawing.KnownColor"/> <see cref="T:System.Drawing.Color"/> values are always looked up every time you use them and do not retain any other context. As such, existing <see cref="T:System.Drawing.Color"/> values will change when this property is set.</para>
+          <para>On Windows, system <see cref="T:System.Drawing.KnownColor"/> values always return the current Windows color when the OS has a high contrast theme enabled.</para>
+        </remarks>
       </Docs>
     </Member>
     <Member MemberName="Window">
diff --git a/xml/System.Net.Security/SslClientAuthenticationOptions.xml b/xml/System.Net.Security/SslClientAuthenticationOptions.xml
@@ -193,9 +193,19 @@
         <ReturnType>System.Security.Cryptography.X509Certificates.X509ChainPolicy</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>Gets or sets an optional customized policy for remote certificate validation. If not <see langword="null" />, <see cref="P:System.Net.Security.SslClientAuthenticationOptions.CertificateRevocationCheckMode" /> and <see cref="T:System.Net.Security.SslCertificateTrust" /> are ignored.</summary>
+        <summary>Gets or sets an optional customized policy for remote certificate validation.</summary>
         <value>To be added.</value>
-        <remarks>To be added.</remarks>
+        <remarks>
+          <format type="text/markdown"><![CDATA[  
+
+## Remarks
+
+When the value of this property is not `null`:
+
+- The value of the <xref:System.Net.Security.SslClientAuthenticationOptions.CertificateRevocationCheckMode> property is ignored.
+- Any <xref:System.Net.Security.SslCertificateTrust> associated with the <xref:System.Net.Security.SslClientAuthenticationOptions.ClientCertificateContext> is ignored.
+]]></format>
+        </remarks>
       </Docs>
     </Member>
     <Member MemberName="CertificateRevocationCheckMode">
diff --git a/xml/System.Net.Security/SslServerAuthenticationOptions.xml b/xml/System.Net.Security/SslServerAuthenticationOptions.xml
@@ -189,9 +189,19 @@
         <ReturnType>System.Security.Cryptography.X509Certificates.X509ChainPolicy</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>Gets or sets an optional customized policy for remote certificate validation. If not <see langword="null" />, <see cref="P:System.Net.Security.SslServerAuthenticationOptions.CertificateRevocationCheckMode" /> and <see cref="T:System.Net.Security.SslCertificateTrust" /> are ignored.</summary>
+        <summary>Gets or sets an optional customized policy for remote certificate validation.</summary>
         <value>To be added.</value>
-        <remarks>To be added.</remarks>
+        <remarks>
+          <format type="text/markdown"><![CDATA[  
+
+## Remarks
+
+When the value of this property is not `null`:
+
+- The value of the <xref:System.Net.Security.SslServerAuthenticationOptions.CertificateRevocationCheckMode> property is ignored.
+- If an <xref:System.Net.Security.SslCertificateTrust> was provided to the value in the <xref:System.Net.Security.SslServerAuthenticationOptions.ServerCertificateContext> property, the trust list `SslCertificateTrust` will be sent in the handshake (when so configured), but the trust settings from this property aren't used when verifying any client authentication certificates.
+]]></format>
+        </remarks>
       </Docs>
     </Member>
     <Member MemberName="CertificateRevocationCheckMode">
@@ -494,4 +504,4 @@
       </Docs>
     </Member>
   </Members>
-</Type>
+</Type>
diff --git a/xml/System.Net/WebUtility.xml b/xml/System.Net/WebUtility.xml
@@ -556,6 +556,9 @@
 
  Each ' ' (space) character is converted to a `+` (plus) character.
 
+> [!NOTE]
+>  Replacing ' ' (space) with a '+' (plus) sign is expected only in query part of URI (by convention, not by standard) or in [`application/x-www-form-urlencoded`](https://url.spec.whatwg.org/#percent-encoded-bytes) HTTP content. Moreover, the above mentioned list of characters that are **not** replaced does not correspond neither to [URL specification](https://url.spec.whatwg.org) nor URI [RFC 3986](https://www.rfc-editor.org/rfc/rfc3986.html#section-3.4). Use <xref:System.Uri.EscapeDataString%2A> for RFC compliant transformation.
+
  For example, when embedded in a block of text to be transmitted in a URL, the characters `<` and `>` are encoded as `%3c` and `%3e`.
 
  The <xref:System.Net.WebUtility.UrlDecode%2A> method reverses the encoding.
@@ -636,6 +639,11 @@
 
 -   `(` and `)` (opening and closing parentheses)
 
+ Each ' ' (space) character is converted to a `+` (plus) character.
+
+> [!NOTE]
+>  Replacing ' ' (space) with a '+' (plus) sign is expected only in query part of URI (by convention, not by standard) or in [`application/x-www-form-urlencoded`](https://url.spec.whatwg.org/#percent-encoded-bytes) HTTP content. Moreover, the above mentioned list of characters that are **not** replaced does not correspond neither to [URL specification](https://url.spec.whatwg.org) nor URI [RFC 3986](https://www.rfc-editor.org/rfc/rfc3986.html#section-3.4). Use <xref:System.Uri.EscapeDataString%2A> for RFC compliant transformation.
+
  For example, when embedded in a block of text to be transmitted in a URL, the characters `<` and `>` are encoded as `%3c` and `%3e`.
 
  The <xref:System.Net.WebUtility.UrlDecodeToBytes%2A> method reverses the encoding.
diff --git a/xml/ns-System.Drawing.Imaging.Effects.xml b/xml/ns-System.Drawing.Imaging.Effects.xml
@@ -1,6 +1,6 @@
 <Namespace Name="System.Drawing.Imaging.Effects">
   <Docs>
-    <summary>To be added.</summary>
+    <summary>Provides functionality for adding effects to images.</summary>
     <remarks>To be added.</remarks>
   </Docs>
 </Namespace>
