Skip to content

Commit 11b51e8

Browse files
committed
PR Feedback
1 parent 215d1a3 commit 11b51e8

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

xml/System.Runtime.Loader/AssemblyLoadContext+ContextualReflectionScope.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
</Interface>
1919
</Interfaces>
2020
<Docs>
21-
<summary>Return type used exclusively for <see cref="M:System.Runtime.Loader.AssemblyLoadContext.EnterContextualReflection" />. Intended to be used as an <see cref="T:System.IDisposable" /> in a <see langword="using" /> block.</summary>
21+
<summary>Provides a return type used exclusively for <see cref="M:System.Runtime.Loader.AssemblyLoadContext.EnterContextualReflection" />. It is intended to be used as an <see cref="T:System.IDisposable" /> in a <see langword="using" /> block.</summary>
2222
<remarks>To be added.</remarks>
2323
</Docs>
2424
<Members>

xml/System.Runtime.Loader/AssemblyLoadContext.xml

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,8 @@ This constructor is protected. It can only be called from the <xref:System.Runti
124124
</Parameters>
125125
<Docs>
126126
<param name="isCollectible">
127-
<see langword="true" /> to enable garbage collection; otherwise, <see langword="false" />.</param>
128-
<summary>Initializes a new instance of the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> class with a value that indicates whether garbage collection is enabled. </summary>
127+
<see langword="true" /> to enable <see cref="M:System.Runtime.Loader.AssemblyLoadContext.Unload" />; otherwise, <see langword="false" />. The default value is <see langword="false" /> because there is a performance cost associated with enabling unloading.</param>
128+
<summary>Initializes a new instance of the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> class with a value that indicates whether unloading is enabled. </summary>
129129
<remarks>
130130
<format type="text/markdown"><![CDATA[
131131
@@ -153,10 +153,10 @@ This constructor is protected. It can only be called from the <xref:System.Runti
153153
<Parameter Name="isCollectible" Type="System.Boolean" Index="1" FrameworkAlternate="netcore-3.0" />
154154
</Parameters>
155155
<Docs>
156-
<param name="name">Value for <see cref="P:System.Runtime.Loader.AssemblyLoadContext.Name" /> in the new instance. Value can be <see langword="null" />.</param>
156+
<param name="name">The value for <see cref="P:System.Runtime.Loader.AssemblyLoadContext.Name" /> in the new instance. Its value can be <see langword="null" />.</param>
157157
<param name="isCollectible">
158-
<see langword="true" /> to enable garbage collection; otherwise, <see langword="false" />.</param>
159-
<summary>Initializes a new instance of the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> class with a name and a value that indicates whether garbage collection is enabled.</summary>
158+
<see langword="true" /> to enable <see cref="M:System.Runtime.Loader.AssemblyLoadContext.Unload" />; otherwise, <see langword="false" />. The default value is <see langword="false" /> because there is a performance cost associated with enabling unloading.</param>
159+
<summary>Initializes a new instance of the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> class with a name and a value that indicates whether unloading is enabled.</summary>
160160
<remarks>To be added.</remarks>
161161
</Docs>
162162
</Member>
@@ -176,8 +176,8 @@ This constructor is protected. It can only be called from the <xref:System.Runti
176176
<ReturnType>System.Collections.Generic.IEnumerable&lt;System.Runtime.Loader.AssemblyLoadContext&gt;</ReturnType>
177177
</ReturnValue>
178178
<Docs>
179-
<summary>Returns an IEnumerable for all <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> instances.</summary>
180-
<value>An IEnumerable for all <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> instances.</value>
179+
<summary>Returns an <see cref="T:System.Collections.Generic.IEnumerable`1" /> for all <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> instances.</summary>
180+
<value>An <see cref="T:System.Collections.Generic.IEnumerable`1" /> for all <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> instances.</value>
181181
<remarks>To be added.</remarks>
182182
</Docs>
183183
</Member>
@@ -197,8 +197,8 @@ This constructor is protected. It can only be called from the <xref:System.Runti
197197
<ReturnType>System.Collections.Generic.IEnumerable&lt;System.Reflection.Assembly&gt;</ReturnType>
198198
</ReturnValue>
199199
<Docs>
200-
<summary>Returns an IEnumerable for the <see cref="T:System.Reflection.Assembly" /> instances loaded in the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" />.</summary>
201-
<value>An IEnumerable for the <see cref="T:System.Reflection.Assembly" /> instances loaded in the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" />.</value>
200+
<summary>Returns an <see cref="T:System.Collections.Generic.IEnumerable`1" /> for the <see cref="T:System.Reflection.Assembly" /> instances loaded in the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" />.</summary>
201+
<value>An <see cref="T:System.Collections.Generic.IEnumerable`1" /> for the <see cref="T:System.Reflection.Assembly" /> instances loaded in the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" />.</value>
202202
<remarks>To be added.</remarks>
203203
</Docs>
204204
</Member>
@@ -218,8 +218,8 @@ This constructor is protected. It can only be called from the <xref:System.Runti
218218
<ReturnType>System.Runtime.Loader.AssemblyLoadContext</ReturnType>
219219
</ReturnValue>
220220
<Docs>
221-
<summary>The <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> set by most recent call to <see cref="M:System.Runtime.Loader.AssemblyLoadContext.EnterContextualReflection" />.</summary>
222-
<value>The <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> set by most recent call to <see cref="M:System.Runtime.Loader.AssemblyLoadContext.EnterContextualReflection" />. Value can be <see langword="null" />. The value is stored in an <see cref="T:System.Threading.AsyncLocal`1" />, so the value is unique per asynchronous context.</value>
221+
<summary>Gets the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> set by the most recent call to <see cref="M:System.Runtime.Loader.AssemblyLoadContext.EnterContextualReflection" />.</summary>
222+
<value>The <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> set by the most recent call to <see cref="M:System.Runtime.Loader.AssemblyLoadContext.EnterContextualReflection" />. This value can be <see langword="null" />. The value is stored in an <see cref="T:System.Threading.AsyncLocal`1" />, so the value is unique per asynchronous context.</value>
223223
<remarks>
224224
<format type="text/markdown"><![CDATA[
225225
@@ -276,7 +276,7 @@ For more information, see [AssemblyLoadContext.CurrentContextualReflectionContex
276276
<Parameters />
277277
<Docs>
278278
<summary>Sets <see cref="P:System.Runtime.Loader.AssemblyLoadContext.CurrentContextualReflectionContext" /> to <see langword="this" /> <see cref="T:System.Runtime.Loader.AssemblyLoadContext" />.</summary>
279-
<returns>A <see cref="T:System.Runtime.Loader.AssemblyLoadContext.ContextualReflectionScope" /> to restore the previous value of <see cref="P:System.Runtime.Loader.AssemblyLoadContext.CurrentContextualReflectionContext" />. Intended to be used as an <see cref="T:System.IDisposable" /> in a <see langword="using" /> block.</returns>
279+
<returns>An object to restore the previous value of <see cref="P:System.Runtime.Loader.AssemblyLoadContext.CurrentContextualReflectionContext" />. It is intended to be used as an <see cref="T:System.IDisposable" /> in a <see langword="using" /> block.</returns>
280280
<remarks>
281281
<format type="text/markdown"><![CDATA[
282282
@@ -306,9 +306,9 @@ For more information, see [AssemblyLoadContext.CurrentContextualReflectionContex
306306
<Parameter Name="activating" Type="System.Reflection.Assembly" Index="0" FrameworkAlternate="netcore-3.0" />
307307
</Parameters>
308308
<Docs>
309-
<param name="activating">Assembly which will be used to determine the requested <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> instance.</param>
310-
<summary>Sets <see cref="P:System.Runtime.Loader.AssemblyLoadContext.CurrentContextualReflectionContext" /> to the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> which loaded activating.</summary>
311-
<returns>A <see cref="T:System.Runtime.Loader.AssemblyLoadContext.ContextualReflectionScope" /> to restore the previous value of <see cref="P:System.Runtime.Loader.AssemblyLoadContext.CurrentContextualReflectionContext" />. Intended to be used as an <see cref="T:System.IDisposable" /> in a <see langword="using" /> block.</returns>
309+
<param name="activating">The assembly that is used to determine the requested <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> instance.</param>
310+
<summary>Sets <see cref="P:System.Runtime.Loader.AssemblyLoadContext.CurrentContextualReflectionContext" /> to the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" /> which loaded the assembly.</summary>
311+
<returns>An object to restore the previous value of <see cref="P:System.Runtime.Loader.AssemblyLoadContext.CurrentContextualReflectionContext" />. It is intended to be used as an <see cref="T:System.IDisposable" /> in a <see langword="using" /> block.</returns>
312312
<remarks>
313313
<format type="text/markdown"><![CDATA[
314314
@@ -769,8 +769,8 @@ For more information, see [How to use and debug assembly unloadability in .NET C
769769
<ReturnType>System.String</ReturnType>
770770
</ReturnValue>
771771
<Docs>
772-
<summary>Optional name of the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" />.</summary>
773-
<value>Optional name of the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" />. Value can be <see langword="null" />.</value>
772+
<summary>Get the name of the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" />.</summary>
773+
<value>The name of the <see cref="T:System.Runtime.Loader.AssemblyLoadContext" />. Its value can be <see langword="null" />.</value>
774774
<remarks>To be added.</remarks>
775775
</Docs>
776776
</Member>

0 commit comments

Comments
 (0)