Skip to content

Commit 19d059b

Browse files
gewarrenmairaw
andauthored
SignedCMS.ComputeSignature change for .NET Core (#3866)
* Fixes #3456 * Add remark and update parameter description * Update xml/System.Security.Cryptography.Pkcs/SignedCms.xml Co-Authored-By: Maira Wenzel <[email protected]>
1 parent 925ef81 commit 19d059b

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

xml/System.Security.Cryptography.Pkcs/SignedCms.xml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ The following permissions are required to access the signature key:
655655
</Parameters>
656656
<Docs>
657657
<param name="signer">A <see cref="T:System.Security.Cryptography.Pkcs.CmsSigner" /> object that represents the signer.</param>
658-
<summary>The <see cref="M:System.Security.Cryptography.Pkcs.SignedCms.ComputeSignature(System.Security.Cryptography.Pkcs.CmsSigner)" /> method creates a signature using the specified signer and adds the signature to the CMS/PKCS #7 message.</summary>
658+
<summary>Creates a signature using the specified signer and adds the signature to the CMS/PKCS #7 message.</summary>
659659
<remarks>
660660
<format type="text/markdown"><![CDATA[
661661
@@ -720,12 +720,14 @@ The following permissions are required to access the signature key:
720720
</Parameters>
721721
<Docs>
722722
<param name="signer">A <see cref="T:System.Security.Cryptography.Pkcs.CmsSigner" /> object that represents the signer.</param>
723-
<param name="silent">This parameter is not used. </param>
723+
<param name="silent">.NET Core only: <see langword="true" /> to request opening keys with PIN prompts disabled, where supported; otherwise, <see langword="false" />. In .NET Framework, this parameter is not used and a PIN prompt is always shown, if required.</param>
724724
<summary>Creates a signature using the specified signer and adds the signature to the CMS/PKCS #7 message. </summary>
725725
<remarks>
726726
<format type="text/markdown"><![CDATA[
727727
728-
## Remarks
728+
## Remarks
729+
730+
.NET Core only: The `silent` parameter has no effect if the <xref:System.Security.Cryptography.Pkcs.CmsSigner.PrivateKey?displayProperty=nameWithType> value is not null. The provided value controls whether or not computing the signature shows a PIN prompt. Even when the <xref:System.Security.Cryptography.Pkcs.CmsSigner.PrivateKey> property is null and the `silent` parameter is set to `true`, some combinations of operating system and signer options can still result in a PIN prompt.
729731
730732
## .NET Framework Security
731733
The following permissions are required to display the user interface:

0 commit comments

Comments
 (0)