Skip to content

Commit 2e9a5bf

Browse files
committed
Suggestions from code review
1 parent 4992391 commit 2e9a5bf

File tree

2 files changed

+23
-5
lines changed

2 files changed

+23
-5
lines changed

xml/System.Net.Security/SslClientAuthenticationOptions.xml

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,18 @@
193193
<ReturnType>System.Security.Cryptography.X509Certificates.X509ChainPolicy</ReturnType>
194194
</ReturnValue>
195195
<Docs>
196-
<summary>Gets or sets an optional customized policy for remote certificate validation. If not <see langword="null" />, <see cref="P:System.Net.Security.SslClientAuthenticationOptions.CertificateRevocationCheckMode" /> and <see cref="T:System.Net.Security.SslCertificateTrust" /> used to create the <see cref="P:System.Net.Security.SslClientAuthenticationOptions.ClientCertificateContext" /> instance are ignored.</summary>
196+
<summary>Gets or sets an optional customized policy for remote certificate validation</summary>
197197
<value>To be added.</value>
198-
<remarks>To be added.</remarks>
198+
<remarks>
199+
<format type="text/markdown"><![CDATA[
200+
201+
## Remarks
202+
203+
When the value of this property is not `null`, the value of the <xref:System.Net.Security.SslClientAuthenticationOptions.CertificateRevocationCheckMode> property is ignored.
204+
205+
When the value of this property is not `null`, any <xref:System.Net.Security.SslCertificateTrust> associated with the <xref:System.Net.Security.SslClientAuthenticationOptions.ClientCertificateContext> is ignored.
206+
]]></format>
207+
</remarks>
199208
</Docs>
200209
</Member>
201210
<Member MemberName="CertificateRevocationCheckMode">

xml/System.Net.Security/SslServerAuthenticationOptions.xml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,18 @@
189189
<ReturnType>System.Security.Cryptography.X509Certificates.X509ChainPolicy</ReturnType>
190190
</ReturnValue>
191191
<Docs>
192-
<summary>Gets or sets an optional customized policy for remote certificate validation. If not <see langword="null" />, <see cref="P:System.Net.Security.SslServerAuthenticationOptions.CertificateRevocationCheckMode" /> and <see cref="T:System.Net.Security.SslCertificateTrust" /> used to create the <see cref="P:System.Net.Security.SslServerAuthenticationOptions.ServerCertificateContext" /> instance are ignored.</summary>
192+
<summary>Gets or sets an optional customized policy for remote certificate validation</summary>
193193
<value>To be added.</value>
194-
<remarks>To be added.</remarks>
194+
<remarks>
195+
<format type="text/markdown"><![CDATA[
196+
197+
## Remarks
198+
199+
When the value of this property is not `null`, the value of the <xref:System.Net.Security.SslServerAuthenticationOptions.CertificateRevocationCheckMode> property is ignored.
200+
201+
When the value of this property is not `null` and a <xref:System.Net.Security.SslCertificateTrust> was provided to the value in the <xref:System.Net.Security.SslServerAuthenticationOptions.ServerCertificateContext> property, the trust list SslCertificateTrust will be sent in the handshake (when so configured) but the trust settings from this property will not be used when verifying any client authentication certificates.
202+
]]></format>
203+
</remarks>
195204
</Docs>
196205
</Member>
197206
<Member MemberName="CertificateRevocationCheckMode">
@@ -494,4 +503,4 @@
494503
</Docs>
495504
</Member>
496505
</Members>
497-
</Type>
506+
</Type>

0 commit comments

Comments
 (0)