Skip to content

Commit 6d32f04

Browse files
Apply suggestions from code review
Co-authored-by: Carlos Sánchez López <[email protected]>
1 parent 2e67e63 commit 6d32f04

File tree

3 files changed

+14
-34
lines changed

3 files changed

+14
-34
lines changed

xml/System.Windows.Forms/Application.xml

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -254,12 +254,8 @@
254254
<Docs>
255255
<summary>Gets the default color mode (dark mode) for the application.</summary>
256256
<value>To be added.</value>
257-
<remarks>
258-
<para>
259-
This is the <see cref="P:System.Windows.Forms.Application.SystemColorMode" />; which either has been set by <see cref="M:System.Windows.Forms.Application.SetColorMode(System.Windows.Forms.SystemColorMode)" /> or its default value <see cref="F:System.Windows.Forms.SystemColorMode.Classic" />.
260-
If it has been set to <see cref="F:System.Windows.Forms.SystemColorMode.System" />, then the actual color mode is determined by the system settings (which can be retrieved by the static (shared in VB) <see cref="P:System.Windows.Forms.Application.SystemColorMode" /> property.
261-
</para>
262-
</remarks>
257+
<remarks>This is the <see cref="P:System.Windows.Forms.Application.SystemColorMode" />; which either has been set by <see cref="M:System.Windows.Forms.Application.SetColorMode(System.Windows.Forms.SystemColorMode)" /> or its default value <see cref="F:System.Windows.Forms.SystemColorMode.Classic" />.
258+
If it has been set to <see cref="F:System.Windows.Forms.SystemColorMode.System" />, then the actual color mode is determined by the system settings (which can be retrieved by the static (shared in VB) <see cref="P:System.Windows.Forms.Application.SystemColorMode" /> property.</remarks>
263259
</Docs>
264260
</Member>
265261
<Member MemberName="CommonAppDataPath">
@@ -987,11 +983,9 @@
987983
<ReturnType>System.Boolean</ReturnType>
988984
</ReturnValue>
989985
<Docs>
990-
<summary>
991-
Gets a value indicating whether the application is running in a dark system color context.
992-
</summary>
986+
<summary>Gets a value indicating whether the application is running in a dark system color context.</summary>
993987
<value>To be added.</value>
994-
<remarks>In a high contrast mode, this will always return <see langword="false" /></remarks>
988+
<remarks>In a high contrast mode, this will always return <see langword="false" />.</remarks>
995989
</Docs>
996990
</Member>
997991
<Member MemberName="LeaveThreadModal">
@@ -1822,7 +1816,7 @@
18221816
<summary>Sets the default color mode (dark mode) for the application.</summary>
18231817
<remarks>
18241818
<para>
1825-
You should use this method to set the default color mode (dark mode) for the application. Set it, before creating any UI elements, to ensure that the correct color mode
1819+
You should use this method to set the default color mode (dark mode) for the application. Set it before creating any UI elements to ensure that the correct color mode
18261820
is used. You can set it to dark mode (<see cref="F:System.Windows.Forms.SystemColorMode.Dark" />), light mode (<see cref="F:System.Windows.Forms.SystemColorMode.Classic" />)
18271821
or to the system setting (<see cref="F:System.Windows.Forms.SystemColorMode.System" />).
18281822
</para>
@@ -1834,7 +1828,7 @@
18341828
Note that the dark color mode is only available from Windows 11 on or later versions. If the system is set to a high contrast mode, the dark mode is not available.
18351829
</para>
18361830
<para>
1837-
<b>Note for Visual Basic:</b> If you are using the Visual Basic Application Framework, you should set the color mode by handling the Application Events (see "WindowsFormsApplicationBase.ApplyApplicationDefaults").
1831+
<b>Note for Visual Basic:</b> If you are using the Visual Basic Application Framework, you should set the color mode by handling the Application Events (see <see cref="E:Microsoft.VisualBasic.ApplicationServices.WindowsFormsApplicationBase.ApplyApplicationDefaults" />).
18381832
</para>
18391833
</remarks>
18401834
</Docs>
@@ -2253,11 +2247,10 @@ The high DPI mode is set once per process. For more information about setting th
22532247
<value>To be added.</value>
22542248
<remarks>
22552249
<para>
2256-
The color setting is determined based on the operating system version and its system settings. It returns <see cref="F:System.Windows.Forms.SystemColorMode.Dark" /> if the dark mode is enabled in the system settings,
2257-
<see cref="F:System.Windows.Forms.SystemColorMode.Classic" /> if the color mode equals the light, standard color setting.
2250+
The color setting is determined based on the operating system version and its system settings. It returns <see cref="F:System.Windows.Forms.SystemColorMode.Dark" /> if the dark mode is enabled in the system settings, <see cref="F:System.Windows.Forms.SystemColorMode.Classic" /> if the color mode equals the light, standard color setting.
22582251
</para>
2259-
<para>SystemColorMode is supported on Windows 11 or later versions.</para>
2260-
<para>SystemColorModes is not supported, if the Windows OS <c>High Contrast Mode</c> has been enabled in the system settings.</para>
2252+
<para><c>SystemColorMode</c> is supported on Windows 11 or later versions.</para>
2253+
<para><c>SystemColorModes</c> is not supported if the Windows OS <c>High Contrast Mode</c> has been enabled in the system settings.</para>
22612254
</remarks>
22622255
</Docs>
22632256
</Member>

xml/System.Windows.Forms/TaskDialog.xml

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -267,11 +267,7 @@
267267
<param name="startupLocation">Gets or sets the position of the task dialog when it is shown.</param>
268268
<summary>Shows the task dialog with the specified owner asynchronously.</summary>
269269
<returns>The <see cref="T:System.Windows.Forms.TaskDialogButton" /> which was clicked by the user to close the dialog.</returns>
270-
<remarks>
271-
<para>
272-
Showing the dialog will bind the <paramref name="page" /> and its controls until this method returns or the dialog is navigated to a different page.
273-
</para>
274-
</remarks>
270+
<remarks>Showing the dialog will bind the <paramref name="page" /> and its controls until this method returns or the dialog is navigated to a different page.</remarks>
275271
<exception cref="T:System.ArgumentNullException">
276272
<paramref name="page" /> is <see langword="null" />.</exception>
277273
<exception cref="T:System.InvalidOperationException">The specified <paramref name="page" /> contains an invalid configuration.</exception>
@@ -308,11 +304,7 @@
308304
<param name="startupLocation">The position of the task dialog when it is shown.</param>
309305
<summary>Shows the task dialog with the specified owner asynchronously.</summary>
310306
<returns>The <see cref="T:System.Windows.Forms.TaskDialogButton" /> which was clicked by the user to close the dialog.</returns>
311-
<remarks>
312-
<para>
313-
Showing the dialog will bind the <paramref name="page" /> and its controls until this method returns or the dialog is navigated to a different page.
314-
</para>
315-
</remarks>
307+
<remarks>Showing the dialog will bind the <paramref name="page" /> and its controls until this method returns or the dialog is navigated to a different page.</remarks>
316308
<exception cref="T:System.ArgumentNullException">
317309
<paramref name="page" /> is <see langword="null" />.</exception>
318310
<exception cref="T:System.InvalidOperationException">The specified <paramref name="page" /> contains an invalid configuration.</exception>
@@ -349,11 +341,7 @@
349341
<param name="startupLocation">The position of the task dialog when it is shown.</param>
350342
<summary>Shows the task dialog with the specified owner asynchronously.</summary>
351343
<returns>The <see cref="T:System.Windows.Forms.TaskDialogButton" /> which was clicked by the user to close the dialog.</returns>
352-
<remarks>
353-
<para>
354-
Showing the dialog will bind the <paramref name="page" /> and its controls until this method returns or the dialog is navigated to a different page.
355-
</para>
356-
</remarks>
344+
<remarks>Showing the dialog will bind the <paramref name="page" /> and its controls until this method returns or the dialog is navigated to a different page.</remarks>
357345
<exception cref="T:System.ArgumentNullException">
358346
<paramref name="page" /> is <see langword="null" />.</exception>
359347
<exception cref="T:System.InvalidOperationException">The specified <paramref name="page" /> contains an invalid configuration.</exception>

xml/System.Windows.Forms/ToolStripItem.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6685,7 +6685,7 @@ If you set the <xref:System.Windows.Forms.ToolStripItem.ImageKey%2A> property, t
66856685
<ReturnType>System.Windows.Forms.ToolStripRenderer</ReturnType>
66866686
</ReturnValue>
66876687
<Docs>
6688-
<summary>Returns the parent <see cref="T:System.Windows.Forms.ToolStrip" />'s renderer</summary>
6688+
<summary>Returns the parent <see cref="T:System.Windows.Forms.ToolStrip" />'s renderer.</summary>
66896689
<value>To be added.</value>
66906690
<remarks>To be added.</remarks>
66916691
</Docs>
@@ -7300,8 +7300,7 @@ If you set the <xref:System.Windows.Forms.ToolStripItem.ImageKey%2A> property, t
73007300
<summary>Occurs when the value of the <see cref="P:System.Windows.Forms.ToolStripItem.Selected" /> property changes.</summary>
73017301
<remarks>
73027302
<para>This event is raised when an item is selected by mouse or keyboard, or programmatically.</para>
7303-
<para>.NET Core 3.1 had removed MainMenu and MenuItem controls. ToolStripItem.SelectedChanged event</para>
7304-
<para>is recommended as a replacement for the MenuItem.Select event.</para>
7303+
<para>The <c>MainMenu</c> and <c>MenuItem</c> controls were removed in .NET Core 3.1. The <c>ToolStripItem.SelectedChanged</c> event is recommended as a replacement for the <c>MenuItem.Select</c> event.</para>
73057304
</remarks>
73067305
</Docs>
73077306
</Member>

0 commit comments

Comments
 (0)