Add EnsureStatusCode invokation to illustrate the point of the ResponseHeadersRead option

FERNAN OVIEDO CANDELARESI · FERNAN OVIEDO CANDELARESI · commit 776ec6275479 · 2024-12-10T12:26:11.000-08:00
diff --git a/xml/System.Net.Http/HttpCompletionOption.xml b/xml/System.Net.Http/HttpCompletionOption.xml
@@ -48,7 +48,7 @@ httpClient.Timeout = TimeSpan.FromSeconds(30);
 using (var response = await httpClient.GetAsync("http://localhost:12345/", HttpCompletionOption.ResponseHeadersRead)) // 30-second timeout but ONLY up until past the headers
 {
     // Do other stuff that doesn't rely on the content first, like status code validation
-    // ...
+    response.EnsureSuccessStatusCode();
 
     var content = await response.Content.ReadAsStringAsync(); // NO TIMEOUT
 }

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ httpClient.Timeout = TimeSpan.FromSeconds(30);`
`48`	`48`	`using (var response = await httpClient.GetAsync("http://localhost:12345/", HttpCompletionOption.ResponseHeadersRead)) // 30-second timeout but ONLY up until past the headers`
`49`	`49`	`{`
`50`	`50`	`// Do other stuff that doesn't rely on the content first, like status code validation`
`51`		`- // ...`
	`51`	`+ response.EnsureSuccessStatusCode();`
`52`	`52`
`53`	`53`	`var content = await response.Content.ReadAsStringAsync(); // NO TIMEOUT`
`54`	`54`	`}`