Skip to content

Commit 85cba81

Browse files
carlossanlopRon Petrusha
authored andcommitted
Automatically port System.Composition triple slash comments (#2680)
* Automatically port System.Composition triple slash comments * Documented some exception conditions. * Revised exception condition. * suggestion by maryamariyan * remarks
1 parent e2a06fd commit 85cba81

File tree

5 files changed

+57
-12
lines changed

5 files changed

+57
-12
lines changed

xml/System.Composition.Hosting.Core/CompositionOperation.xml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,15 @@
2222
</Interfaces>
2323
<Docs>
2424
<summary>Represents a single composition operation.</summary>
25-
<remarks></remarks>
25+
<remarks>
26+
<format type="text/markdown"><![CDATA[
27+
28+
## Remarks
29+
30+
Instances of this class are not safe for access by multiple threads.
31+
32+
]]></format>
33+
</remarks>
2634
</Docs>
2735
<Members>
2836
<Member MemberName="AddNonPrerequisiteAction">
@@ -152,4 +160,4 @@
152160
</Docs>
153161
</Member>
154162
</Members>
155-
</Type>
163+
</Type>

xml/System.Composition.Hosting.Core/ExportDescriptorProvider.xml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,15 @@
1818
<Interfaces />
1919
<Docs>
2020
<summary>Provides the description of an export for a part known to the composition engine.</summary>
21-
<remarks></remarks>
21+
<remarks>
22+
<format type="text/markdown"><![CDATA[
23+
24+
## Remarks
25+
26+
Instances of this class are not required to be safe for concurrent access by multiple threads.
27+
28+
]]></format>
29+
</remarks>
2230
</Docs>
2331
<Members>
2432
<Member MemberName=".ctor">
@@ -155,4 +163,4 @@
155163
</Docs>
156164
</Member>
157165
</Members>
158-
</Type>
166+
</Type>

xml/System.Composition.Hosting.Core/LifetimeContext.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -241,10 +241,10 @@ A bound part instance is always protected by locking <see langword="this" />, an
241241
<param name="contract">The contract.</param>
242242
<param name="export">After this method returns, contains the contract instance if available; otherwise, <see langword="null" />.</param>
243243
<summary>Retrieves a contract instance from the composition context.</summary>
244-
<returns>
245-
<see langword="true" /> if the instance was retrieved; otherwise, <see langword="false" />.</returns>
244+
<returns><see langword="true" /> if the instance was retrieved; otherwise, <see langword="false" />.</returns>
246245
<remarks></remarks>
246+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <paramref name="contract" />.</exception>
247247
</Docs>
248248
</Member>
249249
</Members>
250-
</Type>
250+
</Type>

xml/System.Composition/CompositionContext.xml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ Note that this constructor is protected; it can only be called by classes derive
7474
<summary>Retrieves the export that matches the specified contract.</summary>
7575
<returns>The exported value.</returns>
7676
<remarks></remarks>
77-
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export found for <paramref name="contract" />.</exception>
77+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <paramref name="contract" />.</exception>
7878
</Docs>
7979
</Member>
8080
<Member MemberName="GetExport">
@@ -103,6 +103,7 @@ Note that this constructor is protected; it can only be called by classes derive
103103
<summary>Retrieves the export that matches the specified type.</summary>
104104
<returns>The exported value.</returns>
105105
<remarks></remarks>
106+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <paramref name="exportType" />.</exception>
106107
</Docs>
107108
</Member>
108109
<Member MemberName="GetExport">
@@ -133,6 +134,7 @@ Note that this constructor is protected; it can only be called by classes derive
133134
<summary>Retrieves the export that matches the specified name and type.</summary>
134135
<returns>The exported value.</returns>
135136
<remarks></remarks>
137+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <paramref name="exportType" /> and <paramref name="contractName" />.</exception>
136138
</Docs>
137139
</Member>
138140
<Member MemberName="GetExport&lt;TExport&gt;">
@@ -162,6 +164,7 @@ Note that this constructor is protected; it can only be called by classes derive
162164
<summary>Retrieves the export that matches the specified generic type parameter.</summary>
163165
<returns>The exported value.</returns>
164166
<remarks></remarks>
167+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <typeparamref name="TExport" />.</exception>
165168
</Docs>
166169
</Member>
167170
<Member MemberName="GetExport&lt;TExport&gt;">
@@ -194,6 +197,7 @@ Note that this constructor is protected; it can only be called by classes derive
194197
<summary>Retrieves the export that matches the specified generic type parameter and contract name.</summary>
195198
<returns>The exported value.</returns>
196199
<remarks></remarks>
200+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <typeparamref name="TExport" /> and <paramref name="contractName" />.</exception>
197201
</Docs>
198202
</Member>
199203
<Member MemberName="GetExports">
@@ -222,6 +226,7 @@ Note that this constructor is protected; it can only be called by classes derive
222226
<summary>Retrieves a collection of all exports that match the specified type.</summary>
223227
<returns>A collection of exported values.</returns>
224228
<remarks></remarks>
229+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No exports were found for <paramref name="exportType" />.</exception>
225230
</Docs>
226231
</Member>
227232
<Member MemberName="GetExports">
@@ -252,6 +257,7 @@ Note that this constructor is protected; it can only be called by classes derive
252257
<summary>Retrieves all exports that match the specified contract name and type.</summary>
253258
<returns>A collection of exported values.</returns>
254259
<remarks></remarks>
260+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No exports were found for <paramref name="exportType" />.</exception>
255261
</Docs>
256262
</Member>
257263
<Member MemberName="GetExports&lt;TExport&gt;">
@@ -281,6 +287,7 @@ Note that this constructor is protected; it can only be called by classes derive
281287
<summary>Retrieves all exports that match the specified generic type parameter.</summary>
282288
<returns>A collection of exported values.</returns>
283289
<remarks></remarks>
290+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No exports were found for <typeparamref name="TExport" />.</exception>
284291
</Docs>
285292
</Member>
286293
<Member MemberName="GetExports&lt;TExport&gt;">
@@ -313,6 +320,7 @@ Note that this constructor is protected; it can only be called by classes derive
313320
<summary>Retrieves all exports that match the specified generic type parameter and contract name.</summary>
314321
<returns>A collection of exported values.</returns>
315322
<remarks></remarks>
323+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No exports were found for <typeparamref name="TExport" /> and <paramref name="contractName" />.</exception>
316324
</Docs>
317325
</Member>
318326
<Member MemberName="TryGetExport">
@@ -344,6 +352,7 @@ Note that this constructor is protected; it can only be called by classes derive
344352
<returns>
345353
<see langword="true" /> if an export was found; otherwise, <see langword="false" />.</returns>
346354
<remarks></remarks>
355+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <paramref name="contract" />.</exception>
347356
</Docs>
348357
</Member>
349358
<Member MemberName="TryGetExport">
@@ -375,6 +384,7 @@ Note that this constructor is protected; it can only be called by classes derive
375384
<returns>
376385
<see langword="true" /> if an export was found; otherwise, <see langword="false" />.</returns>
377386
<remarks></remarks>
387+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <paramref name="contract" />.</exception>
378388
</Docs>
379389
</Member>
380390
<Member MemberName="TryGetExport">
@@ -408,6 +418,7 @@ Note that this constructor is protected; it can only be called by classes derive
408418
<returns>
409419
<see langword="true" /> if an export was found; otherwise, <see langword="false" />.</returns>
410420
<remarks></remarks>
421+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <paramref name="contract" />.</exception>
411422
</Docs>
412423
</Member>
413424
<Member MemberName="TryGetExport&lt;TExport&gt;">
@@ -441,6 +452,7 @@ Note that this constructor is protected; it can only be called by classes derive
441452
<returns>
442453
<see langword="true" /> if an export was found; otherwise, <see langword="false" />.</returns>
443454
<remarks></remarks>
455+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <paramref name="contract" />.</exception>
444456
</Docs>
445457
</Member>
446458
<Member MemberName="TryGetExport&lt;TExport&gt;">
@@ -476,7 +488,8 @@ Note that this constructor is protected; it can only be called by classes derive
476488
<returns>
477489
<see langword="true" /> if an export was found; otherwise, <see langword="false" />.</returns>
478490
<remarks></remarks>
491+
<exception cref="T:System.Composition.Hosting.CompositionFailedException">No export was found for <paramref name="contract" />.</exception>
479492
</Docs>
480493
</Member>
481494
</Members>
482-
</Type>
495+
</Type>

xml/System.Composition/CompositionContextExtensions.xml

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,15 @@
4646
<param name="compositionContext">The context to draw exports from.</param>
4747
<param name="objectWithLooseImports">The object to satisfy imports on.</param>
4848
<summary>Satisfies the imports of the specified object from the specified context.</summary>
49-
<remarks></remarks>
49+
<remarks>
50+
<format type="text/markdown"><![CDATA[
51+
52+
## Remarks
53+
54+
Because this method uses reflection, it is slow. Caching can help improve performance.
55+
56+
]]></format>
57+
</remarks>
5058
<exception cref="T:System.ArgumentNullException">
5159
<paramref name="compositionContext" /> is <see langword="null" />.</exception>
5260
<exception cref="T:System.ArgumentNullException">
@@ -82,7 +90,15 @@
8290
<param name="objectWithLooseImports">The object to satisfy imports on.</param>
8391
<param name="conventions">Conventions to use when satisfying imports.</param>
8492
<summary>Satisfies the imports of the specified object from the specified context, using the specified conventions.</summary>
85-
<remarks></remarks>
93+
<remarks>
94+
<format type="text/markdown"><![CDATA[
95+
96+
## Remarks
97+
98+
Because this method uses reflection, it is slow. Caching can help improve performance.
99+
100+
]]></format>
101+
</remarks>
86102
<exception cref="T:System.ArgumentNullException">
87103
<paramref name="compositionContext" /> is <see langword="null" />.</exception>
88104
<exception cref="T:System.ArgumentNullException">
@@ -94,4 +110,4 @@
94110
</Docs>
95111
</Member>
96112
</Members>
97-
</Type>
113+
</Type>

0 commit comments

Comments
 (0)