Skip to content

Commit 8d78e98

Browse files
buyaa-ngewarren
andauthored
Apply suggestions from code review
Co-authored-by: Genevieve Warren <[email protected]>
1 parent c6f266d commit 8d78e98

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

xml/System.Reflection.Emit/AssemblyBuilder.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
For more information about this API, see [Supplemental API remarks for AssemblyBuilder](/dotnet/fundamentals/runtime-libraries/system-reflection-emit-assemblybuilder).
8585
8686
> [!WARNING]
87-
> `AssemblyBuilder` APIs require a fully trusted environment with trusted input, similarly as other technologies such as compilers. There are no restrictions other than basic validation for generated IL, for member name, count and associated metadata such as custom attributes, that the AssemblyBuilder can contain.
87+
> `AssemblyBuilder` APIs require a fully trusted environment with trusted input, similar to other technologies such as compilers. There are no restrictions other than basic validation for generated IL that the `AssemblyBuilder` can contain. That includes validation for member name, count, and associated metadata, such as custom attributes.
8888
]]>
8989
</format>
9090
</remarks>

xml/System.Reflection.Emit/ILGenerator.xml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,14 @@
8585
MSIL is used as input to a just-in-time (JIT) compiler.
8686
8787
> [!WARNING]
88-
> There are no restrictions, other than basic validation for ILGenerator APIs that used for producing method IL. If untrusted input is used for producing IL:
88+
> There are no restrictions, other than basic validation, for ILGenerator APIs that produce method IL. If untrusted input is used for producing IL:
89+
>
8990
> - IL and metadata can contain secrets provided by the consumer.
90-
> - IL can be invalid such as not having a balanced push vs. pop opcodes, or invalid operands for a given opcode.
91-
> - Can contain any code that may, for example, deadlock, have infinite stack recursion, or have an infinite loop.
91+
> - IL can be invalid, such as not having balanced push versus pop opcodes, or invalid operands for a given opcode.
92+
> - IL can contain any code that might, for example, deadlock, have infinite stack recursion, or have an infinite loop.
9293
> - IL can load and execute code on any other reachable assembly.
9394
>
94-
> Such code can do whatever it wishes when the method is loaded and executed. To restrict such vulnerabilities `ILGenerator` require a fully trusted environment with trusted input.
95+
> Such code can do whatever it wishes when the method is loaded and executed. To protect against such vulnerabilities, `ILGenerator` requires a fully trusted environment with trusted input.
9596
]]></format>
9697
</remarks>
9798
</Docs>

xml/System.Reflection.Emit/PersistedAssemblyBuilder.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
For more information about this API, see [Persisted dynamic assemblies in .NET](/dotnet/fundamentals/runtime-libraries/system-reflection-emit-persistedassemblybuilder).
3434
3535
> [!WARNING]
36-
> `PersistedAssemblyBuilder` APIs require a fully trusted environment with trusted input, similarly as other technologies such as compilers. There are no restrictions other than basic validation for generated IL, for member name, count and associated metadata such as custom attributes, that the AssemblyBuilder can contain.
36+
> `PersistedAssemblyBuilder` APIs require a fully trusted environment with trusted input, similar to other technologies such as compilers. There are no restrictions other than basic validation for generated IL that the `AssemblyBuilder` can contain. That includes validation for member name, count, and associated metadata, such as custom attributes.
3737
]]></format>
3838
</remarks>
3939
</Docs>

0 commit comments

Comments
 (0)