Skip to content

Commit c39c68f

Browse files
carlossanlopRon Petrusha
carlossanlop
and
Ron Petrusha
authored
Apply suggestions from code review
 Suggestions by rpetrusha Co-Authored-By: Ron Petrusha <[email protected]>
1 parent 74fbded commit c39c68f

File tree

6 files changed

+34
-17
lines changed

6 files changed

+34
-17
lines changed

‎xml/System.Security.Claims/Claim.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ if (null != principal)
167167
<remarks>
168168
<format type="text/markdown"><![CDATA[
169169
170-
<xref:P:System.Security.Claims.Claim.Subject> will be set to `null`.
170+
<xref:System.Security.Claims.Claim.Subject> is set to `null`.
171171
172172
]]></format>
173173
</remarks>
@@ -249,7 +249,7 @@ if (null != principal)
249249
<remarks>
250250
<format type="text/markdown"><![CDATA[
251251
252-
<xref:P:System.Security.Claims.Claim.Subject> will be set to `subject`.
252+
<xref:System.Security.Claims.Claim.Subject> is set to `subject`.
253253
254254
]]></format>
255255
</remarks>
@@ -1067,4 +1067,4 @@ if (null != principal)
10671067
</Docs>
10681068
</Member>
10691069
</Members>
1070-
</Type>
1070+
</Type>

‎xml/System.Security.Claims/ClaimsIdentity.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1446,7 +1446,7 @@
14461446
<remarks>
14471447
<format type="text/markdown"><![CDATA[
14481448
1449-
The comparison is done in <xref:F:System.StringComparison.OrdinalIgnoreCase> mode.
1449+
The comparison is done in <xref:System.StringComparison.OrdinalIgnoreCase?displayProperty=nameWithType> mode.
14501450
14511451
]]></format>
14521452
</remarks>
@@ -2004,4 +2004,4 @@ The comparison is done in <xref:F:System.StringComparison.OrdinalIgnoreCase> mod
20042004
</Docs>
20052005
</Member>
20062006
</Members>
2007-
</Type>
2007+
</Type>

‎xml/System.Security.Claims/ClaimsPrincipal.xml

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -859,7 +859,12 @@ if (null != principal)
859859
<remarks>
860860
<format type="text/markdown"><![CDATA[
861861
862-
Each <xref:T:System.Security.Claims.ClaimsIdentity> is called. <see also cref="M:System.Security.Claims.ClaimsIdentity.FindFirst(System.String)" />.
862+
## Remarks
863+
864+
Each <xref:T:System.Security.Claims.ClaimsIdentity> is called.
865+
866+
## See also
867+
<xref:System.Security.Claims.ClaimsIdentity.FindFirst(System.String)?displayProperty=nameWithType>
863868
864869
]]></format>
865870
</remarks>
@@ -905,7 +910,13 @@ Each <xref:T:System.Security.Claims.ClaimsIdentity> is called. <see also cref="M
905910
<remarks>
906911
<format type="text/markdown"><![CDATA[
907912
908-
Each <xref:T:System.Security.Claims.ClaimsIdentity> is called. <see also cref="M:System.Security.Claims.ClaimsIdentity.FindFirst(System.Predicate{System.Security.Claims.Claim})" />.
913+
## Remarks
914+
915+
Each <xref:System.Security.Claims.ClaimsIdentity> is called.
916+
917+
## See also
918+
919+
<xref:System.Security.Claims.ClaimsIdentity.FindFirst(System.Predicate{System.Security.Claims.Claim})?displayProperty=nameWithType>.
909920
910921
]]></format>
911922
</remarks>
@@ -1007,7 +1018,13 @@ Each <xref:T:System.Security.Claims.ClaimsIdentity> is called. <see also cref="M
10071018
<remarks>
10081019
<format type="text/markdown"><![CDATA[
10091020
1010-
Each <xref:T:System.Security.Claims.ClaimsIdentity> is called. <see also cref="M:System.Security.Claims.ClaimsIdentity.HasClaim(System.String,System.String)" />.
1021+
## Remarks
1022+
1023+
Each <xref:System.Security.Claims.ClaimsIdentity> is called.
1024+
1025+
## See also
1026+
1027+
<xref:System.Security.Claims.ClaimsIdentity.HasClaim(System.String,System.String)?displayProperty=nameWithType>.
10111028
10121029
]]></format>
10131030
</remarks>
@@ -1340,4 +1357,4 @@ Each <xref:T:System.Security.Claims.ClaimsIdentity> is called. <see also cref="M
13401357
</Docs>
13411358
</Member>
13421359
</Members>
1343-
</Type>
1360+
</Type>

‎xml/System.Security.Cryptography.Pkcs/Pkcs12CertBag.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
4646
No validation is done to ensure that the `encodedCertificate` value is correct for the indicated `certificateType`.
4747
48-
Note that for X.509 public-key certificates the correct encoding for a CertBag value is to wrap the DER-encoded certificate in an OCTET STRING.
48+
Note that for X.509 public-key certificates, the correct encoding for a CertBag value is to wrap the DER-encoded certificate in an OCTET STRING.
4949
5050
]]></format>
5151
</remarks>
@@ -142,4 +142,4 @@ Note that for X.509 public-key certificates the correct encoding for a CertBag v
142142
</Docs>
143143
</Member>
144144
</Members>
145-
</Type>
145+
</Type>

‎xml/System.Security.Cryptography.Pkcs/Rfc3161TimestampToken.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,9 @@
4848
4949
Successive calls to this method return the same object.
5050
51-
The SignedCms class is mutable, but changes to that object are not reflected in the <xref:T:System.Security.Cryptography.Pkcs.Rfc3161TimestampToken> object which produced it.
51+
The <xref:System.Security.Cryptography.Pkcs.SignedCms> class is mutable, but changes to that object are not reflected in the <xref:System.Security.Cryptography.Pkcs.Rfc3161TimestampToken> object that produced it.
5252
53-
The value from calling <xref:M:System.Security.Cryptography.Pkcs.SignedCms.Encode> can be interpreted again as an <xref:T:System.Security.Cryptography.Pkcs.Rfc3161TimestampToken> via another call to <xref:M:System.Security.Cryptography.Pkcs.Rfc3161TimestampToken.TryDecode(System.ReadOnlyMemory{System.Byte},System.Security.Cryptography.Pkcs.Rfc3161TimestampToken@,System.Int32@)>.
53+
The value from calling <xref:System.Security.Cryptography.Pkcs.SignedCms.Encode?displayProperty=nameWithType> can be interpreted again as an <xref:System.Security.Cryptography.Pkcs.Rfc3161TimestampToken> via another call to <xref:System.Security.Cryptography.Pkcs.Rfc3161TimestampToken.TryDecode(System.ReadOnlyMemory{System.Byte},System.Security.Cryptography.Pkcs.Rfc3161TimestampToken@,System.Int32@)?displayProperty=nameWithType>.
5454
5555
]]></format>
5656
</remarks>
@@ -240,4 +240,4 @@ The value from calling <xref:M:System.Security.Cryptography.Pkcs.SignedCms.Encod
240240
</Docs>
241241
</Member>
242242
</Members>
243-
</Type>
243+
</Type>

‎xml/System.Security.Cryptography.Xml/RSAKeyValue.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@
171171
<remarks>
172172
<format type="text/markdown"><![CDATA[
173173
174-
Based upon https://www.w3.org/TR/xmldsig-core/#sec-RSAKeyValue.
174+
Based upon [The RSAKeyValue Element](https://www.w3.org/TR/xmldsig-core/#sec-RSAKeyValue) in the W3C Recommendation [XML Signature Syntax and Processing Version 1.1](https://www.w3.org/TR/xmldsig-core/).
175175
176176
]]></format>
177177
</remarks>
@@ -247,7 +247,7 @@ Based upon https://www.w3.org/TR/xmldsig-core/#sec-RSAKeyValue.
247247
<remarks>
248248
<format type="text/markdown"><![CDATA[
249249
250-
Based upon https://www.w3.org/TR/xmldsig-core/#sec-RSAKeyValue.
250+
Based upon [The RSAKeyValue Element](https://www.w3.org/TR/xmldsig-core/#sec-RSAKeyValue) in the W3C Recommendation [XML Signature Syntax and Processing Version 1.1](https://www.w3.org/TR/xmldsig-core/).
251251
252252
]]></format>
253253
</remarks>
@@ -256,4 +256,4 @@ Based upon https://www.w3.org/TR/xmldsig-core/#sec-RSAKeyValue.
256256
</Docs>
257257
</Member>
258258
</Members>
259-
</Type>
259+
</Type>

0 commit comments

Comments
 (0)