Skip to content

Commit db8f1d7

Browse files
Missing event handler DownloadDataCompleted (#8551)
An example of subscribe event is provided for the WebClient events. Some events have the event handler method in the documentation (DownloadFileCompleted, DownloadProgressChanged, and UploadProgressChanged). Some events are missing the method specified when the event is subscribed. This includes DownloadDataCompleted which is missing the method to when the event was subscribed. DownloadDataCompleted was fixed to include the missing event handler method using the same pattern as UploadProgressChanged (a code section for the subscribe and a second code section for the event handler method)
1 parent ff609de commit db8f1d7

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

xml/System.Net/WebClient.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -878,6 +878,12 @@
878878
[!code-csharp[NCLWebClientAsync#21](~/snippets/csharp/System.Net/DownloadDataCompletedEventArgs/Overview/asyncmethods.cs#21)]
879879
[!code-vb[NCLWebClientAsync#21](~/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientAsync/VB/asyncmethods.vb#21)]
880880

881+
The following code example shows an implementation of a handler for this event.
882+
883+
[!code-cpp[NCLWebClientAsync#22](~/snippets/cpp/VS_Snippets_Remoting/NCLWebClientAsync/CPP/asyncmethods.cpp#22)]
884+
[!code-csharp[NCLWebClientAsync#22](~/snippets/csharp/System.Net/DownloadDataCompletedEventArgs/Overview/asyncmethods.cs#22)]
885+
[!code-vb[NCLWebClientAsync#22](~/snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientAsync/VB/asyncmethods.vb#22)]
886+
881887
]]></format>
882888
</remarks>
883889
</Docs>

0 commit comments

Comments
 (0)