Skip to content

Commit de2e5b9

Browse files
author
Ron Petrusha
authored
Restored enumeration member remarks, Part 6 (#2583)
* Migrated additional enumeration remarks * Apply suggestions from code review Co-Authored-By: Maira Wenzel <[email protected]> * Addressed review comments
1 parent 7c1f924 commit de2e5b9

File tree

9 files changed

+103
-240
lines changed

9 files changed

+103
-240
lines changed

xml/Microsoft.Build.Execution/BuildRequestDataFlags.xml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,17 @@
1919
</Attributes>
2020
<Docs>
2121
<summary>Flags providing additional control over the build request.</summary>
22-
<remarks>To be added.</remarks>
22+
<remarks>
23+
<format type="text/markdown"><![CDATA[
24+
25+
## Remarks
26+
27+
The `IgnoreExistingProjectState` flag is provided only for those cases where the client knows that the new build request does not depend on the project state generated by a previous request. Setting this flag can provide a performance boost in the case of incompatible node affinities, because MSBuild would otherwise have to serialize the project state from one node to another. Serializing the project state can be expensive, depending on the amount of data the project has previously generated.
28+
29+
The `IgnoreExistingProjectState` flag has no effect on target results, so if a previous request has built a target, the new request will not rebuild the target. Additionally, none of the project state mutations which occurred as a consequence of previously building that target will be reapplied.
30+
31+
]]></format>
32+
</remarks>
2333
</Docs>
2434
<Members>
2535
<Member MemberName="IgnoreExistingProjectState">
@@ -39,17 +49,7 @@
3949
</ReturnValue>
4050
<MemberValue>4</MemberValue>
4151
<Docs>
42-
<summary>When this flag is present and the project has previously been built on a node whose affinity is incompatible with the affinity this request requires, this build request ignores the project state (but not the target results) that was previously generated.</summary>
43-
<remarks>
44-
<format type="text/markdown"><![CDATA[
45-
46-
## Remarks
47-
This behavior, when this flag is present, is not usually desired. This flag is provided only for those cases where the client knows that the new build request does not depend on the project state generated by a previous request. Setting this flag can provide a performance boost in the case of incompatible node affinities, because MSBuild would otherwise have to serialize the project state from one node to another, Serializing the project state can be expensive, depending on the amount of data the project has previously generated.
48-
49-
This flag has no effect on target results, so if a previous request has built a target, the new request will not re-build the target. Additionally, none of the project state mutations which occurred as a consequence of previously building that target will be re-applied.
50-
51-
]]></format>
52-
</remarks>
52+
<summary>When this flag is present and the project has previously been built on a node whose affinity is incompatible with the affinity this request requires, this build request ignores the project state (but not the target results) that was previously generated. This behavior is not usually desired; see the [Remarks](#remarks) section for more information.</summary>
5353
</Docs>
5454
</Member>
5555
<Member MemberName="None">

xml/Microsoft.SqlServer.Server/Format.xml

Lines changed: 36 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,43 @@
2626
<format type="text/markdown"><![CDATA[
2727
2828
## Remarks
29-
Used by <xref:Microsoft.SqlServer.Server.SqlUserDefinedTypeAttribute> and <xref:Microsoft.SqlServer.Server.SqlUserDefinedAggregateAttribute> to indicate the serialization format of a user-defined type (UDT) or aggregate.
29+
30+
This enumeration is used by <xref:Microsoft.SqlServer.Server.SqlUserDefinedTypeAttribute> and <xref:Microsoft.SqlServer.Server.SqlUserDefinedAggregateAttribute> to indicate the serialization format of a user-defined type (UDT) or aggregate. Use of the `Native` and `UserDefined` enumeration members has special requirements.
31+
32+
- `Format.Native`
33+
34+
The requirements for the `Format.Native` format are:
3035
31-
36+
- The <xref:System.Runtime.InteropServices.StructLayoutAttribute> with a <xref:System.Runtime.InteropServices.StructLayoutAttribute.Value> property value of <xref:System.Runtime.InteropServices.LayoutKind.Sequential?displayProperty=nameWithType> must be applied to the aggregate or UDT if it is defined in a class and not a structure. This controls the physical layout of the data fields and is used to force the members to be laid out sequentially in the order they appear. SQL Server uses this attribute to determine the field order for UDTs with multiple fields.
3237
38+
- The type must contain at least one member (serialized values cannot be zero bytes in size).
39+
40+
- All the fields of the aggregate must be *blittable*; that is, they must have a common representation in both managed and unmanaged memory and not require special handling by the interop marshaler.
41+
42+
- All the fields of the UDT should be of one of the following types that can be serialized: `bool`, `byte`, `sbyte`, `short`, `ushort`, `int`, `uint`, `long`, `ulong`, `float`, `double`, <xref:System.Data.SqlTypes.SqlByte>, <xref:System.Data.SqlTypes.SqlInt16>, <xref:System.Data.SqlTypes.SqlInt32>, <xref:System.Data.SqlTypes.SqlInt64>, <xref:System.Data.SqlTypes.SqlDateTime>, <xref:System.Data.SqlTypes.SqlSingle>, <xref:System.Data.SqlTypes.SqlDouble>, <xref:System.Data.SqlTypes.SqlMoney>, or other value types defined by the user that contain fields of one of these types.
43+
44+
- The aggregate must not specify a value for `MaxByteSize`.
45+
46+
- The aggregate must not have any [NonSerialized] fields.
47+
48+
- Fields must not be marked as an explicit layout (with a <xref:System.Runtime.InteropServices.StructLayoutAttribute.Value?displayProperty=nameWithType> of <xref:System.Runtime.InteropServices.LayoutKind.Explicit?displayProperty=nameWithType>).
49+
50+
- `Format.UserDefined`
51+
52+
The requirements for the `Format.UserDefined` format are:
53+
54+
- The aggregate must specify a value for `MaxByteSize`.
55+
56+
- Specify the <xref:Microsoft.SqlServer.Server.SqlUserDefinedTypeAttribute.IsByteOrdered%2A?displayProperty=nameWithType> attribute property. The default value is `false`.
57+
58+
- If you omit any field in the <xref:Microsoft.SqlServer.Server.IBinarySerialize.Read%2A?displayProperty=nameWithType> or <xref:Microsoft.SqlServer.Server.IBinarySerialize.Write%2A?displayProperty=nameWithType> methods, the state of that field is not serialized.
59+
3360
## Examples
34-
The following example shows the `UserDefinedType` attribute of the Point UDT. The UDT is byte-ordered, is named "Point", has a validation method named "ValidatePoint", and uses the native serialization format.
61+
62+
The following example shows the `UserDefinedType` attribute of the Point UDT. The UDT is byte-ordered, is named "Point", has a validation method named "ValidatePoint", and uses the native serialization format.
3563
36-
[!code-csharp[DataWorks SqlUserDefinedTypeAttribute Example#1](~/samples/snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlUserDefinedTypeAttribute Example/CS/source.cs#1)]
37-
[!code-vb[DataWorks SqlUserDefinedTypeAttribute Example#1](~/samples/snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks SqlUserDefinedTypeAttribute Example/VB/source.vb#1)]
64+
[!code-csharp[DataWorks SqlUserDefinedTypeAttribute Example#1](~/samples/snippets/csharp/VS_Snippets_ADO.NET/DataWorks SqlUserDefinedTypeAttribute Example/CS/source.cs#1)]
65+
[!code-vb[DataWorks SqlUserDefinedTypeAttribute Example#1](~/samples/snippets/visualbasic/VS_Snippets_ADO.NET/DataWorks SqlUserDefinedTypeAttribute Example/VB/source.vb#1)]
3866
3967
]]></format>
4068
</remarks>
@@ -65,29 +93,7 @@
6593
</ReturnValue>
6694
<MemberValue>1</MemberValue>
6795
<Docs>
68-
<summary>The <see langword="Native" /> serialization format uses a very simple algorithm that enables SQL Server to store an efficient representation of the UDT on disk. Types marked for <see langword="Native" /> serialization can only have value types (structs in Microsoft Visual C# and structures in Microsoft Visual Basic .NET) as members. Members of reference types (such as classes in Visual C# and Visual Basic), either user-defined or those existing in the framework (such as <see cref="T:System.String" />), are not supported.</summary>
69-
<remarks>
70-
<format type="text/markdown"><![CDATA[
71-
72-
## Remarks
73-
The requirements for this format are:
74-
75-
- The `StructLayout.LayoutKindSequential` attribute must be applied to the aggregate or UDT if it is defined in a class and not a structure. This controls the physical layout of the data fields, and is used to force the members to be laid out sequentially in the order they appear. SQL Server uses this attribute to determine the field order for UDTs with multiple fields.
76-
77-
- The type must contain at least one member (serialized values cannot be zero bytes in size).
78-
79-
- All the fields of the aggregate must be *blittable*, that is, they must have a common representation in both managed and unmanaged memory and not require special handling by the interop marshaler.
80-
81-
- All the fields of the UDT should be of one of the following types that can be serialized: `bool`, `byte`, `sbyte`, `short`, `ushort`, `int`, `uint`, `long`, `ulong`, `float`, `double`, <xref:System.Data.SqlTypes.SqlByte>, <xref:System.Data.SqlTypes.SqlInt16>, <xref:System.Data.SqlTypes.SqlInt32>, <xref:System.Data.SqlTypes.SqlInt64>, <xref:System.Data.SqlTypes.SqlDateTime>, <xref:System.Data.SqlTypes.SqlSingle>, <xref:System.Data.SqlTypes.SqlDouble>, <xref:System.Data.SqlTypes.SqlMoney>, or other value types defined by the user that contain fields of one of these types.
82-
83-
- The aggregate must not specify a value for `MaxByteSize`.
84-
85-
- The aggregate must not have any [NonSerialized] fields.
86-
87-
- Fields must not be marked as an explicit layout (<xref:System.Runtime.InteropServices.StructLayoutAttribute>).
88-
89-
]]></format>
90-
</remarks>
96+
<summary>This serialization format uses a very simple algorithm that enables SQL Server to store an efficient representation of the UDT on disk. Types marked for <see langword="Native" /> serialization can only have value types (structs in Microsoft Visual C# and structures in Microsoft Visual Basic .NET) as members. Members of reference types (such as classes in Visual C# and Visual Basic), either user-defined or those existing in .NET class libraries (such as <see cref="T:System.String" />), are not supported.</summary>
9197
</Docs>
9298
</Member>
9399
<Member MemberName="Unknown">
@@ -143,20 +149,8 @@
143149
</ReturnValue>
144150
<MemberValue>2</MemberValue>
145151
<Docs>
146-
<summary>The <see langword="UserDefined" /> serialization format gives the developer full control over the binary format through the <see cref="T:Microsoft.SqlServer.Server.IBinarySerialize" /><see langword=".Write" /> and <see cref="T:Microsoft.SqlServer.Server.IBinarySerialize" /><see langword=".Read" /> methods.</summary>
147-
<remarks>
148-
<format type="text/markdown"><![CDATA[
149-
150-
## Remarks
151-
The aggregate must specify a value for `MaxByteSize`.
152-
153-
Specify the <xref:Microsoft.SqlServer.Server.SqlUserDefinedTypeAttribute.IsByteOrdered%2A> attribute property. The default value is false.
154-
155-
If you omit any field in the <xref:Microsoft.SqlServer.Server.IBinarySerialize.Read%2A> or <xref:Microsoft.SqlServer.Server.IBinarySerialize.Write%2A> methods, the state of that field is not serialized.
156-
157-
]]></format>
158-
</remarks>
152+
<summary>This serialization format gives the developer full control over the binary format through the <see cref="M:Microsoft.SqlServer.Server.IBinarySerialize.Write(System.IO.BinaryWriter)" /> and <see cref="M:Microsoft.SqlServer.Server.IBinarySerialize.Read(System.IO.BinaryReader)" /> methods.</summary>
159153
</Docs>
160154
</Member>
161155
</Members>
162-
</Type>
156+
</Type>

xml/System.Activities.Hosting/WorkflowInstanceState.xml

Lines changed: 4 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,7 @@
3434
</ReturnValue>
3535
<MemberValue>3</MemberValue>
3636
<Docs>
37-
<summary>The <see cref="T:System.Activities.Hosting.WorkflowInstance" /> is aborted.</summary>
38-
<remarks>
39-
<format type="text/markdown"><![CDATA[
40-
41-
## Remarks
42-
The workflow instance will be in this state after <xref:System.Activities.WorkflowApplication.Abort%2A> has been called. A workflow in this state is capable of being resumed using <xref:System.Activities.WorkflowApplication.Run%2A>.
43-
44-
]]></format>
45-
</remarks>
37+
<summary>The <see cref="T:System.Activities.Hosting.WorkflowInstance" /> is aborted. The workflow instance will be in this state after <see cref="Overload:System.Activities.WorkflowApplication.Abort" /> has been called. A workflow in this state is capable of being resumed using <see cref="Overload:System.Activities.WorkflowApplication.Run" />.</summary>
4638
</Docs>
4739
</Member>
4840
<Member MemberName="Complete">
@@ -62,15 +54,7 @@
6254
</ReturnValue>
6355
<MemberValue>2</MemberValue>
6456
<Docs>
65-
<summary>The <see cref="T:System.Activities.Hosting.WorkflowInstance" /> is complete.</summary>
66-
<remarks>
67-
<format type="text/markdown"><![CDATA[
68-
69-
## Remarks
70-
A workflow in this state has exited, and its <xref:System.Activities.WorkflowApplication.Completed%2A> or <xref:System.Activities.WorkflowInvoker.InvokeCompleted> event has executed.
71-
72-
]]></format>
73-
</remarks>
57+
<summary>The <see cref="T:System.Activities.Hosting.WorkflowInstance" /> is complete. A workflow in this state has exited, and its <see cref="P:System.Activities.WorkflowApplication.Completed" /> delegate or <see cref="E:System.Activities.WorkflowInvoker.InvokeCompleted" /> event has executed.</summary>
7458
</Docs>
7559
</Member>
7660
<Member MemberName="Idle">
@@ -90,15 +74,7 @@
9074
</ReturnValue>
9175
<MemberValue>0</MemberValue>
9276
<Docs>
93-
<summary>The <see cref="T:System.Activities.Hosting.WorkflowInstance" /> is idle.</summary>
94-
<remarks>
95-
<format type="text/markdown"><![CDATA[
96-
97-
## Remarks
98-
A workflow in this state is waiting on an incoming event, such as when executing a <xref:System.Activities.Statements.Pick> activity, or is waiting for the expiration of a timeout, such as when executing a <xref:System.Activities.Statements.Delay> activity.
99-
100-
]]></format>
101-
</remarks>
77+
<summary>The <see cref="T:System.Activities.Hosting.WorkflowInstance" /> is idle. A workflow in this state is waiting on an incoming event, such as when executing a <see cref="T:System.Activities.Statements.Pick" /> activity, or is waiting for the expiration of a timeout, such as when executing a <see cref="T:System.Activities.Statements.Delay" /> activity.</summary>
10278
</Docs>
10379
</Member>
10480
<Member MemberName="Runnable">
@@ -118,15 +94,7 @@
11894
</ReturnValue>
11995
<MemberValue>1</MemberValue>
12096
<Docs>
121-
<summary>The <see cref="T:System.Activities.Hosting.WorkflowInstance" /> can be run.</summary>
122-
<remarks>
123-
<format type="text/markdown"><![CDATA[
124-
125-
## Remarks
126-
A workflow in this state has been created, but <xref:System.Activities.WorkflowApplication.Run%2A> has not been called.
127-
128-
]]></format>
129-
</remarks>
97+
<summary>The <see cref="T:System.Activities.Hosting.WorkflowInstance" /> can be run. A workflow in this state has been created but <see cref="Overload:System.Activities.WorkflowApplication.Run" /> has not been called.</summary>
13098
</Docs>
13199
</Member>
132100
</Members>

xml/System.Activities.Presentation.Validation/ValidationState.xml

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,6 @@
4343
<MemberValue>1</MemberValue>
4444
<Docs>
4545
<summary>A value that represents that validation found a child activity to be invalid.</summary>
46-
<remarks>
47-
<format type="text/markdown"><![CDATA[
48-
49-
## Remarks
50-
The numeric values of each of the enumeration values indicate the severity of the error. The value associated with the invalid child activity is 1.
51-
52-
]]></format>
53-
</remarks>
5446
</Docs>
5547
</Member>
5648
<Member MemberName="Error">
@@ -71,14 +63,6 @@
7163
<MemberValue>3</MemberValue>
7264
<Docs>
7365
<summary>A value that indicates that an error occurred during the validation of an activity.</summary>
74-
<remarks>
75-
<format type="text/markdown"><![CDATA[
76-
77-
## Remarks
78-
The numeric values of each of the enumeration values indicate the severity of the error. The value associated with the error state is 3.
79-
80-
]]></format>
81-
</remarks>
8266
</Docs>
8367
</Member>
8468
<Member MemberName="Valid">
@@ -99,14 +83,6 @@
9983
<MemberValue>0</MemberValue>
10084
<Docs>
10185
<summary>A value that indicates that an activity is valid.</summary>
102-
<remarks>
103-
<format type="text/markdown"><![CDATA[
104-
105-
## Remarks
106-
The numeric values of each of the enumeration values indicate the severity of the error. The value associated with the valid state is 0.
107-
108-
]]></format>
109-
</remarks>
11086
</Docs>
11187
</Member>
11288
<Member MemberName="Warning">
@@ -127,14 +103,6 @@
127103
<MemberValue>2</MemberValue>
128104
<Docs>
129105
<summary>A value that indicates that a warning occurred during the validation of an activity.</summary>
130-
<remarks>
131-
<format type="text/markdown"><![CDATA[
132-
133-
## Remarks
134-
The numeric values of each of the enumeration values indicate the severity of the error. The value associated with the warning state is 2.
135-
136-
]]></format>
137-
</remarks>
138106
</Docs>
139107
</Member>
140108
</Members>

xml/System.Activities/ActivityInstanceState.xml

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,7 @@
4444
</ReturnValue>
4545
<MemberValue>2</MemberValue>
4646
<Docs>
47-
<summary>Specifies that the activity is in a canceled state.</summary>
48-
<remarks>
49-
<format type="text/markdown"><![CDATA[
50-
51-
## Remarks
52-
Canceled is a terminal state for an activity instance. A Canceled activity completed without performing the function it was designed to perform.
53-
54-
]]></format>
55-
</remarks>
47+
<summary><para>Specifies that the activity is in a canceled state.</para><para>Canceled is a terminal state for an activity instance. A Canceled activity completes without performing the function it was designed to perform.</para></summary>
5648
</Docs>
5749
</Member>
5850
<Member MemberName="Closed">
@@ -77,15 +69,7 @@
7769
</ReturnValue>
7870
<MemberValue>1</MemberValue>
7971
<Docs>
80-
<summary>Specifies that the activity is in a closed state.</summary>
81-
<remarks>
82-
<format type="text/markdown"><![CDATA[
83-
84-
## Remarks
85-
Closed is a terminal state for an activity instance. A Closed activity completed successfully and performed the function it was designed to perform.
86-
87-
]]></format>
88-
</remarks>
72+
<summary><para>Specifies that the activity is in a closed state.</para><para>Closed is a terminal state for an activity instance. A Closed activity completed successfully and performed the function it was designed to perform.</para></summary>
8973
</Docs>
9074
</Member>
9175
<Member MemberName="Executing">

0 commit comments

Comments
 (0)