From 80ee702f587502cef177b7069e56094d97ed825f Mon Sep 17 00:00:00 2001 From: Eric StJohn Date: Tue, 17 Sep 2024 14:20:27 -0700 Subject: [PATCH 1/2] Add missing docs for Task API --- .../ManualResetValueTaskSourceCore`1.xml | 4 ++-- xml/System.Threading.Tasks/Task.xml | 20 +++++++++---------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/xml/System.Threading.Tasks.Sources/ManualResetValueTaskSourceCore`1.xml b/xml/System.Threading.Tasks.Sources/ManualResetValueTaskSourceCore`1.xml index 2ce89d87cf9..c3bea58c952 100644 --- a/xml/System.Threading.Tasks.Sources/ManualResetValueTaskSourceCore`1.xml +++ b/xml/System.Threading.Tasks.Sources/ManualResetValueTaskSourceCore`1.xml @@ -57,7 +57,7 @@ - + Specifies the type of results of the operation represented by this instance. Provides the core logic for implementing a manual-reset or . To be added. @@ -308,7 +308,7 @@ - + The exception. Complets with an error. To be added. diff --git a/xml/System.Threading.Tasks/Task.xml b/xml/System.Threading.Tasks/Task.xml index 4ee9e333bdf..38e48bd7977 100644 --- a/xml/System.Threading.Tasks/Task.xml +++ b/xml/System.Threading.Tasks/Task.xml @@ -6720,7 +6720,7 @@ An exception was thrown during - To be added. + The type of the result returned by the tasks. The tasks to wait on for completion. Creates a task that will complete when all of the supplied tasks have completed. A task that represents the completion of all of the supplied tasks. @@ -7178,7 +7178,7 @@ The returned task will complete when any of the supplied tasks has completed. T - To be added. + The type of the result returned by the tasks. The tasks to wait on for completion. Creates a task that will complete when any of the supplied tasks have completed. A task that represents the completion of one of the supplied tasks. The return Task's Result is the task that completed. @@ -7352,7 +7352,7 @@ The returned task will complete when any of the supplied tasks has completed. T - To be added. + The task to iterate through when completed. To be added. To be added. To be added. @@ -7394,7 +7394,7 @@ The returned task will complete when any of the supplied tasks has completed. T - To be added. + The task to iterate through when completed. To be added. To be added. To be added. @@ -7484,8 +7484,8 @@ The returned task will complete when any of the supplied tasks has completed. T - To be added. - To be added. + The type of the result returned by the tasks. + The task to iterate through when completed. To be added. To be added. To be added. @@ -7537,8 +7537,8 @@ The returned task will complete when any of the supplied tasks has completed. T - To be added. - To be added. + The type of the result returned by the tasks. + The task to iterate through when completed. To be added. To be added. To be added. @@ -7590,8 +7590,8 @@ The returned task will complete when any of the supplied tasks has completed. T - To be added. - To be added. + The type of the result returned by the tasks. + The task to iterate through when completed. To be added. To be added. To be added. From 961439342801931adc368e4d72c6626776b22f6d Mon Sep 17 00:00:00 2001 From: Eric StJohn Date: Tue, 17 Sep 2024 14:48:10 -0700 Subject: [PATCH 2/2] Apply suggestions from code review --- xml/System.Threading.Tasks/Task.xml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xml/System.Threading.Tasks/Task.xml b/xml/System.Threading.Tasks/Task.xml index 38e48bd7977..d50b02fb187 100644 --- a/xml/System.Threading.Tasks/Task.xml +++ b/xml/System.Threading.Tasks/Task.xml @@ -7352,7 +7352,7 @@ The returned task will complete when any of the supplied tasks has completed. T - The task to iterate through when completed. + The tasks to iterate through as they complete. To be added. To be added. To be added. @@ -7394,7 +7394,7 @@ The returned task will complete when any of the supplied tasks has completed. T - The task to iterate through when completed. + The tasks to iterate through as they complete. To be added. To be added. To be added. @@ -7485,7 +7485,7 @@ The returned task will complete when any of the supplied tasks has completed. T The type of the result returned by the tasks. - The task to iterate through when completed. + The tasks to iterate through as they complete. To be added. To be added. To be added. @@ -7538,7 +7538,7 @@ The returned task will complete when any of the supplied tasks has completed. T The type of the result returned by the tasks. - The task to iterate through when completed. + The tasks to iterate through as they complete. To be added. To be added. To be added. @@ -7591,7 +7591,7 @@ The returned task will complete when any of the supplied tasks has completed. T The type of the result returned by the tasks. - The task to iterate through when completed. + The tasks to iterate through as they complete. To be added. To be added. To be added.