From 18ac7ffc32b14b7fe2af4595eb563c06637bd431 Mon Sep 17 00:00:00 2001 From: Loni Tra Date: Wed, 2 Oct 2024 15:55:03 -0700 Subject: [PATCH 1/5] add remaining system drawing documentation --- xml/System.Drawing.Imaging.Effects/Effect.xml | 12 ++++++------ xml/System.Drawing/SystemColors.xml | 9 ++++++--- xml/ns-System.Drawing.Imaging.Effects.xml | 2 +- 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/xml/System.Drawing.Imaging.Effects/Effect.xml b/xml/System.Drawing.Imaging.Effects/Effect.xml index 36190cb47a4..b1c84411466 100644 --- a/xml/System.Drawing.Imaging.Effects/Effect.xml +++ b/xml/System.Drawing.Imaging.Effects/Effect.xml @@ -47,12 +47,12 @@ - - + + - + - + Method System.Drawing.Common @@ -65,8 +65,8 @@ - To be added. - To be added. + if managed resources should be disposed; otherwise, . + Releases the resources that are used by the object. To be added. diff --git a/xml/System.Drawing/SystemColors.xml b/xml/System.Drawing/SystemColors.xml index 0198a235e90..6c21d9197b4 100644 --- a/xml/System.Drawing/SystemColors.xml +++ b/xml/System.Drawing/SystemColors.xml @@ -1344,9 +1344,12 @@ System.Boolean - To be added. - To be added. - To be added. + Gets or sets whether the alternative color set is used. + When , system values will return the alternative color set (as returned by statics or ). This is currently "dark mode" variants of the system colors. + + values are always looked up every time you use them and do not retain any other context. As such, existing values will change when this property is set. + On Windows, system values will always return the current Windows color when the OS has a high contrast theme enabled. + diff --git a/xml/ns-System.Drawing.Imaging.Effects.xml b/xml/ns-System.Drawing.Imaging.Effects.xml index 54c6851f1f8..f4ce0e9025b 100644 --- a/xml/ns-System.Drawing.Imaging.Effects.xml +++ b/xml/ns-System.Drawing.Imaging.Effects.xml @@ -1,6 +1,6 @@ - To be added. + Provides functionality for adding effects to images. To be added. From 1b99e5377b6c21eec9ad19c6cd497e6bb0d871b7 Mon Sep 17 00:00:00 2001 From: Loni Tra Date: Wed, 2 Oct 2024 16:15:20 -0700 Subject: [PATCH 2/5] revert Effect.Dispose being protected --- xml/System.Drawing.Imaging.Effects/Effect.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Drawing.Imaging.Effects/Effect.xml b/xml/System.Drawing.Imaging.Effects/Effect.xml index b1c84411466..df03e34af64 100644 --- a/xml/System.Drawing.Imaging.Effects/Effect.xml +++ b/xml/System.Drawing.Imaging.Effects/Effect.xml @@ -47,12 +47,12 @@ - - + + - + - + Method System.Drawing.Common From 339c17ba1dd4cad3bfb0a5a9f96742f5789675c8 Mon Sep 17 00:00:00 2001 From: Loni Tra Date: Wed, 2 Oct 2024 16:17:14 -0700 Subject: [PATCH 3/5] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com> --- xml/System.Drawing.Imaging.Effects/Effect.xml | 5 +++-- xml/System.Drawing/SystemColors.xml | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/xml/System.Drawing.Imaging.Effects/Effect.xml b/xml/System.Drawing.Imaging.Effects/Effect.xml index df03e34af64..663e141612b 100644 --- a/xml/System.Drawing.Imaging.Effects/Effect.xml +++ b/xml/System.Drawing.Imaging.Effects/Effect.xml @@ -65,8 +65,9 @@ - if managed resources should be disposed; otherwise, . - Releases the resources that are used by the object. + + to release both managed and unmanaged resources; false to release only unmanaged resources. + Releases the unmanaged resources used by the and optionally releases the managed resources. To be added. diff --git a/xml/System.Drawing/SystemColors.xml b/xml/System.Drawing/SystemColors.xml index 6c21d9197b4..434381a922e 100644 --- a/xml/System.Drawing/SystemColors.xml +++ b/xml/System.Drawing/SystemColors.xml @@ -1345,10 +1345,10 @@ Gets or sets whether the alternative color set is used. - When , system values will return the alternative color set (as returned by statics or ). This is currently "dark mode" variants of the system colors. + When , system values will return the alternative color set (as returned by statics or ). This is currently "dark mode" variants of the system colors. - values are always looked up every time you use them and do not retain any other context. As such, existing values will change when this property is set. - On Windows, system values will always return the current Windows color when the OS has a high contrast theme enabled. + values are always looked up every time you use them and do not retain any other context. As such, existing values will change when this property is set. + On Windows, system values will always return the current Windows color when the OS has a high contrast theme enabled. From 97f1ff24085d145526b1a4ec8ab6d51827c8b00d Mon Sep 17 00:00:00 2001 From: Loni Tra Date: Wed, 2 Oct 2024 16:30:43 -0700 Subject: [PATCH 4/5] Add langword for false MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com> --- xml/System.Drawing.Imaging.Effects/Effect.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Drawing.Imaging.Effects/Effect.xml b/xml/System.Drawing.Imaging.Effects/Effect.xml index 663e141612b..e1ee59ac49b 100644 --- a/xml/System.Drawing.Imaging.Effects/Effect.xml +++ b/xml/System.Drawing.Imaging.Effects/Effect.xml @@ -66,7 +66,7 @@ - to release both managed and unmanaged resources; false to release only unmanaged resources. + to release both managed and unmanaged resources; to release only unmanaged resources. Releases the unmanaged resources used by the and optionally releases the managed resources. To be added. From 9a8d4293742f76958c3a42b18545e25ef0d38df5 Mon Sep 17 00:00:00 2001 From: Loni Tra Date: Thu, 3 Oct 2024 09:22:12 -0700 Subject: [PATCH 5/5] Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- xml/System.Drawing/SystemColors.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Drawing/SystemColors.xml b/xml/System.Drawing/SystemColors.xml index 434381a922e..d0182dc52f9 100644 --- a/xml/System.Drawing/SystemColors.xml +++ b/xml/System.Drawing/SystemColors.xml @@ -1344,11 +1344,11 @@ System.Boolean - Gets or sets whether the alternative color set is used. + Gets or sets a value that indicates whether the alternative color set is used. When , system values will return the alternative color set (as returned by statics or ). This is currently "dark mode" variants of the system colors. values are always looked up every time you use them and do not retain any other context. As such, existing values will change when this property is set. - On Windows, system values will always return the current Windows color when the OS has a high contrast theme enabled. + On Windows, system values always return the current Windows color when the OS has a high contrast theme enabled.