From 5df2942b806c4113eab4cfb7e30fe7970249d62a Mon Sep 17 00:00:00 2001 From: Radek Zikmund Date: Mon, 7 Oct 2024 11:28:50 +0200 Subject: [PATCH 1/6] Fix reference to SslCertificateTrust on Ssl*AuthenticationOptions --- xml/System.Net.Security/SslClientAuthenticationOptions.xml | 3 ++- xml/System.Net.Security/SslServerAuthenticationOptions.xml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/xml/System.Net.Security/SslClientAuthenticationOptions.xml b/xml/System.Net.Security/SslClientAuthenticationOptions.xml index 00bae12908c..50934810521 100644 --- a/xml/System.Net.Security/SslClientAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslClientAuthenticationOptions.xml @@ -193,7 +193,8 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation. If not , and are ignored. + Gets or sets an optional customized policy for remote certificate validation. If not , and . are ignored. + To be added. To be added. diff --git a/xml/System.Net.Security/SslServerAuthenticationOptions.xml b/xml/System.Net.Security/SslServerAuthenticationOptions.xml index 6336d4fc5a1..4d86333404c 100644 --- a/xml/System.Net.Security/SslServerAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslServerAuthenticationOptions.xml @@ -189,7 +189,7 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation. If not , and are ignored. + Gets or sets an optional customized policy for remote certificate validation. If not , and . are ignored. To be added. To be added. From 6973ba404254a808a295397d9c9e5ca6accc2e16 Mon Sep 17 00:00:00 2001 From: Radek Zikmund Date: Mon, 7 Oct 2024 12:33:08 +0200 Subject: [PATCH 2/6] Fix build --- xml/System.Net.Security/SslClientAuthenticationOptions.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/xml/System.Net.Security/SslClientAuthenticationOptions.xml b/xml/System.Net.Security/SslClientAuthenticationOptions.xml index 50934810521..aa1e48daa6d 100644 --- a/xml/System.Net.Security/SslClientAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslClientAuthenticationOptions.xml @@ -194,7 +194,6 @@ Gets or sets an optional customized policy for remote certificate validation. If not , and . are ignored. - To be added. To be added. From 8d421c808c3051e4fe3c786cea9e25296a833844 Mon Sep 17 00:00:00 2001 From: Radek Zikmund Date: Mon, 7 Oct 2024 13:10:19 +0200 Subject: [PATCH 3/6] Fix class name --- xml/System.Net.Security/SslClientAuthenticationOptions.xml | 2 +- xml/System.Net.Security/SslServerAuthenticationOptions.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Net.Security/SslClientAuthenticationOptions.xml b/xml/System.Net.Security/SslClientAuthenticationOptions.xml index aa1e48daa6d..9bfe3a9ff55 100644 --- a/xml/System.Net.Security/SslClientAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslClientAuthenticationOptions.xml @@ -193,7 +193,7 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation. If not , and . are ignored. + Gets or sets an optional customized policy for remote certificate validation. If not , and . are ignored. To be added. To be added. diff --git a/xml/System.Net.Security/SslServerAuthenticationOptions.xml b/xml/System.Net.Security/SslServerAuthenticationOptions.xml index 4d86333404c..66caccf63fd 100644 --- a/xml/System.Net.Security/SslServerAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslServerAuthenticationOptions.xml @@ -189,7 +189,7 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation. If not , and . are ignored. + Gets or sets an optional customized policy for remote certificate validation. If not , and . are ignored. To be added. To be added. From 49923912915483ec21f5103038d972178af52ddf Mon Sep 17 00:00:00 2001 From: Radek Zikmund Date: Mon, 7 Oct 2024 13:50:45 +0200 Subject: [PATCH 4/6] Reword --- xml/System.Net.Security/SslClientAuthenticationOptions.xml | 2 +- xml/System.Net.Security/SslServerAuthenticationOptions.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Net.Security/SslClientAuthenticationOptions.xml b/xml/System.Net.Security/SslClientAuthenticationOptions.xml index 9bfe3a9ff55..823b6284c4a 100644 --- a/xml/System.Net.Security/SslClientAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslClientAuthenticationOptions.xml @@ -193,7 +193,7 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation. If not , and . are ignored. + Gets or sets an optional customized policy for remote certificate validation. If not , and used to create the instance are ignored. To be added. To be added. diff --git a/xml/System.Net.Security/SslServerAuthenticationOptions.xml b/xml/System.Net.Security/SslServerAuthenticationOptions.xml index 66caccf63fd..38cf6a5dbc6 100644 --- a/xml/System.Net.Security/SslServerAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslServerAuthenticationOptions.xml @@ -189,7 +189,7 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation. If not , and . are ignored. + Gets or sets an optional customized policy for remote certificate validation. If not , and used to create the instance are ignored. To be added. To be added. From 2e9a5bf681a2215e122277d6aacbe8f6fa00cf4f Mon Sep 17 00:00:00 2001 From: Radek Zikmund Date: Tue, 8 Oct 2024 15:11:11 +0200 Subject: [PATCH 5/6] Suggestions from code review --- .../SslClientAuthenticationOptions.xml | 13 +++++++++++-- .../SslServerAuthenticationOptions.xml | 15 ++++++++++++--- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/xml/System.Net.Security/SslClientAuthenticationOptions.xml b/xml/System.Net.Security/SslClientAuthenticationOptions.xml index 823b6284c4a..122b216690f 100644 --- a/xml/System.Net.Security/SslClientAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslClientAuthenticationOptions.xml @@ -193,9 +193,18 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation. If not , and used to create the instance are ignored. + Gets or sets an optional customized policy for remote certificate validation To be added. - To be added. + + property is ignored. + +When the value of this property is not `null`, any associated with the is ignored. +]]> + diff --git a/xml/System.Net.Security/SslServerAuthenticationOptions.xml b/xml/System.Net.Security/SslServerAuthenticationOptions.xml index 38cf6a5dbc6..d77d949fa9f 100644 --- a/xml/System.Net.Security/SslServerAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslServerAuthenticationOptions.xml @@ -189,9 +189,18 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation. If not , and used to create the instance are ignored. + Gets or sets an optional customized policy for remote certificate validation To be added. - To be added. + + property is ignored. + +When the value of this property is not `null` and a was provided to the value in the property, the trust list SslCertificateTrust will be sent in the handshake (when so configured) but the trust settings from this property will not be used when verifying any client authentication certificates. +]]> + @@ -494,4 +503,4 @@ - + \ No newline at end of file From 0bdf9e40596dfb3c3bce406015c893047242b0c3 Mon Sep 17 00:00:00 2001 From: Radek Zikmund <32671551+rzikm@users.noreply.github.com> Date: Wed, 9 Oct 2024 09:24:33 +0200 Subject: [PATCH 6/6] Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- xml/System.Net.Security/SslClientAuthenticationOptions.xml | 7 ++++--- xml/System.Net.Security/SslServerAuthenticationOptions.xml | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/xml/System.Net.Security/SslClientAuthenticationOptions.xml b/xml/System.Net.Security/SslClientAuthenticationOptions.xml index 122b216690f..651ca67a99b 100644 --- a/xml/System.Net.Security/SslClientAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslClientAuthenticationOptions.xml @@ -193,16 +193,17 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation + Gets or sets an optional customized policy for remote certificate validation. To be added. property is ignored. +When the value of this property is not `null`: -When the value of this property is not `null`, any associated with the is ignored. +- The value of the property is ignored. +- Any associated with the is ignored. ]]> diff --git a/xml/System.Net.Security/SslServerAuthenticationOptions.xml b/xml/System.Net.Security/SslServerAuthenticationOptions.xml index d77d949fa9f..245ae531b5a 100644 --- a/xml/System.Net.Security/SslServerAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslServerAuthenticationOptions.xml @@ -189,16 +189,17 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation + Gets or sets an optional customized policy for remote certificate validation. To be added. property is ignored. +When the value of this property is not `null`: -When the value of this property is not `null` and a was provided to the value in the property, the trust list SslCertificateTrust will be sent in the handshake (when so configured) but the trust settings from this property will not be used when verifying any client authentication certificates. +- The value of the property is ignored. +- If an was provided to the value in the property, the trust list `SslCertificateTrust` will be sent in the handshake (when so configured), but the trust settings from this property aren't used when verifying any client authentication certificates. ]]>