From 6bb990de78a02599f7e5d029830cbbc10391a157 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marie=20P=C3=ADchov=C3=A1?= <11718369+ManickaP@users.noreply.github.com> Date: Tue, 8 Oct 2024 14:41:49 +0200 Subject: [PATCH 1/7] Add note about UrlEncode (#10506) --- xml/System.Net/WebUtility.xml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/xml/System.Net/WebUtility.xml b/xml/System.Net/WebUtility.xml index 88314b9ba49..7e518392ed0 100644 --- a/xml/System.Net/WebUtility.xml +++ b/xml/System.Net/WebUtility.xml @@ -556,6 +556,9 @@ Each ' ' (space) character is converted to a `+` (plus) character. +> [!NOTE] +> Replacing ' ' (space) with a '+' (plus) sign is expected only in query part of URI (by convention, not by standard) or in [`application/x-www-form-urlencoded`](https://url.spec.whatwg.org/#percent-encoded-bytes) HTTP content. Moreover, the above mentioned list of characters that are **not** replaced does not correspond neither to [URL specification](https://url.spec.whatwg.org) nor URI [RFC 3986](https://www.rfc-editor.org/rfc/rfc3986.html#section-3.4). Use for RFC compliant transformation. + For example, when embedded in a block of text to be transmitted in a URL, the characters `<` and `>` are encoded as `%3c` and `%3e`. The method reverses the encoding. @@ -636,6 +639,11 @@ - `(` and `)` (opening and closing parentheses) + Each ' ' (space) character is converted to a `+` (plus) character. + +> [!NOTE] +> Replacing ' ' (space) with a '+' (plus) sign is expected only in query part of URI (by convention, not by standard) or in [`application/x-www-form-urlencoded`](https://url.spec.whatwg.org/#percent-encoded-bytes) HTTP content. Moreover, the above mentioned list of characters that are **not** replaced does not correspond neither to [URL specification](https://url.spec.whatwg.org) nor URI [RFC 3986](https://www.rfc-editor.org/rfc/rfc3986.html#section-3.4). Use for RFC compliant transformation. + For example, when embedded in a block of text to be transmitted in a URL, the characters `<` and `>` are encoded as `%3c` and `%3e`. The method reverses the encoding. From a912c46b0d0a983a87f2bbd8e1415615dba88ce5 Mon Sep 17 00:00:00 2001 From: Loni Tra Date: Tue, 8 Oct 2024 09:03:08 -0700 Subject: [PATCH 2/7] Add Last System.Drawing Documentation for .NET 9 (#10490) --- xml/System.Drawing.Imaging.Effects/Effect.xml | 5 +++-- xml/System.Drawing/SystemColors.xml | 9 ++++++--- xml/ns-System.Drawing.Imaging.Effects.xml | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/xml/System.Drawing.Imaging.Effects/Effect.xml b/xml/System.Drawing.Imaging.Effects/Effect.xml index 36190cb47a4..e1ee59ac49b 100644 --- a/xml/System.Drawing.Imaging.Effects/Effect.xml +++ b/xml/System.Drawing.Imaging.Effects/Effect.xml @@ -65,8 +65,9 @@ - To be added. - To be added. + + to release both managed and unmanaged resources; to release only unmanaged resources. + Releases the unmanaged resources used by the and optionally releases the managed resources. To be added. diff --git a/xml/System.Drawing/SystemColors.xml b/xml/System.Drawing/SystemColors.xml index 0198a235e90..d0182dc52f9 100644 --- a/xml/System.Drawing/SystemColors.xml +++ b/xml/System.Drawing/SystemColors.xml @@ -1344,9 +1344,12 @@ System.Boolean - To be added. - To be added. - To be added. + Gets or sets a value that indicates whether the alternative color set is used. + When , system values will return the alternative color set (as returned by statics or ). This is currently "dark mode" variants of the system colors. + + values are always looked up every time you use them and do not retain any other context. As such, existing values will change when this property is set. + On Windows, system values always return the current Windows color when the OS has a high contrast theme enabled. + diff --git a/xml/ns-System.Drawing.Imaging.Effects.xml b/xml/ns-System.Drawing.Imaging.Effects.xml index 54c6851f1f8..f4ce0e9025b 100644 --- a/xml/ns-System.Drawing.Imaging.Effects.xml +++ b/xml/ns-System.Drawing.Imaging.Effects.xml @@ -1,6 +1,6 @@ - To be added. + Provides functionality for adding effects to images. To be added. From 7a2bcf4b504eed50c50b7d54bba9429a3fff8621 Mon Sep 17 00:00:00 2001 From: Aidy Jenkins Date: Tue, 8 Oct 2024 18:14:32 +0100 Subject: [PATCH 3/7] Corrected description for indexer (#10486) --- xml/System.Data.Common/DbConnectionStringBuilder.xml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xml/System.Data.Common/DbConnectionStringBuilder.xml b/xml/System.Data.Common/DbConnectionStringBuilder.xml index da880354bcf..1ae1d15b1a5 100644 --- a/xml/System.Data.Common/DbConnectionStringBuilder.xml +++ b/xml/System.Data.Common/DbConnectionStringBuilder.xml @@ -1123,7 +1123,7 @@ builder2.EquivalentTo(builder3) = False The key of the item to get or set. Gets or sets the value associated with the specified key. - The value associated with the specified key. If the specified key is not found, trying to get it returns a null reference ( in Visual Basic), and trying to set it creates a new element using the specified key. + The value associated with the specified key. If the specified key is not found, trying to get it throws an , and trying to set it creates a new element using the specified key. Passing a null ( in Visual Basic) key throws an . Assigning a null value removes the key/value pair. @@ -1142,6 +1142,8 @@ builder2.EquivalentTo(builder3) = False ]]> + + The value for has not been set in the collection. is a null reference ( in Visual Basic). The property is set, and the is read-only. From 75a7ed160696b8ba84cf9612502310741eccf2c3 Mon Sep 17 00:00:00 2001 From: "Andy (Steve) De George" <67293991+adegeo@users.noreply.github.com> Date: Tue, 8 Oct 2024 13:15:44 -0700 Subject: [PATCH 4/7] Update .repoman.yml (#10515) --- .repoman.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.repoman.yml b/.repoman.yml index 8211c0f3390..f8812508746 100644 --- a/.repoman.yml +++ b/.repoman.yml @@ -1,5 +1,5 @@ -revision: 2 -schema-version: 1 +revision: 3 +schema-version: 5 owner-ms-alias: adegeo config: @@ -9,6 +9,8 @@ config: ParserRegex: "^\\* (.*): (.*)$" + ContentUrlRegex: + - "### Page URL\n\n(.*)" issues: @@ -17,7 +19,7 @@ issues: # Temporary label to mark issues as updated for Quest. The label is instantly removed - check: - type: query - value: "length(Issue.labels[?name == ':world_map: mapQUEST']) != `0`" + value: "length(Issue.Labels[?Name == ':world_map: mapQUEST']) != `0`" pass: - labels-remove: [":world_map: mapQUEST"] From 059c8fd7205094e4f8cedd0fe043398c1252bc59 Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Tue, 8 Oct 2024 14:25:35 -0700 Subject: [PATCH 5/7] Temp update (#10516) --- .github/policies/disallow-edits.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/policies/disallow-edits.yml b/.github/policies/disallow-edits.yml index ee9f6a9089f..daad0073abd 100644 --- a/.github/policies/disallow-edits.yml +++ b/.github/policies/disallow-edits.yml @@ -11,6 +11,8 @@ configuration: - isAction: action: Opened - or: + - filesMatchPattern: + pattern: xml/NewFolder/* - includesModifiedFiles: files: - xml/Microsoft.Extensions*/* From 17e926623e0d53655a49b8741210aea8e6496ca5 Mon Sep 17 00:00:00 2001 From: Radek Zikmund <32671551+rzikm@users.noreply.github.com> Date: Wed, 9 Oct 2024 09:54:59 +0200 Subject: [PATCH 6/7] Fix reference to SslCertificateTrust on Ssl*AuthenticationOptions (#10505) * Fix reference to SslCertificateTrust on Ssl*AuthenticationOptions * Fix build * Fix class name * Reword * Suggestions from code review * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --------- Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- .../SslClientAuthenticationOptions.xml | 14 ++++++++++++-- .../SslServerAuthenticationOptions.xml | 16 +++++++++++++--- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/xml/System.Net.Security/SslClientAuthenticationOptions.xml b/xml/System.Net.Security/SslClientAuthenticationOptions.xml index 00bae12908c..651ca67a99b 100644 --- a/xml/System.Net.Security/SslClientAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslClientAuthenticationOptions.xml @@ -193,9 +193,19 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation. If not , and are ignored. + Gets or sets an optional customized policy for remote certificate validation. To be added. - To be added. + + property is ignored. +- Any associated with the is ignored. +]]> + diff --git a/xml/System.Net.Security/SslServerAuthenticationOptions.xml b/xml/System.Net.Security/SslServerAuthenticationOptions.xml index 6336d4fc5a1..245ae531b5a 100644 --- a/xml/System.Net.Security/SslServerAuthenticationOptions.xml +++ b/xml/System.Net.Security/SslServerAuthenticationOptions.xml @@ -189,9 +189,19 @@ System.Security.Cryptography.X509Certificates.X509ChainPolicy - Gets or sets an optional customized policy for remote certificate validation. If not , and are ignored. + Gets or sets an optional customized policy for remote certificate validation. To be added. - To be added. + + property is ignored. +- If an was provided to the value in the property, the trust list `SslCertificateTrust` will be sent in the handshake (when so configured), but the trust settings from this property aren't used when verifying any client authentication certificates. +]]> + @@ -494,4 +504,4 @@ - + \ No newline at end of file From 28b1a38225f0c25883386ab8cf091df211739c89 Mon Sep 17 00:00:00 2001 From: Shay Rojansky Date: Wed, 9 Oct 2024 13:10:45 +0200 Subject: [PATCH 7/7] Correct docs for DbConnection.State (#10509) Fixes #10503 --- xml/System.Data.Common/DbConnection.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Data.Common/DbConnection.xml b/xml/System.Data.Common/DbConnection.xml index 8b7e65153e2..2d5a7b860f2 100644 --- a/xml/System.Data.Common/DbConnection.xml +++ b/xml/System.Data.Common/DbConnection.xml @@ -1954,8 +1954,8 @@ This property returns `false` by default; providers that implement System.Data.ConnectionState - Gets a string that describes the state of the connection. - The state of the connection. The format of the string returned depends on the specific type of connection you are using. + Gets a value that describes the state of the connection. + The state of the connection, for example, open or closed. To be added. ADO.NET Overview