From 18040dae717a2fc48af952029f8c5e782060d1ee Mon Sep 17 00:00:00 2001 From: Richard Szalay Date: Thu, 17 Oct 2024 03:08:06 +1100 Subject: [PATCH 1/4] Fix Lock "compiler speclet" URL (#10564) * Fix Lock "compiler speclet" URL * Update Lock.xml speclet URL to published --- xml/System.Threading/Lock.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Threading/Lock.xml b/xml/System.Threading/Lock.xml index ea145acaf9e..2882e6c0fcb 100644 --- a/xml/System.Threading/Lock.xml +++ b/xml/System.Threading/Lock.xml @@ -30,7 +30,7 @@ It is recommended to use the method w :::code language="csharp" source="~/snippets/csharp/System.Threading/Lock/Overview/UsagePatterns.cs" id="Snippet1"::: -When using the C# `lock` keyword or similar to enter and exit a lock, the type of the expression must be precisely `System.Threading.Lock`. If the type of the expression is anything else, such as `Object` or a generic type like `T`, a different implementation that is not interchangeable can be used instead (such as ). For more information, see the relevant [compiler speclet](https://github.com/dotnet/csharplang/blob/main/proposals/lock-object.md). +When using the C# `lock` keyword or similar to enter and exit a lock, the type of the expression must be precisely `System.Threading.Lock`. If the type of the expression is anything else, such as `Object` or a generic type like `T`, a different implementation that is not interchangeable can be used instead (such as ). For more information, see the relevant [compiler speclet](https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-13.0/lock-object). can interrupt threads that are waiting to enter a lock. On Windows STA threads, waits for locks allow message pumping that can run other code on the same thread during a wait. Some features of the waits can be overridden by a custom . From 76b6f0eed66ed932cc2859be48d8d84d5091f42b Mon Sep 17 00:00:00 2001 From: Kevin Jones Date: Wed, 16 Oct 2024 12:41:04 -0400 Subject: [PATCH 2/4] Port System.Formats.Asn1 docs for .NET 9 (#10576) --- xml/System.Formats.Asn1/AsnDecoder.xml | 54 +++++++++++++++++++------- 1 file changed, 41 insertions(+), 13 deletions(-) diff --git a/xml/System.Formats.Asn1/AsnDecoder.xml b/xml/System.Formats.Asn1/AsnDecoder.xml index d04d7a494b2..c5cb1a00042 100644 --- a/xml/System.Formats.Asn1/AsnDecoder.xml +++ b/xml/System.Formats.Asn1/AsnDecoder.xml @@ -43,12 +43,25 @@ - To be added. - To be added. - To be added. - To be added. - To be added. - To be added. + The buffer containing encoded data. + The encoding constraints to use when interpreting the data. + + When this method returns, contains the number of bytes from the beginning of that contributed to the length. + This parameter is treated as uninitialized. + + + Decodes the data in as a length value under the specified encoding rules. + + + The decoded value of the length, or if the encoded length represents the indefinite length. + + + This method only processes the length portion of an ASN.1/BER Tag-Length-Value triplet, so needs to have already sliced off the encoded tag. + + + is not a known value. + + does not decode as a length under the specified encoding rules. @@ -1165,13 +1178,28 @@ The contents are not valid under the current encoding rules. - To be added. - To be added. - To be added. - To be added. - To be added. - To be added. - To be added. + The buffer containing encoded data. + The encoding constraints to use when interpreting the data. + + When this method returns, contains the decoded value of the length, or if the encoded length represents the indefinite length. + This parameter is treated as uninitialized. + + + When this method returns, contains the number of bytes from the beginning of that contributed to the length. + This parameter is treated as uninitialized. + + + Attempts to decode the data in as a length value under the specified encoding rules. + + + + if the buffer represents a valid length under the specified encoding rules; otherwise, + + + This method only processes the length portion of an ASN.1/BER Tag-Length-Value triplet, so needs to have already sliced off the encoded tag. + + + is not a known value. From fc5f40f851b6e72bd7883cf7b55e8b152b68db09 Mon Sep 17 00:00:00 2001 From: Filip Toth <68369112+FilipToth@users.noreply.github.com> Date: Wed, 16 Oct 2024 19:25:21 +0200 Subject: [PATCH 3/4] Add docs remarks for `IsRealNumber` handling of infinities (#10565) --- xml/System.Numerics/INumberBase`1.xml | 2 ++ xml/System.Runtime.InteropServices/NFloat.xml | 2 ++ xml/System/Double.xml | 2 ++ xml/System/Half.xml | 2 ++ xml/System/Single.xml | 2 ++ 5 files changed, 10 insertions(+) diff --git a/xml/System.Numerics/INumberBase`1.xml b/xml/System.Numerics/INumberBase`1.xml index 64ab0860fe3..3df600bb29f 100644 --- a/xml/System.Numerics/INumberBase`1.xml +++ b/xml/System.Numerics/INumberBase`1.xml @@ -758,6 +758,8 @@ A return value of `false` does not imply that diff --git a/xml/System.Runtime.InteropServices/NFloat.xml b/xml/System.Runtime.InteropServices/NFloat.xml index f0a569ddbd0..441f3c9ecea 100644 --- a/xml/System.Runtime.InteropServices/NFloat.xml +++ b/xml/System.Runtime.InteropServices/NFloat.xml @@ -2372,6 +2372,8 @@ A return value of `false` does not imply that and . + ]]> diff --git a/xml/System/Double.xml b/xml/System/Double.xml index f6fa9a0892a..c4b76c89738 100644 --- a/xml/System/Double.xml +++ b/xml/System/Double.xml @@ -3112,6 +3112,8 @@ A return value of `false` does not imply that and . + ]]> diff --git a/xml/System/Half.xml b/xml/System/Half.xml index 39b31d39520..e227a13ee1a 100644 --- a/xml/System/Half.xml +++ b/xml/System/Half.xml @@ -2318,6 +2318,8 @@ A return value of `false` does not imply that and . + ]]> diff --git a/xml/System/Single.xml b/xml/System/Single.xml index a9f07dff7ed..5f3ce1aa09c 100644 --- a/xml/System/Single.xml +++ b/xml/System/Single.xml @@ -3129,6 +3129,8 @@ A return value of `false` does not imply that and . + ]]> From ada2cc15da15a6b99ae12e5facc085f0a2b9d9cf Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Thu, 17 Oct 2024 06:55:00 -0700 Subject: [PATCH 4/4] Fix activity sender (#10577) --- .github/policies/auto-merge.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/policies/auto-merge.yml b/.github/policies/auto-merge.yml index ac804633aed..4519201e7a8 100644 --- a/.github/policies/auto-merge.yml +++ b/.github/policies/auto-merge.yml @@ -18,9 +18,7 @@ configuration: branch: main - or: - isActivitySender: - user: dependabot - - isActivitySender: - user: dependabot[bot] + user: dotnet-policy-service[bot] then: - enableAutoMerge: mergeMethod: Squash