Fixes #10633 - multiple statements simplified by removing explicit comparison #10698

robbyc073 · 2024-11-20T22:28:23Z

Summary

Multiple if and while statements simplified by removing explicit comparison and replacing with logical NOT operator as required.

Fixes #10633

…cit comparison

robbyc073 · 2024-11-20T22:38:37Z

@dotnet-policy-bot agree

robbyc073 · 2024-11-20T22:40:10Z

@dotnet-policy-service agree

gewarren

Thanks - a few things to fix before we can merge.

snippets/cpp/VS_Snippets_Remoting/NclMailASync/cpp/mailasync.cpp

...csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-1.5.1-vsdoc.js

snippets/csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-1.5.1.js

...s/csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-ui-1.8.11.js

...rp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/microsoftmvcajax.debug.js

…/Overview/scripts/jquery-1.5.1.js Co-authored-by: Genevieve Warren <[email protected]>

…/Overview/scripts/jquery-ui-1.8.11.js Co-authored-by: Genevieve Warren <[email protected]>

…et-api-docs into robbyc073-changes Add changes made in GitHub conversation.

Co-authored-by: Rob <[email protected]>

learn-build-service-prod · 2024-11-27T22:18:10Z

Learn Build status updates of commit d148167:

✅ Validation status: passed

File	Status	Preview URL
snippets/common/VS_Snippets_WebNet/Classic RequiredFieldValidator Example/Common/source.xml	✅Succeeded	View
snippets/cpp/VS_Snippets_CLR_System/system.GC.ReRegisterForFinalize Example/CPP/class1.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_CLR_System/system.Random.Next/CPP/next3.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_CLR_System/system.runtime.compilerservices.internalsvisibletoattribute/cpp/friend1.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_CLR_System/system.String.Format/cpp/formatexample2.cpp	✅Succeeded
snippets/cpp/VS_Snippets_CLR/AsyncDelegateExamples/cpp/polling.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_CLR/console.beep/CPP/beep.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_CLR/console.cursorvis/CPP/vis.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_CLR/console.keyavailable/CPP/ka.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_CLR/directoryinfocreatesub/CPP/directoryinfocreatesub.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_CLR/T.TryParse/CPP/tp.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/ClassicTcpClient.PublicMethodsAndPropertiesExample/CPP/source.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/DiscoveryDocument_DiscoveryDocument/CPP/discoverydocument_discoverydocument.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/DiscoveryExceptionDictionary_Property_Method/CPP/discoveryexceptiondictionary_property_method.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/DiscoveryReferenceCollection/CPP/discoveryreferencecollection.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/IChannelReceiver_StartListening_ChannelData/CPP/ichannelreceiver_channeldata_server.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/Message.Acknowledgment/CPP/message_acknowledgment.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Receive_TimeoutTransaction/CPP/mqreceive_timeouttransaction.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Receive_transaction/CPP/mqreceive_transaction.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Send_obj/CPP/mqsend_generic.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Send_ObjectTransaction/CPP/mqsend_objtransaction.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/NCLCredPolicy/CPP/NCLCredPolicy.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/NCLFtpClient/CPP/ftptests.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/NclMailASync/cpp/mailasync.cpp	✅Succeeded	View
snippets/cpp/VS_Snippets_Remoting/NCLNetInfo2/CPP/networkexamples.cpp	✅Succeeded	View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

Robert Coleman and others added 2 commits November 20, 2024 14:47

Fixes dotnet#10633 - multiple statements simplified by removing expli…

88b7986

…cit comparison

Merge branch 'dotnet:main' into robbyc073-changes

9d92d19

robbyc073 requested a review from a team as a code owner November 20, 2024 22:28

ghost added the area-Infrastructure label Nov 20, 2024

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 20, 2024