Skip to content

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Feb 19, 2025

The wording is mostly borrowed from the Stream.Read* variants but saying the peer socket performed a graceful shutdown instead of end of the stream has been reached, which describes the EOF reason more specifically in this case.

Fixes #10925.

Copy link

Learn Build status updates of commit 424c7cb:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/NetworkStream.xml ✅Succeeded View
xml/System.Net.Sockets/Socket.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo existing comments

Co-authored-by: Genevieve Warren <[email protected]>
Copy link

Learn Build status updates of commit 963bf8e:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/NetworkStream.xml ✅Succeeded View
xml/System.Net.Sockets/Socket.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@antonfirsov antonfirsov merged commit f73c11e into dotnet:main Feb 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.Net.Sockets.NetworkStream.Read(Byte[], Int32, Int32)

3 participants