From 0acaa28551372d9be95306269ea6caf38f816459 Mon Sep 17 00:00:00 2001 From: Rageking8 <106309953+Rageking8@users.noreply.github.com> Date: Sat, 1 Mar 2025 18:50:01 +0800 Subject: [PATCH 1/4] Fix example output of `BigInteger(Int64)` --- snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs | 4 ++-- snippets/fsharp/System.Numerics/BigInteger/.ctor/Example2.fs | 4 ++-- .../system.Numerics.BigInteger.ctors/vb/Example2.vb | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs b/snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs index c9f66fd5150..6621574a98f 100644 --- a/snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs +++ b/snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs @@ -98,13 +98,13 @@ private static void LongConstructor() constructed.Equals(assigned)); } // The example displays the following output: - // -2147483648 = -2147483648: True + // -9223372036854775808 = -9223372036854775808: True // -10534 = -10534: True // -189 = -189: True // 0 = 0: True // 17 = 17: True // 113439 = 113439: True - // 2147483647 = 2147483647: True + // 9223372036854775807 = 9223372036854775807: True // } diff --git a/snippets/fsharp/System.Numerics/BigInteger/.ctor/Example2.fs b/snippets/fsharp/System.Numerics/BigInteger/.ctor/Example2.fs index b1b1795d0ba..dc29be16b7d 100644 --- a/snippets/fsharp/System.Numerics/BigInteger/.ctor/Example2.fs +++ b/snippets/fsharp/System.Numerics/BigInteger/.ctor/Example2.fs @@ -63,13 +63,13 @@ let longConstructor () = let assigned = number printfn $"{constructed} = {assigned}: {constructed.Equals assigned}" // The example displays the following output: - // -2147483648 = -2147483648: True + // -9223372036854775808 = -9223372036854775808: True // -10534 = -10534: True // -189 = -189: True // 0 = 0: True // 17 = 17: True // 113439 = 113439: True - // 2147483647 = 2147483647: True + // 9223372036854775807 = 9223372036854775807: True // let singleConstructor () = diff --git a/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb b/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb index 105da819fa0..a9feb270c42 100644 --- a/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb +++ b/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb @@ -92,13 +92,13 @@ Module Example constructed.Equals(assigned)) Next ' The example displays the following output: - ' -2147483648 = -2147483648: True + ' -9223372036854775808 = -9223372036854775808: True ' -10534 = -10534: True ' -189 = -189: True ' 0 = 0: True ' 17 = 17: True ' 113439 = 113439: True - ' 2147483647 = 2147483647: True + ' 9223372036854775807 = 9223372036854775807: True ' End Sub From a9430540857fc4f0d8db3bb5b2dffdf1d30fe29f Mon Sep 17 00:00:00 2001 From: Rageking8 <106309953+Rageking8@users.noreply.github.com> Date: Sat, 1 Mar 2025 19:12:43 +0800 Subject: [PATCH 2/4] Add missing project files --- .../csharp/System.Numerics/BigInteger/.ctor/Project.csproj | 6 ++++++ .../system.Numerics.BigInteger.ctors/vb/Project.vbproj | 6 ++++++ 2 files changed, 12 insertions(+) create mode 100644 snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj create mode 100644 snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj diff --git a/snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj b/snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj new file mode 100644 index 00000000000..6671ae009a7 --- /dev/null +++ b/snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj @@ -0,0 +1,6 @@ + + + Library + net6.0 + + \ No newline at end of file diff --git a/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj b/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj new file mode 100644 index 00000000000..b4581b53236 --- /dev/null +++ b/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj @@ -0,0 +1,6 @@ + + + Library + net6.0 + + \ No newline at end of file From 06d30e8c052d9a3293e4b210235f8d2cb1ffbbc0 Mon Sep 17 00:00:00 2001 From: Rageking8 <106309953+Rageking8@users.noreply.github.com> Date: Sat, 1 Mar 2025 19:23:56 +0800 Subject: [PATCH 3/4] Resolve `Example` identifier conflict --- snippets/csharp/System.Numerics/BigInteger/.ctor/Example1.cs | 2 +- snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs | 2 +- .../system.Numerics.BigInteger.ctors/vb/Example1.vb | 2 +- .../system.Numerics.BigInteger.ctors/vb/Example2.vb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/snippets/csharp/System.Numerics/BigInteger/.ctor/Example1.cs b/snippets/csharp/System.Numerics/BigInteger/.ctor/Example1.cs index abe5043c114..3ca8a377178 100644 --- a/snippets/csharp/System.Numerics/BigInteger/.ctor/Example1.cs +++ b/snippets/csharp/System.Numerics/BigInteger/.ctor/Example1.cs @@ -1,7 +1,7 @@ using System; using System.Numerics; -public class Example +public class Example1 { public static void Main() { diff --git a/snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs b/snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs index 6621574a98f..bc797c9045a 100644 --- a/snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs +++ b/snippets/csharp/System.Numerics/BigInteger/.ctor/Example2.cs @@ -1,7 +1,7 @@ using System; using System.Numerics; -public class Example +public class Example2 { public static void Main() { diff --git a/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example1.vb b/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example1.vb index a2795960b0d..6b5a2951d09 100644 --- a/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example1.vb +++ b/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example1.vb @@ -3,7 +3,7 @@ Option Strict On Imports System.Numerics -Module Example +Module Example1 Public Sub Main() Console.WindowWidth = 90 CreateSimpleArray() diff --git a/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb b/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb index a9feb270c42..3c25a3eb326 100644 --- a/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb +++ b/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Example2.vb @@ -3,7 +3,7 @@ Option Strict On Imports System.Numerics -Module Example +Module Example2 Public Sub Main() DecimalConstructor() Console.WriteLine("-----") From 2c529c8b7c8e8ac4b25d2f55db9053619fe6736e Mon Sep 17 00:00:00 2001 From: Bill Wagner Date: Mon, 3 Mar 2025 10:48:50 -0500 Subject: [PATCH 4/4] Apply suggestions from code review --- .../csharp/System.Numerics/BigInteger/.ctor/Project.csproj | 2 +- .../system.Numerics.BigInteger.ctors/vb/Project.vbproj | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj b/snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj index 6671ae009a7..9bb79615f63 100644 --- a/snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj +++ b/snippets/csharp/System.Numerics/BigInteger/.ctor/Project.csproj @@ -1,6 +1,6 @@ Library - net6.0 + net9.0 \ No newline at end of file diff --git a/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj b/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj index b4581b53236..9a84e38014e 100644 --- a/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj +++ b/snippets/visualbasic/VS_Snippets_CLR_System/system.Numerics.BigInteger.ctors/vb/Project.vbproj @@ -1,6 +1,7 @@ Library - net6.0 + net9.0 + \ No newline at end of file