From d338a0615807a336eda171ca43dc46f647b09ac5 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 18 Jun 2025 12:23:55 +0000 Subject: [PATCH 1/5] Initial plan for issue From 24e816148ab52b8a8847ef1183a501f9b810d8b1 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 18 Jun 2025 12:29:36 +0000 Subject: [PATCH 2/5] Add deprecation warning to Uri.UserEscaped property documentation Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com> --- xml/System/Uri.xml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xml/System/Uri.xml b/xml/System/Uri.xml index 44207b6a580..45c2afba303 100644 --- a/xml/System/Uri.xml +++ b/xml/System/Uri.xml @@ -6030,7 +6030,11 @@ The following examples show a URI and the results of calling property is set to `true` to indicate that the string used to create the instance was completely escaped before it was passed to the constructor; that is, the `dontEscape` parameter of the constructor call was set to `true`. + +> [!CAUTION] +> The property represents deprecated functionality that will not work as expected. The `dontEscape` parameter referenced by this property has been deprecated since .NET Framework 4 and will always be `false`. As a result, this property will always return `false` and should not be used to determine URI escaping behavior. + + The property was originally designed to indicate that the string used to create the instance was completely escaped before it was passed to the constructor; that is, the `dontEscape` parameter of the constructor call was set to `true`. However, since the `dontEscape` parameter is now obsolete and always treated as `false`, this property will always return `false`. ## Examples The following example creates a instance and determines whether it was fully escaped when it was created. From 22efb7f1f85d3cb1e9cf468ab6f0bf6379b29782 Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Wed, 18 Jun 2025 15:10:30 +0200 Subject: [PATCH 3/5] Update xml/System/Uri.xml --- xml/System/Uri.xml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/xml/System/Uri.xml b/xml/System/Uri.xml index 45c2afba303..9bb5af86513 100644 --- a/xml/System/Uri.xml +++ b/xml/System/Uri.xml @@ -6031,10 +6031,7 @@ The following examples show a URI and the results of calling [!CAUTION] -> The property represents deprecated functionality that will not work as expected. The `dontEscape` parameter referenced by this property has been deprecated since .NET Framework 4 and will always be `false`. As a result, this property will always return `false` and should not be used to determine URI escaping behavior. - - The property was originally designed to indicate that the string used to create the instance was completely escaped before it was passed to the constructor; that is, the `dontEscape` parameter of the constructor call was set to `true`. However, since the `dontEscape` parameter is now obsolete and always treated as `false`, this property will always return `false`. + The property was originally designed to indicate that the string used to create the instance was completely escaped before it was passed to the constructor; that is, the `dontEscape` parameter of the constructor call was set to `true`. However, since the `dontEscape` parameter is now obsolete and always treated as `false`, this property always returns `false`. ## Examples The following example creates a instance and determines whether it was fully escaped when it was created. From e585436aaae5b8e7cb832d2bdfb7743e1a47a70d Mon Sep 17 00:00:00 2001 From: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Date: Wed, 18 Jun 2025 16:07:31 +0200 Subject: [PATCH 4/5] Update xml/System/Uri.xml --- xml/System/Uri.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System/Uri.xml b/xml/System/Uri.xml index 9bb5af86513..43ef680cbff 100644 --- a/xml/System/Uri.xml +++ b/xml/System/Uri.xml @@ -6031,7 +6031,7 @@ The following examples show a URI and the results of calling property was originally designed to indicate that the string used to create the instance was completely escaped before it was passed to the constructor; that is, the `dontEscape` parameter of the constructor call was set to `true`. However, since the `dontEscape` parameter is now obsolete and always treated as `false`, this property always returns `false`. +The constructors that have a `dontEscape` parameter have been obsolete since .NET Framework 2.0 and shouldn't be used. As a result, this property is deprecated and shouldn't be used either. ## Examples The following example creates a instance and determines whether it was fully escaped when it was created. From f440f4b861916bc249acaff8631a706be48229a2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 18 Jun 2025 14:11:00 +0000 Subject: [PATCH 5/5] Remove misleading "always false" claim from Uri.UserEscaped documentation Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com> --- xml/System/Uri.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System/Uri.xml b/xml/System/Uri.xml index 43ef680cbff..c0cec77e4be 100644 --- a/xml/System/Uri.xml +++ b/xml/System/Uri.xml @@ -6031,7 +6031,7 @@ The following examples show a URI and the results of calling constructors that have a `dontEscape` parameter have been obsolete since .NET Framework 2.0 and shouldn't be used. As a result, this property is deprecated and shouldn't be used either. +The property was originally designed to indicate that the string used to create the instance was completely escaped before it was passed to the constructor; that is, the `dontEscape` parameter of the constructor call was set to `true`. However, since the `dontEscape` parameter is now obsolete, this property is deprecated and shouldn't be used. ## Examples The following example creates a instance and determines whether it was fully escaped when it was created.