make AddRange method example more readable #11910
Open
+137
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
|
Would it be better to remove the project file? It causes namespace conflicts. The same issue happens with #11781. |
|
Go for it @StuartMosquera |
snippets/csharp/System.Collections.Generic/ListT/.ctor/source1.cs
Outdated
Show resolved
Hide resolved
|
Sorry, that's the whole point of that Snippets 5000 status check. We should add back the project file and use different names to fix the build warnings. |
|
Yeah, it's compiling the folder via that project file. Simply change the names of the classes (or make them partial) and get the code compiling. This way we make sure we ship accurate code. |
krwq
reviewed
Oct 8, 2025
| Imports System.Collections.Generic | ||
|
|
||
| Public Class Example | ||
| Partial Public Class Example |
There was a problem hiding this comment.
don't want to sound like archeologist but there are also dinosaurs in this file
krwq
reviewed
Oct 8, 2025
Comment on lines
-5
to
8
|
|
||
| public class Example | ||
| public partial class Example | ||
| { | ||
| public static void Main() | ||
| public static void ShowFruits() | ||
| { |
There was a problem hiding this comment.
you can use top-level statements here
krwq
reviewed
Oct 8, 2025
| Partial Public Class Example | ||
|
|
||
| Public Shared Sub Main() | ||
| Public Shared Sub ShowDinos() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AddRangemethod of theList<T>class by replacing dinosaur names with fruits to enhance readability, for both C# and VB.NET.Fixes #11833