From 338b880eb266e73268c07793f883f71f749092f9 Mon Sep 17 00:00:00 2001 From: Ron Petrusha Date: Mon, 10 Jun 2019 09:34:42 -0700 Subject: [PATCH 1/2] Fix broken xrefs --- xml/System.IO/WindowsRuntimeStreamExtensions.xml | 4 ++-- xml/System.Text.Json/Utf8JsonWriter.xml | 2 +- xml/System/DateTime.xml | 5 +++-- xml/System/Math.xml | 12 +++++++----- xml/System/StackOverflowException.xml | 1 + 5 files changed, 14 insertions(+), 10 deletions(-) diff --git a/xml/System.IO/WindowsRuntimeStreamExtensions.xml b/xml/System.IO/WindowsRuntimeStreamExtensions.xml index 931e6f9fd5e..acdbc646eb7 100644 --- a/xml/System.IO/WindowsRuntimeStreamExtensions.xml +++ b/xml/System.IO/WindowsRuntimeStreamExtensions.xml @@ -89,7 +89,7 @@ Here's the XAML code that is associated with the previous example. ## Remarks > [!NOTE] -> In Visual Basic and C#, you can call this method as an instance method on any object of type . When you use instance method syntax to call this method, omit the first parameter. For more information, see [Extension Methods (Visual Basic)](~/docs/visual-basic/programming-guide/language-features/procedures/extension-methods.md) or [Extension Methods (C# Programming Guide)](~/docs/csharp/programming-guide/classes-and-structs/extension-methods.md). +> In Visual Basic and C#, you can call this method as an instance method on any object of type . When you use instance method syntax to call this method, omit the first parameter. For more information, see [Extension Methods (Visual Basic)](~/docs/visual-basic/programming-guide/language-features/procedures/extension-methods.md) or [Extension Methods (C# Programming Guide)](~/docs/csharp/programming-guide/classes-and-structs/extension-methods.md). ## Examples @@ -435,7 +435,7 @@ In most situations, buffering improves the performance of stream operations. You > [!NOTE] > In Visual Basic and C#, you can call this method as an instance method on any object of type . When you use instance method syntax to call this method, omit the first parameter. For more information, see [Extension Methods (Visual Basic)](~/docs/visual-basic/programming-guide/language-features/procedures/extension-methods.md) or [Extension Methods (C# Programming Guide)](~/docs/csharp/programming-guide/classes-and-structs/extension-methods.md). -A default buffer size of 16,384 bytes is used when converting the stream. To specify a different buffer size, use the overload. +A default buffer size of 16,384 bytes is used when converting the stream. To specify a different buffer size, use the overload. ## Examples The following example shows how to use the and methods to convert a managed stream to and from a stream in the Windows Runtime. diff --git a/xml/System.Text.Json/Utf8JsonWriter.xml b/xml/System.Text.Json/Utf8JsonWriter.xml index 15c98c07261..871e746e428 100644 --- a/xml/System.Text.Json/Utf8JsonWriter.xml +++ b/xml/System.Text.Json/Utf8JsonWriter.xml @@ -58,7 +58,7 @@ To be able to format the output with indentation and white space OR to skip vali The destination for writing JSON text. Defines the customized behavior of the By default, it writes minimized JSON (with no extra whitespace) and validates that the JSON being written is structurally valid according to the JSON RFC. - Constructs a new instance with a specified . + Constructs a new instance with a specified . To be added. is . diff --git a/xml/System/DateTime.xml b/xml/System/DateTime.xml index aef9f2c8749..3bfa6b333ad 100644 --- a/xml/System/DateTime.xml +++ b/xml/System/DateTime.xml @@ -4812,7 +4812,8 @@ juillet 2009 Converts the string representation of a date and time to its equivalent. ## Remarks In this section: @@ -4955,7 +4956,7 @@ The `DateTime.Parse` overloads return a value whose + ## Remarks In this section: @@ -4500,7 +4500,7 @@ In this section: - [Midpoint values and rounding conventions](#midpoint-values-and-rounding-conventions) - [Rounding and precision](#rounding-and-precision) - [Rounding and single-precision floating point values](#rounding-and-single-precision-floating-point-values) -- [Examples of individual overloads](#examples) +- [Examples of individual overloads](#round-examples) ### Which method do I call? @@ -4513,7 +4513,7 @@ You can use the following table to select an appropriate rounding method. In add |Round a number to a specified number of fractional digits by using the rounding to nearest convention.|

-or-

| |Round a number to a specified number of fractional digits by using a specified rounding convention.|

-or-

| |Round a value to a specified number of fractional digits by using a specified rounding convention and minimizing the loss of precision.|Convert the to a and call .| -|Round a number to a specified number of fractional digits while minimizing problems of precision in rounding midpoint values.|Call a rounding method that implements a "greater than or approximately equal to" comparison. See [Rounding and precision](#Precision).| +|Round a number to a specified number of fractional digits while minimizing problems of precision in rounding midpoint values.|Call a rounding method that implements a "greater than or approximately equal to" comparison. See [Rounding and precision](#precision).| |Round a fractional value to an integer that is greater than the fractional value. For example, round 3.1 to 4.|| |Round a fractional value to an integer that is less than the fractional value. For example, round 3.9 to 3.|| @@ -4555,6 +4555,7 @@ By default, the method uses the rounding to nearest ||Determined by `mode` parameter| ||Determined by `mode` parameter| + ### Rounding and precision In order to determine whether a rounding operation involves a midpoint value, the method multiplies the original value to be rounded by 10n, where *n* is the desired number of fractional digits in the return value, and then determines whether the remaining fractional portion of the value is greater than or equal to .5. This is a slight variation on a test for equality, and as discussed in the "Testing for Equality" section of the reference topic, tests for equality with floating-point values are problematic because of the floating-point format's issues with binary representation and precision. This means that any fractional portion of a number that is slightly less than .5 (because of a loss of precision) will not be rounded upward. @@ -4572,7 +4573,7 @@ Problems of precision in rounding midpoint values are most likely to arise in th - When the value to be rounded is calculated from one or more floating-point operations. -- When the value to be rounded is a rather than a or . For more information, see the next section, [Rounding and single-precision floating-point values](#Single). +- When the value to be rounded is a rather than a or . For more information, see the next section, [Rounding and single-precision floating-point values](#rounding-and-single-precision-floating-point-values). In cases where the lack of precision in rounding operations is problematic, you can do the following: @@ -4593,7 +4594,8 @@ The method includes overloads that accept arguments This unexpected result is due to a loss of precision in the conversion of the value to a . Because the resulting value of 16.325000762939453 is not a midpoint value and is greater than 16.325, it is always rounded upward. In many cases, as the example illustrates, the loss of precision can be minimized or eliminated by casting or converting the value to a . Note that, because this is a narrowing conversion, it requires using a cast operator or calling a conversion method. - + + ## Examples In addition to the examples in the [Remarks](#remarks-round) section, this article includes examples that illustrate the following overloads of the `Math.Round` method: diff --git a/xml/System/StackOverflowException.xml b/xml/System/StackOverflowException.xml index d6976c67af0..f581e00b6fa 100644 --- a/xml/System/StackOverflowException.xml +++ b/xml/System/StackOverflowException.xml @@ -52,6 +52,7 @@ See the [Examples](#examples) section for an illustration of this technique. If your app hosts the common language runtime (CLR), it can specify that the CLR should unload the application domain where the stack overflow exception occurs and let the corresponding process continue. For more information, see [ICLRPolicyManager Interface](~/docs/framework/unmanaged-api/hosting/iclrpolicymanager-interface.md). + ## Examples The following example uses a counter to ensure that the number of recursive calls to the `Execute` method do not exceed a maximum defined by the MAX_RECURSIVE_CALLS constant. From 88fd5e5091064317b275fdffd83492989306b42a Mon Sep 17 00:00:00 2001 From: Ron Petrusha Date: Tue, 11 Jun 2019 11:51:27 -0700 Subject: [PATCH 2/2] Reverted changes identified by bug --- xml/System/DateTime.xml | 3 +-- xml/System/StackOverflowException.xml | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/xml/System/DateTime.xml b/xml/System/DateTime.xml index 3bfa6b333ad..17c6d6cd55d 100644 --- a/xml/System/DateTime.xml +++ b/xml/System/DateTime.xml @@ -4813,7 +4813,6 @@ juillet 2009 ## Remarks In this section: @@ -4956,7 +4955,7 @@ The `DateTime.Parse` overloads return a value whose ## Examples The following example uses a counter to ensure that the number of recursive calls to the `Execute` method do not exceed a maximum defined by the MAX_RECURSIVE_CALLS constant.