From c4f34ca24564edcf4dc00c8d9a22d1aa549a229d Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Mon, 22 Jul 2019 15:41:22 -0700 Subject: [PATCH 1/4] Document System.Runtime.AmbiguousImplementationException --- .../AmbiguousImplementationException.xml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xml/System.Runtime/AmbiguousImplementationException.xml b/xml/System.Runtime/AmbiguousImplementationException.xml index 7e8c2842541..6026bdc1033 100644 --- a/xml/System.Runtime/AmbiguousImplementationException.xml +++ b/xml/System.Runtime/AmbiguousImplementationException.xml @@ -14,7 +14,7 @@ - To be added. + The exception that is thrown when there is an ambiguous implementation causing diamond inheritance situation. This situation happens when there are multiple incompatible interface methods overriding another method. To be added. @@ -31,7 +31,7 @@ - To be added. + Initializes a new instance of the class. To be added. @@ -51,8 +51,8 @@ - To be added. - To be added. + The localized error message string. + Initializes a new instance of the class with a specified error message. To be added. @@ -73,9 +73,9 @@ - To be added. - To be added. - To be added. + The localized error message string. + The exception that is the cause of the current exception. If the parameter is not a null reference ( in Visual Basic), the current exception is raised in a block that handles the inner exception. + Initializes a new instance of the class with a specified error message and a reference to the inner exception that is the cause of this exception. To be added. From 0e6623ebc2cda081982d724b992252af99be3554 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 23 Jul 2019 09:32:28 -0700 Subject: [PATCH 2/4] suggestions by bartonjs Co-Authored-By: Jeremy Barton --- xml/System.Runtime/AmbiguousImplementationException.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xml/System.Runtime/AmbiguousImplementationException.xml b/xml/System.Runtime/AmbiguousImplementationException.xml index 6026bdc1033..92f18d4b99c 100644 --- a/xml/System.Runtime/AmbiguousImplementationException.xml +++ b/xml/System.Runtime/AmbiguousImplementationException.xml @@ -14,7 +14,7 @@ - The exception that is thrown when there is an ambiguous implementation causing diamond inheritance situation. This situation happens when there are multiple incompatible interface methods overriding another method. + The exception that is thrown when there are multiple incompatible interface methods overriding another method. To be added. @@ -74,10 +74,10 @@ The localized error message string. - The exception that is the cause of the current exception. If the parameter is not a null reference ( in Visual Basic), the current exception is raised in a block that handles the inner exception. + The exception that is the cause of the current exception. Initializes a new instance of the class with a specified error message and a reference to the inner exception that is the cause of this exception. To be added. - \ No newline at end of file + From 458249ecc292e858dc52f96dc2389fde595d252e Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 23 Jul 2019 09:38:38 -0700 Subject: [PATCH 3/4] remark suggested by MichalStrehovsky --- .../AmbiguousImplementationException.xml | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/xml/System.Runtime/AmbiguousImplementationException.xml b/xml/System.Runtime/AmbiguousImplementationException.xml index 92f18d4b99c..67d98b5f932 100644 --- a/xml/System.Runtime/AmbiguousImplementationException.xml +++ b/xml/System.Runtime/AmbiguousImplementationException.xml @@ -15,7 +15,19 @@ The exception that is thrown when there are multiple incompatible interface methods overriding another method. - To be added. + + + From b25ee218ad459a41e0562903f8f86e3a135277b4 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 23 Jul 2019 13:49:31 -0700 Subject: [PATCH 4/4] suggestions by rpetrusha Co-Authored-By: Ron Petrusha --- xml/System.Runtime/AmbiguousImplementationException.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Runtime/AmbiguousImplementationException.xml b/xml/System.Runtime/AmbiguousImplementationException.xml index 67d98b5f932..e0d3d600318 100644 --- a/xml/System.Runtime/AmbiguousImplementationException.xml +++ b/xml/System.Runtime/AmbiguousImplementationException.xml @@ -22,7 +22,7 @@ Normally, a compilation error is generated if there are multiple incompatible interface methods implementing another interface method. `AmbiguousImplementationException` is thrown when a type in a dependent assembly implements an interface from an assembly that was modified. -To resolve the error, a most specific implementation of the interface method has to be provided. The most specific implementation of the interface method can be provided on the class that implements the interface, or on another interface that requires the interface providing the conflicting implementation. +To resolve the error, the most specific implementation of the interface method has to be provided. The most specific implementation of the interface method can be provided on the class that implements the interface, or on another interface that requires the interface providing the conflicting implementation. `AmbiguousImplementationException` uses the `HRESULT COR_E_AMBIGUOUSIMPLEMENTATION`, which has a value of `0x8013106A`. @@ -85,7 +85,7 @@ To resolve the error, a most specific implementation of the interface method has - The localized error message string. + A string that describes the error. The exception that is the cause of the current exception. Initializes a new instance of the class with a specified error message and a reference to the inner exception that is the cause of this exception. To be added.