From ad0ff09e54bdb3eb8e28e49ddc03f398cb5e0d3d Mon Sep 17 00:00:00 2001 From: Maryam Ariyan Date: Tue, 23 Jul 2019 09:11:22 -0700 Subject: [PATCH 1/4] docs for VersionConverter.IsValid --- xml/System.ComponentModel/VersionConverter.xml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/xml/System.ComponentModel/VersionConverter.xml b/xml/System.ComponentModel/VersionConverter.xml index 64b12c7e587..97345b1a8ee 100644 --- a/xml/System.ComponentModel/VersionConverter.xml +++ b/xml/System.ComponentModel/VersionConverter.xml @@ -178,11 +178,13 @@ - To be added. - To be added. - To be added. - To be added. + An that provides a format context. + The to test for validity. + Returns whether the given value object is valid for this type and for the specified context. + + if the specified value is valid for this object; otherwise, . To be added. + From e2b9da7e20575dd53e516f86d6fabcbf16b9fefc Mon Sep 17 00:00:00 2001 From: Maryam Ariyan Date: Tue, 23 Jul 2019 10:20:30 -0700 Subject: [PATCH 2/4] Added more missing docs --- xml/System.ComponentModel/VersionConverter.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.ComponentModel/VersionConverter.xml b/xml/System.ComponentModel/VersionConverter.xml index 97345b1a8ee..d6b099d1483 100644 --- a/xml/System.ComponentModel/VersionConverter.xml +++ b/xml/System.ComponentModel/VersionConverter.xml @@ -33,7 +33,7 @@ - To be added. + Initializes a new instance of the class. To be added. @@ -147,14 +147,14 @@ - To be added. + An that provides a format context. The culture that supplies formatting information for the conversion.. The value to be converted.. - To be added. + The to convert the value parameter to. Converts the specified value to the specified destination type using the specified context and arguments. - To be added. + An that represents the converted value. To be added. From 772e5351b68f9ed2083d609beb68bb283e5364a0 Mon Sep 17 00:00:00 2001 From: Maryam Ariyan Date: Tue, 23 Jul 2019 11:45:09 -0700 Subject: [PATCH 3/4] Addressed feedbacks --- xml/System.ComponentModel/VersionConverter.xml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xml/System.ComponentModel/VersionConverter.xml b/xml/System.ComponentModel/VersionConverter.xml index d6b099d1483..f2472bbd68a 100644 --- a/xml/System.ComponentModel/VersionConverter.xml +++ b/xml/System.ComponentModel/VersionConverter.xml @@ -148,13 +148,13 @@ An that provides a format context. - The culture that supplies formatting information for the conversion.. - The value to be converted.. - The to convert the value parameter to. + The culture that supplies formatting information for the conversion. + The value to be converted. + The type to convert the value parameter to. Converts the specified value to the specified destination type using the specified context and arguments. - An that represents the converted value. + An object that represents the converted value. To be added. @@ -179,8 +179,8 @@ An that provides a format context. - The to test for validity. - Returns whether the given value object is valid for this type and for the specified context. + The object to test for validity. + Returns a value that indicates whether the given value object is valid for this type and for the specified context. if the specified value is valid for this object; otherwise, . To be added. From 42ad6824eb1173ae18c5d267a155a99dbff2b7d4 Mon Sep 17 00:00:00 2001 From: Maryam Ariyan Date: Tue, 23 Jul 2019 11:46:26 -0700 Subject: [PATCH 4/4] Removing endline --- xml/System.ComponentModel/VersionConverter.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xml/System.ComponentModel/VersionConverter.xml b/xml/System.ComponentModel/VersionConverter.xml index f2472bbd68a..d01963c309e 100644 --- a/xml/System.ComponentModel/VersionConverter.xml +++ b/xml/System.ComponentModel/VersionConverter.xml @@ -181,8 +181,7 @@ An that provides a format context. The object to test for validity. Returns a value that indicates whether the given value object is valid for this type and for the specified context. - - if the specified value is valid for this object; otherwise, . + if the specified value is valid for this object; otherwise, . To be added.