From fa094d6b89715a5d5269d7a77e74c2cf9458bf27 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Tue, 23 Jul 2019 16:46:30 -0700 Subject: [PATCH 1/2] Suggestions by rpetrusha --- .../GroupCollection.xml | 221 ++++++++++++------ 1 file changed, 145 insertions(+), 76 deletions(-) diff --git a/xml/System.Text.RegularExpressions/GroupCollection.xml b/xml/System.Text.RegularExpressions/GroupCollection.xml index 73888ee0688..b1b1e694315 100644 --- a/xml/System.Text.RegularExpressions/GroupCollection.xml +++ b/xml/System.Text.RegularExpressions/GroupCollection.xml @@ -103,9 +103,9 @@ - To be added. - To be added. - To be added. + A string with the name of the captured group to locate. + Determines whether the group collection contains a captured group identified by the specified name. + if the group collection contains a captured group identified by ; otherwise. To be added. @@ -174,14 +174,12 @@ ]]> - - is . - - is outside the bounds of . - - -or- - - plus is outside the bounds of . + is . + is outside the bounds of . + +-or- + + plus is outside the bounds of . @@ -212,10 +210,17 @@ - To be added. - To be added. - To be added. + The one-dimensional array that is the destination of the elements copied from the group collection. The array must have zero-based indexing. + The zero-based index in at which copying begins. + Copies the elements of the group collection to a array, starting at a particular array index. To be added. + is null. + is less than zero. + +-or- + + is greater than the length of . + The length of - is less than the group collection count. @@ -383,8 +388,7 @@ Gets a value that indicates whether access to the is synchronized (thread-safe). - - in all cases. + in all cases. System.Collections.Generic.IEnumerable<System.String> - To be added. - To be added. + Gets a string enumeration that contains the name keys of the group collection. + The name keys of the group collection. To be added. @@ -667,9 +671,10 @@ - To be added. - To be added. + The group to add to the collection. + Adds a to the collection. Calling this method always throws . To be added. + This method is not supported. This is a read-only collection. @@ -699,8 +704,9 @@ - To be added. + Clears the collection. Calling this method always throws . To be added. + This method is not supported. This is a read-only collection. @@ -732,10 +738,18 @@ - To be added. - To be added. - To be added. - To be added. + The group to locate in the group collection. + Determines whether the group collection contains a specific group item. + if the group item is found in the group collection; otherwise. + + instance is cast to an interface. + + ]]> + @@ -767,10 +781,11 @@ - To be added. - To be added. - To be added. + The group to remove. + Removes a from the collection. Calling this method always throws . + This method is not supported. No value is returned. To be added. + This method is not supported. This is a read-only collection. @@ -798,9 +813,20 @@ - To be added. - To be added. - To be added. + Provides an enumerator that iterates through the group collection. + An enumerator that contains all names and objects in the collection. + + + objects in the collection, you should use the group iteration construct (such as `foreach` in C# and `For Each`…`Next` in Visual Basic) that is provided by your programming language. + + ]]> + + @@ -830,9 +856,19 @@ - To be added. - To be added. - To be added. + Provides an enumerator that iterates through the group collection. + An enumerator that contains all objects in the group collection. + + + objects in the collection, you should use the group iteration construct (such as `foreach` in C# and `For Each`…`Next` in Visual Basic) that is provided by your programming language. + + ]]> + + @@ -864,10 +900,18 @@ - To be added. - To be added. - To be added. - To be added. + The group to locate in the group collection. + Determines the index of a specific group in the group collection. + The index of the if found; otherwise, -1. + + instance is cast to an interface. + + ]]> + @@ -900,10 +944,11 @@ - To be added. - To be added. - To be added. + The position at which to insert the group. + The group to insert. + Inserts a into the collection. Calling this method always throws . To be added. + This method is not supported. This is a read-only collection. @@ -936,10 +981,19 @@ - To be added. - To be added. - To be added. - To be added. + The zero-based index of the group in the group collection. + Gets the group at the specified position in the collection. + The group in the desired position. + + instance is cast to an interface. + + ]]> + + Cannot set an item. This is a read-only collection. @@ -971,9 +1025,10 @@ - To be added. - To be added. + The zero-based index of the group to remove. + Removes the from the collection at the specified index. Calling this method always throws . To be added. + This method is not supported. This is a read-only collection. @@ -1111,10 +1166,10 @@ - To be added. - To be added. - To be added. + The object to add to the group collection. + Adds an object to the group collection. Calling this method always throws . To be added. + This method is not supported. This is a read-only collection. @@ -1144,8 +1199,9 @@ - To be added. + Clears the collection. Calling this method always throws . To be added. + This method is not supported. This is a read-only collection. @@ -1177,9 +1233,9 @@ - To be added. - To be added. - To be added. + The group to locate in the group collection. + Determines whether the group collection contains a specific group item. + if the group item is found in the group collection; otherwise. To be added. @@ -1212,9 +1268,9 @@ - To be added. - To be added. - To be added. + The group to locate in the group collection. + Determines the index of a specific group in the group collection. + The index of the if found; otherwise, -1. To be added. @@ -1248,10 +1304,11 @@ - To be added. - To be added. - To be added. + The position at which to insert the group. + The group to insert. + Inserts a into the collection. Calling this method always throws . To be added. + This method is not supported. This is a read-only collection. @@ -1281,8 +1338,8 @@ System.Boolean - To be added. - To be added. + Gets a value indicating whether the group collection has a fixed size. + always. To be added. @@ -1316,10 +1373,11 @@ - To be added. - To be added. - To be added. + The zero-index position of the group in the group collection. + Gets the group in the desired position. + The group in the desired position. To be added. + Cannot set an item. This is a read-only collection. @@ -1351,9 +1409,11 @@ - To be added. - To be added. + The group to remove. + Removes a from the collection. Calling this method always throws . + This method is not supported. No value is returned. To be added. + This method is not supported. This is a read-only collection. @@ -1385,9 +1445,10 @@ - To be added. - To be added. + The zero-based index of the group to remove. + Removes the from the collection at the specified index. Calling this method always throws . To be added. + This method is not supported. This is a read-only collection. @@ -1416,10 +1477,10 @@ - To be added. - To be added. - To be added. - To be added. + A string with the group name key to look for. + When the method returns, the group whose name is , if it is found; otherwise, if not found. + Attempts to retrieve a group identified by the provided name key, if it exists in the group collection. + if a group identified by the provided name key exists; otherwise. To be added. @@ -1448,9 +1509,17 @@ System.Collections.Generic.IEnumerable<System.Text.RegularExpressions.Group> - To be added. - To be added. - To be added. + Gets a group enumeration with all the groups in the group collection. + A group enumeration. + + instance is cast to an interface. + + ]]> + From 848e45c61e99b889bde0411e9f9df0a8959e00f4 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Thu, 25 Jul 2019 17:32:09 -0700 Subject: [PATCH 2/2] suggestions by rpetrusha Co-Authored-By: Ron Petrusha --- .../GroupCollection.xml | 42 ++++++++++++++++--- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/xml/System.Text.RegularExpressions/GroupCollection.xml b/xml/System.Text.RegularExpressions/GroupCollection.xml index b1b1e694315..52e9b6d3385 100644 --- a/xml/System.Text.RegularExpressions/GroupCollection.xml +++ b/xml/System.Text.RegularExpressions/GroupCollection.xml @@ -1236,7 +1236,15 @@ This member is an explicit interface member implementation. It can be used only The group to locate in the group collection. Determines whether the group collection contains a specific group item. if the group item is found in the group collection; otherwise. - To be added. + + instance is cast to an interface. + + ]]> + @@ -1271,7 +1279,15 @@ This member is an explicit interface member implementation. It can be used only The group to locate in the group collection. Determines the index of a specific group in the group collection. The index of the if found; otherwise, -1. - To be added. + + instance is cast to an interface. + + ]]> + @@ -1340,7 +1356,15 @@ This member is an explicit interface member implementation. It can be used only Gets a value indicating whether the group collection has a fixed size. always. - To be added. + + instance is cast to an interface. + + ]]> + @@ -1376,7 +1400,15 @@ This member is an explicit interface member implementation. It can be used only The zero-index position of the group in the group collection. Gets the group in the desired position. The group in the desired position. - To be added. + + instance is cast to an interface. + + ]]> + Cannot set an item. This is a read-only collection. @@ -1523,4 +1555,4 @@ This member is an explicit interface member implementation. It can be used only - \ No newline at end of file +